Skip to content

KVM: x86: Fix max_irr reporting when PIR is empty despite PID.ON

Chenyi Qiang kvm stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 0 repliesNew

Changes in v2 from the cover letter

- Move the fix from vmx_sync_pir_to_irr() to __kvm_apic_update_irr() as suggested by Paolo along with some commit message changes. [Paolo]
- Add Cc: stable, Suggested-by, Reviewed-by tags.
- Carry Sean's cleanup patch for variable renames and expanded comments. [Sean]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: x86: Always report highest IRR from __kvm_apic_update_irr()arch/x86/kvm/lapic.c+5 -30 replies
2/2KVM: x86: Fix misleading variable names and add more comments for PIR=>IRR flowarch/x86/kvm/lapic.c arch/x86/kvm/vmx/vmx.c+40 -160 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchSean Christopherson
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] KVM: x86: Fix max_irr reporting when PIR is empty despite PID.ON

Fix a race in the PIR-to-IRR synchronization path where PID.ON is set but PIR is empty, causing __kvm_apic_update_irr() to report max_irr as -1 even though there are pending interrupts in the IRR. This triggers a spurious WARNING in vmx_check_nested_events() during nested VM stress tests.

v2:
- Move the fix from vmx_sync_pir_to_irr() to __kvm_apic_update_irr() as suggested by Paolo along with some commit message changes. [Paolo]
- Add Cc: stable, Suggested-by, Reviewed-by tags.
- Carry Sean's cleanup patch for variable renames and expanded comments. [Sean]

v1: https://lore.kernel.org/kvm/[email protected]/

Chenyi Qiang (1):
KVM: x86: Always report highest IRR from __kvm_apic_update_irr()

Sean Christopherson (1):
KVM: x86: Fix misleading variable names and add more comments for
PIR=>IRR flow

 arch/x86/kvm/lapic.c   | 24 +++++++++++++-----------
 arch/x86/kvm/vmx/vmx.c | 40 ++++++++++++++++++++++++++++++++--------
 2 files changed, 45 insertions(+), 19 deletions(-)
Signature · 1 line
2.43.5