Skip to content

Fix incorrect skips and improve cleanup

Pranay Samala igt-dev 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 0 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests/kms_hdr: Move framebuffer into data_t for centralized cleanuptests/kms_hdr.c+13 -170 replies
2/3tests/kms_hdr: Move test_fini() for proper cleanuptests/kms_hdr.c+4 -100 replies
3/3tests/kms_hdr: Move capability checks inside dynamic subteststests/kms_hdr.c+74 -940 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKarthik B S
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH i-g-t v3 0/3] Fix incorrect skips and improve cleanup

This series fixes issues where tests were being skipped incorrectly and cleanup was not always happening.

Capability checks were earlier done outside dynamic subtests, which could cause valid cases to be skipped if a later output checks fails. Move these checks inside igt_dynamic_f() to ensure each case runs independently.

Cleanup is also improved by centralizing framebuffer handling and calling test_fini() after each dynamic subtest, so resources are always released even on early exits.

Pranay Samala (3):
tests/kms_hdr: Move framebuffer into data_t for centralized cleanup tests/kms_hdr: Move test_fini() for proper cleanup tests/kms_hdr: Move capability checks inside dynamic subtests

 tests/kms_hdr.c | 212 +++++++++++++++++++++---------------------------
 1 file changed, 91 insertions(+), 121 deletions(-)
Signature · 1 line
2.34.1