RFC pcie/aspm: Enable all advertised ASPM states by default
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest4 patches 0 repliesNew
- v1 RFC4 patches 2 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | pcie/aspm: Add debug logging for aspm policy configdrivers/ | +30 | 0 replies | |
| 2/4 | pcie/aspm: Enable all power-saving states during link state initializationdrivers/ | +24 | 0 replies | |
| 3/4 | pcie/aspm: Enable all hardware power-saving states by defaultdrivers/ drivers/ include/ | +20 | 0 replies | |
| 4/4 | pcie/aspm: Remove CONFIG_PCIEASPM_* policy definitionsDocumentation/ arch/ arch/ +2 more | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC PATCH v2 0/4] pcie/aspm: Enable all advertised ASPM states by default
Hi Bjorn, Rafael, all,
This series follows up on the discussion from August 2025 about ASPM default behavior and enabling all advertised link power states by default [1].
Today, ASPM behavior is influenced first by build-time configuration (CONFIG_PCIEASPM_*), along with firmware-provided defaults. The reliance on Kconfig for policy selection and the current two-phase configuration model (initial safe setup followed by a later, more aggressive driver-triggered configuration) complicate both usage and maintenance.
The direction discussed was to move toward a model where the OS enables all supported ASPM states by default, while still respecting platform policy (FADT, _OSC), driver constraints, and user overrides.
This series is an RFC to explore that direction and gather feedback.
Specifically, it:
Enables all advertised ASPM states by default via the existing policy framework, which respects capability masks, blacklist restrictions, and user configuration.
Consolidates ASPM configuration into a single initialization step, instead of the current two-phase model (pre-driver “safe” init followed by driver-probe adjustments). This simplifies behavior and reduces maintenance complexity.
Adds detailed debug instrumentation to make ASPM configuration decisions and transitions more visible, helping to evaluate impact and identify mismatches with firmware expectations. Limits the default behavior change to newer systems using a DMI BIOS year check (>= 2025). This is intended to reduce risk on legacy platforms where firmware expectations or device behavior may not tolerate more aggressive ASPM enablement.
Removes CONFIG_PCIEASPM_* policy selections in favor of runtime policy selection, simplifying configuration and making behavior more consistent.
This RFC is not intended for immediate upstreaming, but to evaluate the feasibility and impact of this approach.
This does not address synthetic PCIe hierarchies (e.g. VMD), which may lack valid firmware policy entirely. Those cases likely require targeted handling and are left for follow-on work so that the core defaulting model can be evaluated independently.
Feedback is especially welcome on:
The DMI-based gating approach for limiting rollout risk Whether this correctly captures “enable all advertised states” The removal of Kconfig-based policy selection
The shift from a two-phase to single-phase configuration model
[1] https://lore.kernel.org/linux-pci/20250828204345.GA958461@bhelgaas/
v2: -- Removed extra whitespace
-- Fixed unbalanced brackets
-- Replaced second dmi_bios_year_check() with
pcie_aspm_legacy_config_check()
-- pcie_aspm_legacy_config_check() returns bool instead of int -- only log whether aspm is configured at build or boot time once
v1: https://lore.kernel.org/linux-pci/[email protected]/
Thomas Falcon (4):
pcie/aspm: Add debug logging for aspm policy config pcie/aspm: Enable all power-saving states during link state
initialization
pcie/aspm: Enable all hardware power-saving states by default pcie/aspm: Remove CONFIG_PCIEASPM_* policy definitions
Documentation/arch/x86/amd-debugging.rst | 5 +- arch/mips/configs/bmips_stb_defconfig | 1 - arch/mips/configs/loongson2k_defconfig | 1 - drivers/pci/pci-acpi.c | 3 + drivers/pci/pcie/Kconfig | 33 --------- drivers/pci/pcie/aspm.c | 86 +++++++++++++++++++----- include/linux/pci.h | 1 + 7 files changed, 76 insertions(+), 54 deletions(-)
Signature · 1 line
2.43.0