fix use of pthread mutex between processes
Status from this message: Applied to next-net
Get series with b4
b4 am [email protected]Versions newest first
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | eal: add helper to initialize process-shared mutexlib/ lib/ lib/ | +37 | 0 replies | |
| 2/7 | ethdev: fix flow_ops_mutex for multi-processlib/ | +1 | 0 replies | |
| 3/7 | net/failsafe: fix hotplug_mutex for multi-processdrivers/ | +12 | 0 replies | |
| 4/7 | net/atlantic: fix mbox_mutex for multi-processdrivers/ | +2 | 0 replies | |
| 5/7 | net/axgbe: fix mutexes for multi-processdrivers/ | +7 | 0 replies | |
| 6/7 | net/bnxt: fix mutexes for multi-processdrivers/ drivers/ drivers/ +2 more | +11 | 0 replies | |
| 7/7 | net/hinic: fix mutexes for multi-processdrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/7] fix use of pthread mutex between processes
Several drivers and the ethdev layer initialize pthread mutexes in shared memory with default (process-private) attributes. This is undefined behavior when secondary processes use them.
This series adds PTHREAD_PROCESS_SHARED to all affected mutexes. All are on control paths (firmware mailbox, hotplug, flow ops, PHY negotiation) where sleeping is acceptable.
See POSIX spec:
https://pubs.opengroup.org/onlinepubs/009696899/functions/pthread_mutexattr_getpshared.html
Stephen Hemminger (7):
eal: add helper to initialize process-shared mutex
ethdev: fix flow_ops_mutex for multi-process net/failsafe: fix hotplug_mutex for multi-process net/atlantic: fix mbox_mutex for multi-process net/axgbe: fix mutexes for multi-process net/bnxt: fix mutexes for multi-process net/hinic: fix mutexes for multi-process
drivers/net/atlantic/atl_ethdev.c | 3 ++- drivers/net/axgbe/axgbe_ethdev.c | 14 +++++++------- drivers/net/bnxt/bnxt_ethdev.c | 11 ++++++----- drivers/net/bnxt/bnxt_txq.c | 3 ++- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 2 +- drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c | 2 +- drivers/net/failsafe/failsafe.c | 15 ++++++++++++--- drivers/net/hinic/base/hinic_compat.h | 6 ++++-- lib/eal/include/rte_thread.h | 15 +++++++++++++++ lib/eal/unix/rte_thread.c | 12 ++++++++++++ lib/eal/windows/rte_thread.c | 10 ++++++++++ lib/ethdev/ethdev_driver.c | 2 +- 13 files changed, 74 insertions(+), 23 deletions(-)
Signature · 1 line
2.53.0