Skip to content

vhost-user.rst: clarify when rings are started

Stefan Hajnoczi qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/23 patches 1 replyIn review
  2. v3 posting 1/20 of 3 patches 0 repliesSuperseded
  3. v23 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch2 repliesSuperseded

Changes in v3 from the cover letter

- Fix sepc -> spec typo in Patch 1 [Stefano]
- Check for a -1 fd in Patch 2 [Stefano]
- Handle failure with vu_panic() instead of incorrect return -1 in Patch 2 [Stefano]
- Add eventfd_write() EINTR and EAGAIN handling in Patch 2

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vhost-user.rst: clarify when rings are starteddocs/interop/vhost-user.rst+20 -60 replies
2/3libvhost-user: look for available vq buffers upon SET_VRING_KICKsubprojects/libvhost-user/libvhost-user.c+14 -51 reply
3/3vhost-user: inject kick after SET_VRING_KICKhw/virtio/vhost-user.c+23 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchStefano Garzarella
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] vhost-user.rst: clarify when rings are started

v3:
- Fix sepc -> spec typo in Patch 1 [Stefano]
- Check for a -1 fd in Patch 2 [Stefano]
- Handle failure with vu_panic() instead of incorrect return -1 in Patch 2 [Stefano]
- Add eventfd_write() EINTR and EAGAIN handling in Patch 2

Jorge Moreira <[email protected]> pointed out that the ring state machine is underspecified. This patch series updates the spec to clarify how the ring state machine works, makes libvhost-user spec-compliant, and improves the compatibility of QEMU's vhost-user front-end.

Stefan Hajnoczi (3):
vhost-user.rst: clarify when rings are started
libvhost-user: look for available vq buffers upon SET_VRING_KICK
vhost-user: inject kick after SET_VRING_KICK

 docs/interop/vhost-user.rst               | 26 +++++++++++++++++------
 hw/virtio/vhost-user.c                    | 24 ++++++++++++++++++++-
 subprojects/libvhost-user/libvhost-user.c | 19 ++++++++++++-----
 3 files changed, 57 insertions(+), 12 deletions(-)
Signature · 1 line
2.54.0