Skip to content

tracing: Fixes for v7.1

Steven Rostedt lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tracing: branch: Fix inverted check on stat tracer registrationkernel/trace/trace_branch.c+4 -40 replies
2/3tracepoint: Fix typo in tracepoint.h commentinclude/linux/tracepoint.h+1 -10 replies
3/3tracing/probes: Limit size of event probe to 3Kkernel/trace/trace_probe.c kernel/trace/trace_probe.h+9 -10 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu (Google)
1/3A-b
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [for-linus][PATCH 0/3] tracing: Fixes for v7.1

tracing fixes for v7.1:

- Fix inverted check of registering the stats for branch tracing

When calling register_stat_tracer() which returns zero on success and negative on error, the callers were checking the return of zero as an error and printing a warning message. Because this was just a normal printk() message and not a WARN(), it wasn't caught in any testing.

Fix the check to print the warning message when an error actually happens.

- Fix a typo in a comment in tracepoint.h

- Limit the size of event probes to 3K in size

It is possible to create a dynamic event probe via the tracefs system that is greater than the max size of an event that the ring buffer can hold. This basically causes the event to become useless. Limit the size of an event probe to be 3K as that should be large enough to handle any dynamic events being created, and fits within the PAGE_SIZE sub-buffers of the ring buffer.

git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/fixes

Head SHA1: b2aa3b4d64e460ac606f386c24e7d8a873ce6f1a

Breno Leitao (1):
tracing: branch: Fix inverted check on stat tracer registration

Sheng Che Peng (1):
tracepoint: Fix typo in tracepoint.h comment

Steven Rostedt (1):
tracing/probes: Limit size of event probe to 3K

----

 include/linux/tracepoint.h  | 2 +-
 kernel/trace/trace_branch.c | 8 ++++----
 kernel/trace/trace_probe.c  | 6 ++++++
 kernel/trace/trace_probe.h  | 4 +++-
 4 files changed, 14 insertions(+), 6 deletions(-)