Skip to content

riscv: spacemit: Add K3 PCIe/USB comb phy support

Inochi Amaoto linux-devicetree linux-hardening linux-phy linux-riscv lkml sashiko-reviews spacemit 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

patch 1:
1. Add extra description for "#phy-cells" and "spacemit,apmu" patch 2:
1. Fix multiple spelling errors and copy-paste errors.
2. Make some magic number as meaningful macros.
3. Remove USB3 set_speed() callback as it is not needed.
4. Fix the wrong land data config and mask.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: phy: Add Spacemit K3 USB3/PCIe comb phy supportDocumentation/devicetree/bindings/phy/spacemit,k3-combo-phy.yaml+68 -01 reply
2/2phy: spacemit: Add USB3/PCIe comb PHY driver for Spacemit K3drivers/phy/spacemit/Kconfig drivers/phy/spacemit/Makefile drivers/phy/spacemit/phy-k3-combo.c +2 more+688 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAurelien JarnoRob Herring (Arm)
1/2R-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] riscv: spacemit: Add K3 PCIe/USB comb phy support

The PCIe/USB comb phy on K3 is a big phy that contains multiple standalone phys for each PCIe and USB controllers. This phy is required to configure a syscon device for mux configuration and calibration.

Changed from v1:
patch 1:
1. Add extra description for "#phy-cells" and "spacemit,apmu" patch 2:
1. Fix multiple spelling errors and copy-paste errors.
2. Make some magic number as meaningful macros.
3. Remove USB3 set_speed() callback as it is not needed.
4. Fix the wrong land data config and mask.

Inochi Amaoto (2):
dt-bindings: phy: Add Spacemit K3 USB3/PCIe comb phy support
phy: spacemit: Add USB3/PCIe comb PHY driver for Spacemit K3

 .../bindings/phy/spacemit,k3-combo-phy.yaml   |  68 +++
 drivers/phy/spacemit/Kconfig                  |  16 +
 drivers/phy/spacemit/Makefile                 |   2 +
 drivers/phy/spacemit/phy-k3-combo.c           | 252 +++++++++++
 drivers/phy/spacemit/phy-k3-common.c          | 391 ++++++++++++++++++
 drivers/phy/spacemit/phy-k3-common.h          |  27 ++
 6 files changed, 756 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/spacemit,k3-combo-phy.yaml
 create mode 100644 drivers/phy/spacemit/phy-k3-combo.c
 create mode 100644 drivers/phy/spacemit/phy-k3-common.c
 create mode 100644 drivers/phy/spacemit/phy-k3-common.h

--
2.55.0