net/sxe2: fix logic errors and address feedback
Status from this message: Applied to next-net with minor merge fixup to release note
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 posting 3/323 patches 1 replyIn review
- v9 posting 3/323 patches 3 repliesSuperseded
- v8 posting 3/323 patches 2 repliesSuperseded
Earlier versions · 37
Changes in v19 from the cover letter
- Fixed vector Rx burst function being overwritten by scalar selection.
- Refactored Rx/Tx mode set functions to seed flags from caps first, eliminating tautological checks.
- Added memset for mbuf_def in vector init to avoid uninitialized reads.
- Converted pci_map_addr_info to designated initializers.
- Removed dead Windows-only code in meson.build.
- Added NULL checks for mbuf free for driver-wide consistency.
- Updated burst_mode_get to accurately report AVX paths.
- Adjusted SXE2_ETH_OVERHEAD to match actual VLAN capabilities.
Patches in v19 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | mailmap: add Jie Liu.mailmap | +1 | 0 replies | |
| 2/11 | doc: add sxe2 guide and release notesdoc/ doc/ doc/ +1 more | +62 | 0 replies | |
| 3/11 | common/sxe2: add sxe2 basic structuresdrivers/ drivers/ drivers/ +1 more | +973 | 0 replies | |
| 4/11 | drivers: add base driver skeletondrivers/ drivers/ drivers/ +5 more | +1183 | 0 replies | |
| 5/11 | drivers: add base driver probe skeletondrivers/ drivers/ drivers/ +14 more | +2966 | 0 replies | |
| 6/11 | drivers: support PCI BAR mappingdrivers/ drivers/ drivers/ | +375 | 0 replies | |
| 7/11 | common/sxe2: add ioctl interface for DMA map and unmapdrivers/ drivers/ drivers/ | +162 | 0 replies | |
| 8/11 | net/sxe2: support queue setup and controldrivers/ drivers/ drivers/ +4 more | +1111 | 0 replies | |
| 9/11 | drivers: add data path for Rx and Txdrivers/ drivers/ drivers/ +3 more | +1199 | 0 replies | |
| 10/11 | net/sxe2: add vectorized Rx and Txdrivers/ drivers/ drivers/ +9 more | +1284 | 0 replies | |
| 11/11 | net/sxe2: implement Tx done cleanupdrivers/ drivers/ drivers/ | +104 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v19 yet.
Cover letter [PATCH v19 00/11]net/sxe2: fix logic errors and address feedback
From: Jie Liu <[email protected]>
This patch set addresses the feedback received on the v10 and v18 submissions for the sxe2 PMD. The primary focus is on fixing vector path selection, ensuring memory safety during mbuf initialization, and cleaning up redundant logic in the configuration functions.
v19 Changes:
- Fixed vector Rx burst function being overwritten by scalar selection.
- Refactored Rx/Tx mode set functions to seed flags from caps first, eliminating tautological checks.
- Added memset for mbuf_def in vector init to avoid uninitialized reads.
- Converted pci_map_addr_info to designated initializers.
- Removed dead Windows-only code in meson.build.
- Added NULL checks for mbuf free for driver-wide consistency.
- Updated burst_mode_get to accurately report AVX paths.
- Adjusted SXE2_ETH_OVERHEAD to match actual VLAN capabilities.
Jie Liu (11):
mailmap: add Jie Liu
doc: add sxe2 guide and release notes common/sxe2: add sxe2 basic structures
drivers: add base driver skeleton
drivers: add base driver probe skeleton
drivers: support PCI BAR mapping
common/sxe2: add ioctl interface for DMA map and unmap net/sxe2: support queue setup and control
drivers: add data path for Rx and Tx net/sxe2: add vectorized Rx and Tx
net/sxe2: implement Tx done cleanup
.mailmap | 1 + doc/guides/nics/features/sxe2.ini | 23 + doc/guides/nics/index.rst | 1 + doc/guides/nics/sxe2.rst | 34 + doc/guides/rel_notes/release_26_07.rst | 4 + drivers/common/sxe2/meson.build | 15 + drivers/common/sxe2/sxe2_common.c | 683 +++++++++++++ drivers/common/sxe2/sxe2_common.h | 85 ++ drivers/common/sxe2/sxe2_common_log.h | 81 ++ drivers/common/sxe2/sxe2_host_regs.h | 707 +++++++++++++ drivers/common/sxe2/sxe2_internal_ver.h | 33 + drivers/common/sxe2/sxe2_ioctl_chnl.c | 325 ++++++ drivers/common/sxe2/sxe2_ioctl_chnl.h | 130 +++ drivers/common/sxe2/sxe2_ioctl_chnl_func.h | 62 ++ drivers/common/sxe2/sxe2_osal.h | 153 +++ drivers/meson.build | 1 + drivers/net/meson.build | 1 + drivers/net/sxe2/meson.build | 32 + drivers/net/sxe2/sxe2_cmd_chnl.c | 323 ++++++ drivers/net/sxe2/sxe2_cmd_chnl.h | 37 + drivers/net/sxe2/sxe2_drv_cmd.h | 388 ++++++++ drivers/net/sxe2/sxe2_ethdev.c | 968 ++++++++++++++++++ drivers/net/sxe2/sxe2_ethdev.h | 318 ++++++ drivers/net/sxe2/sxe2_irq.h | 48 + drivers/net/sxe2/sxe2_queue.c | 66 ++ drivers/net/sxe2/sxe2_queue.h | 195 ++++ drivers/net/sxe2/sxe2_rx.c | 554 +++++++++++ drivers/net/sxe2/sxe2_rx.h | 32 + drivers/net/sxe2/sxe2_tx.c | 420 ++++++++ drivers/net/sxe2/sxe2_tx.h | 32 + drivers/net/sxe2/sxe2_txrx.c | 352 +++++++ drivers/net/sxe2/sxe2_txrx.h | 23 + drivers/net/sxe2/sxe2_txrx_common.h | 540 ++++++++++ drivers/net/sxe2/sxe2_txrx_poll.c | 1044 ++++++++++++++++++++ drivers/net/sxe2/sxe2_txrx_poll.h | 20 + drivers/net/sxe2/sxe2_txrx_vec.c | 201 ++++ drivers/net/sxe2/sxe2_txrx_vec.h | 63 ++ drivers/net/sxe2/sxe2_txrx_vec_common.h | 235 +++++ drivers/net/sxe2/sxe2_txrx_vec_sse.c | 549 ++++++++++ drivers/net/sxe2/sxe2_vsi.c | 214 ++++ drivers/net/sxe2/sxe2_vsi.h | 204 ++++ 41 files changed, 9197 insertions(+) create mode 100644 doc/guides/nics/features/sxe2.ini create mode 100644 doc/guides/nics/sxe2.rst create mode 100644 drivers/common/sxe2/meson.build create mode 100644 drivers/common/sxe2/sxe2_common.c create mode 100644 drivers/common/sxe2/sxe2_common.h create mode 100644 drivers/common/sxe2/sxe2_common_log.h create mode 100644 drivers/common/sxe2/sxe2_host_regs.h create mode 100644 drivers/common/sxe2/sxe2_internal_ver.h create mode 100644 drivers/common/sxe2/sxe2_ioctl_chnl.c create mode 100644 drivers/common/sxe2/sxe2_ioctl_chnl.h create mode 100644 drivers/common/sxe2/sxe2_ioctl_chnl_func.h create mode 100644 drivers/common/sxe2/sxe2_osal.h create mode 100644 drivers/net/sxe2/meson.build create mode 100644 drivers/net/sxe2/sxe2_cmd_chnl.c create mode 100644 drivers/net/sxe2/sxe2_cmd_chnl.h create mode 100644 drivers/net/sxe2/sxe2_drv_cmd.h create mode 100644 drivers/net/sxe2/sxe2_ethdev.c create mode 100644 drivers/net/sxe2/sxe2_ethdev.h create mode 100644 drivers/net/sxe2/sxe2_irq.h create mode 100644 drivers/net/sxe2/sxe2_queue.c create mode 100644 drivers/net/sxe2/sxe2_queue.h create mode 100644 drivers/net/sxe2/sxe2_rx.c create mode 100644 drivers/net/sxe2/sxe2_rx.h create mode 100644 drivers/net/sxe2/sxe2_tx.c create mode 100644 drivers/net/sxe2/sxe2_tx.h create mode 100644 drivers/net/sxe2/sxe2_txrx.c create mode 100644 drivers/net/sxe2/sxe2_txrx.h create mode 100644 drivers/net/sxe2/sxe2_txrx_common.h create mode 100644 drivers/net/sxe2/sxe2_txrx_poll.c create mode 100644 drivers/net/sxe2/sxe2_txrx_poll.h create mode 100644 drivers/net/sxe2/sxe2_txrx_vec.c create mode 100644 drivers/net/sxe2/sxe2_txrx_vec.h create mode 100644 drivers/net/sxe2/sxe2_txrx_vec_common.h create mode 100644 drivers/net/sxe2/sxe2_txrx_vec_sse.c create mode 100644 drivers/net/sxe2/sxe2_vsi.c create mode 100644 drivers/net/sxe2/sxe2_vsi.h
Signature · 1 line
2.47.3