Intel Xe GPU Debug Support (eudebug) v8
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest24 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | drm/xe/eudebug: Introduce eudebug interfacedrivers/ drivers/ drivers/ +7 more | +1400 | 0 replies | |
| 2/24 | drm/xe/eudebug: Add documentationDocumentation/ Documentation/ drivers/ | +87 | 0 replies | |
| 3/24 | drm/xe/eudebug: Add connection establishment documentationDocumentation/ drivers/ | +81 | 0 replies | |
| 4/24 | drm/xe/eudebug: Introduce discovery for resourcesdrivers/ drivers/ drivers/ +2 more | +166 | 0 replies | |
| 5/24 | drm/xe/eudebug: Introduce exec_queue eventsDocumentation/ drivers/ drivers/ +4 more | +273 | 0 replies | |
| 6/24 | drm/xe: Add EUDEBUG_ENABLE exec queue propertydrivers/ drivers/ drivers/ +3 more | +68 | 0 replies | |
| 7/24 | drm/xe/eudebug: Mark guc contexts as debuggabledrivers/ drivers/ drivers/ +6 more | +85 | 0 replies | |
| 8/24 | drm/xe: Introduce ADD_DEBUG_DATA and REMOVE_DEBUG_DATA vm bind opsdrivers/ drivers/ drivers/ +4 more | +596 | 0 replies | |
| 9/24 | drm/xe/eudebug: Introduce vm bind and vm bind debug data eventsDocumentation/ drivers/ drivers/ +3 more | +325 | 0 replies | |
| 10/24 | drm/xe/eudebug: Add ufence events with acksDocumentation/ drivers/ drivers/ +5 more | +444 | 0 replies | |
| 11/24 | drm/xe/eudebug: vm open/pread/pwriteDocumentation/ drivers/ drivers/ +6 more | +543 | 0 replies | |
| 12/24 | drm/xe/eudebug: userptr vm pread/pwritedrivers/ drivers/ drivers/ | +52 | 0 replies | |
| 13/24 | drm/xe/eudebug: hw enablement for eudebugdrivers/ drivers/ drivers/ +10 more | +357 | 0 replies | |
| 14/24 | drm/xe/eudebug: Introduce EU control interfaceDocumentation/ drivers/ drivers/ +5 more | +791 | 0 replies | |
| 15/24 | drm/xe/eudebug: Introduce per device attention scan workerDocumentation/ drivers/ drivers/ +2 more | +208 | 0 replies | |
| 16/24 | drm/xe/eudebug_test: Introduce xe_eudebug wa kunit testdrivers/ drivers/ drivers/ | +192 | 1 reply | |
| 17/24 | drm/xe: Implement SR-IOV and eudebug exclusivitydrivers/ drivers/ | +31 | 0 replies | |
| 18/24 | drm/xe: Add xe_client_debugfs and introduce debug_data filedrivers/ drivers/ drivers/ +1 more | +142 | 0 replies | |
| 19/24 | drm/xe/eudebug: Allow getting eudebug instance during discoverydrivers/ drivers/ | +33 | 0 replies | |
| 20/24 | drm/xe/eudebug: Add read/count/compare helper for eu attentiondrivers/ drivers/ drivers/ | +93 | 0 replies | |
| 21/24 | drm/xe/vm: Support for adding null page VMA to VM on requestdrivers/ drivers/ | +36 | 0 replies | |
| 22/24 | drm/xe/eudebug: Introduce EU pagefault handling interfacedrivers/ drivers/ drivers/ +7 more | +658 | 1 reply | |
| 23/24 | drm/xe/eudebug: Enable EU pagefault handlingdrivers/ drivers/ drivers/ +3 more | +113 | 0 replies | |
| 24/24 | drm/xe/eudebug: Disable SVM in Xe for Eudebugdrivers/ | +5 | 1 reply |
Reviews trailers per patch
2 of 24 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Brost | Daniele Ceraolo Spurio |
|---|---|---|
| 1/24 | ||
| 2/24 | ||
| 3/24 | ||
| 4/24 | A-b | |
| 5/24 | ||
| 6/24 | ||
| 7/24 | R-b | |
| 8/24 | ||
| 9/24 | ||
| 10/24 | ||
| 11/24 | ||
| 12/24 | ||
| 13/24 | ||
| 14/24 | ||
| 15/24 | ||
| 16/24 | ||
| 17/24 | ||
| 18/24 | ||
| 19/24 | ||
| 20/24 | ||
| 21/24 | ||
| 22/24 | ||
| 23/24 | ||
| 24/24 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/24] Intel Xe GPU Debug Support (eudebug) v8
Hi,
This is the v8 patch series for Intel Xe GPU debug support (eudebug).
This series continues from the following previous submissions:
- v1: https://lists.freedesktop.org/archives/intel-xe/2024-July/043605.html
- v2: https://lists.freedesktop.org/archives/intel-xe/2024-October/052260.html
- v3: https://lists.freedesktop.org/archives/intel-xe/2024-December/061476.html
- v4: https://lists.freedesktop.org/archives/intel-xe/2025-August/091645.html
- v5: https://lists.freedesktop.org/archives/intel-xe/2025-October/097859.html
- v6: https://lists.freedesktop.org/archives/intel-xe/2025-December/106405.html
- v7: https://lists.freedesktop.org/archives/intel-xe/2026-February/115750.html
# Major Changes from v7
Rework of eudebug pagefault handling to better align with xe core pagefaults (Maciej Patelczyk).
Refactored eu control to streamline common parts. Refactored resource handle bookkeepping.
# Major Changes from v6
Added documentation. Two new documentation patches introduce .rst documentation under Documentation/gpu/xe/ and kernel-doc for the eudebug interface. The eudebug source now includes DOC sections covering connection establishment, security model, file descriptor acquisition methods, and the event interface.
UAPI header documentation in xe_drm_eudebug.h has been significantly expanded with kernel-doc comments for interface structures and ioctls.
Eliminated the separate xe_eudebug_resources struct, removing a level of indirection. The resources lock has been consolidated with the target lock, which is now a mutex instead of a spinlock.
Improved input validation: seqno fields are now checked to be zero on EU control and read_event entry. The read_event ioctl validation was simplified to only check for DRM_XE_EUDEBUG_EVENT_READ type.
Replaced drm_file->authenticated check with xe_file and device validation, allowing render node access for debug targets.
# Major Changes from v5
With v5, when relaying vm bind with the associated ops, the transient bind relay state was held in struct xe_vm. As debug metadata add and remove ops simplifies the way binds are handled wrt v3, this gave us opportunity to use vm_ops for relaying instead of using eudebug baked bind ops state. This change removes ~200 lines.
Debuggable GuC context support was reworked. Now GuC version is required to be 70.49.4 or higher for eudebug support.
Eudebug pagefaults were reworked on top of producer/consumer pagefaults, introduced in core xe side. We reduced the footprint eudebug pagefaults have in xe pagefault handler side.
# Major Changes from v4
v4 omitted page fault support, it is reworked from v3 and included in this series.
### Major Changes from v3
#### 1. Elimination of ptrace_may_access() and pid
In previous series, the connection attempt was made using the process ID (PID) as the target. Access was checked using the ptrace_may_access() helper to achieve security parity with CPU-side debugging.
In v4, this has been changed to connect to a DRM client, using a file descriptor as the target. This approach eliminates the need for the ptrace_may_access() symbol export, as access control is now managed through the debugger process's access to the file descriptor. For example, accessing a remote DRM client requires the debugger process to successfully call pidfd_getfd() to obtain a duplicate of the target file descriptor. The 1:1 mapping between DRM clients and their debuggers eliminates the need for EVENT_OPEN and simplifies overall connection tracking.
#### 2. ELF binaries not held in kernel memory
In v4, debug data is delivered as a VM bind 'OP_ADD_DEBUG_DATA' extension. The ELF binaries are no longer stored within the Xe KMD but are instead kept in a file. The file path is passed as part of an extension in the newly introduced 'OP_ADD_DEBUG_DATA' VM bind operation. Alternatively pseudo-paths can be used to annotate special address ranges similar to /proc/<pid>/maps.
#### 3. Debug metadata not carried in VMA struct
Instead of attaching debug data to vma created by 'OP_MAP', we introduce separate ops for managing the metadata. Debug data is no longer held in the VMA struct. xe_vm contains a list of all associated debug data.
#### 4. Reading debug data via debugfs
This revision introduces the possibility to access debug data using per client debugfs entries. The intent was to achieve similar interface to '/proc/<pid>/maps'
### Supported Hardware
- Lunarlake (LNL)
- Battlemage (BMG)
- Pantherlake (PTL)
The code for this submission can be found at:
https://gitlab.freedesktop.org/miku/kernel/-/tree/eudebug-v8
Tests:
https://gitlab.freedesktop.org/DominikPiatkowski-Intel/igt-gpu-tools/-/tree/eudebug-dev-next
Christoph Manszewski (5):
drm/xe: Introduce ADD_DEBUG_DATA and REMOVE_DEBUG_DATA vm bind ops drm/xe/eudebug: Introduce vm bind and vm bind debug data events drm/xe/eudebug_test: Introduce xe_eudebug wa kunit test drm/xe: Implement SR-IOV and eudebug exclusivity drm/xe: Add xe_client_debugfs and introduce debug_data file
Dominik Grzegorzek (5):
drm/xe/eudebug: Introduce exec_queue events drm/xe: Add EUDEBUG_ENABLE exec queue property drm/xe/eudebug: hw enablement for eudebug drm/xe/eudebug: Introduce EU control interface drm/xe/eudebug: Introduce per device attention scan worker
Gwan-gyeong Mun (4):
drm/xe/eudebug: Add read/count/compare helper for eu attention drm/xe/vm: Support for adding null page VMA to VM on request drm/xe/eudebug: Introduce EU pagefault handling interface drm/xe/eudebug: Enable EU pagefault handling
Maciej Patelczyk (2):
drm/xe/eudebug: Allow getting eudebug instance during discovery drm/xe/eudebug: Disable SVM in Xe for Eudebug
Mika Kuoppala (8):
drm/xe/eudebug: Introduce eudebug interface drm/xe/eudebug: Add documentation drm/xe/eudebug: Add connection establishment documentation drm/xe/eudebug: Introduce discovery for resources drm/xe/eudebug: Mark guc contexts as debuggable drm/xe/eudebug: Add ufence events with acks drm/xe/eudebug: vm open/pread/pwrite drm/xe/eudebug: userptr vm pread/pwrite
Documentation/gpu/xe/index.rst | 1 + Documentation/gpu/xe/xe_eudebug.rst | 83 + drivers/gpu/drm/xe/Kconfig | 16 +- drivers/gpu/drm/xe/Makefile | 7 +- drivers/gpu/drm/xe/abi/guc_actions_abi.h | 5 + drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 1 + drivers/gpu/drm/xe/regs/xe_engine_regs.h | 5 + drivers/gpu/drm/xe/regs/xe_gt_regs.h | 43 + drivers/gpu/drm/xe/tests/xe_eudebug.c | 193 ++ drivers/gpu/drm/xe/tests/xe_live_test_mod.c | 5 + drivers/gpu/drm/xe/xe_client_debugfs.c | 118 + drivers/gpu/drm/xe/xe_client_debugfs.h | 19 + drivers/gpu/drm/xe/xe_debug_data.c | 314 +++ drivers/gpu/drm/xe/xe_debug_data.h | 22 + drivers/gpu/drm/xe/xe_debug_data_types.h | 25 + drivers/gpu/drm/xe/xe_device.c | 30 +- drivers/gpu/drm/xe/xe_device.h | 42 + drivers/gpu/drm/xe/xe_device_types.h | 49 + drivers/gpu/drm/xe/xe_eudebug.c | 2360 +++++++++++++++++++ drivers/gpu/drm/xe/xe_eudebug.h | 112 + drivers/gpu/drm/xe/xe_eudebug_hw.c | 725 ++++++ drivers/gpu/drm/xe/xe_eudebug_hw.h | 32 + drivers/gpu/drm/xe/xe_eudebug_pagefault.c | 417 ++++ drivers/gpu/drm/xe/xe_eudebug_pagefault.h | 77 + drivers/gpu/drm/xe/xe_eudebug_types.h | 228 ++ drivers/gpu/drm/xe/xe_eudebug_vm.c | 436 ++++ drivers/gpu/drm/xe/xe_eudebug_vm.h | 8 + drivers/gpu/drm/xe/xe_exec_queue.c | 56 +- drivers/gpu/drm/xe/xe_exec_queue.h | 2 + drivers/gpu/drm/xe/xe_exec_queue_types.h | 7 + drivers/gpu/drm/xe/xe_gt_debug.c | 242 ++ drivers/gpu/drm/xe/xe_gt_debug.h | 39 + drivers/gpu/drm/xe/xe_gt_debug_types.h | 22 + drivers/gpu/drm/xe/xe_guc.c | 17 + drivers/gpu/drm/xe/xe_guc.h | 3 + drivers/gpu/drm/xe/xe_guc_ads.c | 17 + drivers/gpu/drm/xe/xe_guc_pagefault.c | 10 +- drivers/gpu/drm/xe/xe_guc_submit.c | 34 + drivers/gpu/drm/xe/xe_guc_submit.h | 1 + drivers/gpu/drm/xe/xe_hw_engine.h | 14 + drivers/gpu/drm/xe/xe_lrc.c | 10 + drivers/gpu/drm/xe/xe_pagefault.c | 77 +- drivers/gpu/drm/xe/xe_pagefault_types.h | 10 + drivers/gpu/drm/xe/xe_reg_sr.c | 21 +- drivers/gpu/drm/xe/xe_reg_sr.h | 4 +- drivers/gpu/drm/xe/xe_reg_whitelist.c | 2 +- drivers/gpu/drm/xe/xe_rtp.c | 2 +- drivers/gpu/drm/xe/xe_sync.c | 43 +- drivers/gpu/drm/xe/xe_sync.h | 7 +- drivers/gpu/drm/xe/xe_sync_types.h | 28 +- drivers/gpu/drm/xe/xe_userptr.c | 4 + drivers/gpu/drm/xe/xe_userptr.h | 32 + drivers/gpu/drm/xe/xe_vm.c | 201 +- drivers/gpu/drm/xe/xe_vm.h | 3 + drivers/gpu/drm/xe/xe_vm_types.h | 19 + drivers/gpu/drm/xe/xe_wa_oob.rules | 5 +- include/uapi/drm/xe_drm.h | 95 + include/uapi/drm/xe_drm_eudebug.h | 377 +++ 58 files changed, 6722 insertions(+), 55 deletions(-) create mode 100644 Documentation/gpu/xe/xe_eudebug.rst create mode 100644 drivers/gpu/drm/xe/tests/xe_eudebug.c create mode 100644 drivers/gpu/drm/xe/xe_client_debugfs.c create mode 100644 drivers/gpu/drm/xe/xe_client_debugfs.h create mode 100644 drivers/gpu/drm/xe/xe_debug_data.c create mode 100644 drivers/gpu/drm/xe/xe_debug_data.h create mode 100644 drivers/gpu/drm/xe/xe_debug_data_types.h create mode 100644 drivers/gpu/drm/xe/xe_eudebug.c create mode 100644 drivers/gpu/drm/xe/xe_eudebug.h create mode 100644 drivers/gpu/drm/xe/xe_eudebug_hw.c create mode 100644 drivers/gpu/drm/xe/xe_eudebug_hw.h create mode 100644 drivers/gpu/drm/xe/xe_eudebug_pagefault.c create mode 100644 drivers/gpu/drm/xe/xe_eudebug_pagefault.h create mode 100644 drivers/gpu/drm/xe/xe_eudebug_types.h create mode 100644 drivers/gpu/drm/xe/xe_eudebug_vm.c create mode 100644 drivers/gpu/drm/xe/xe_eudebug_vm.h create mode 100644 drivers/gpu/drm/xe/xe_gt_debug.c create mode 100644 drivers/gpu/drm/xe/xe_gt_debug.h create mode 100644 drivers/gpu/drm/xe/xe_gt_debug_types.h create mode 100644 include/uapi/drm/xe_drm_eudebug.h
Signature · 1 line
2.43.0