Skip to content

Fixes for mkfs.xfs with high amount of CPUs and SSDs

Lukas Herbolt fstests linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v14 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4common/rc: Add helper to calculate percentage of free space availablecommon/rc+10 -02 replies
2/4common/xfs: helper function to check if -l/-d/-r concurrecy flags.common/xfs+9 -02 replies
3/4generic/{102,172,347}: Adapt test for XFS on systems with 128+CPUs + SSDstests/generic/102 tests/generic/102.out tests/generic/172 +1 more+25 -172 replies
4/4xfs/21{6,7} Use default -l concurrency=0 on mkfs.xfs that supports ittests/xfs/216 tests/xfs/217+11 -22 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongZorro Lang
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Fixes for mkfs.xfs with high amount of CPUs and SSDs

Since xfsprogs v6.13.0 mkfs.xfs scales the log size on SSDs with the amount of CPUs. This leads to various failures from ENOSPC in generic/102 and generic/172 (the xfs log can take up to 256MB on 1GB test FS) or depleting the dmthin metadata area in generic/347. Downsize of the percentage change is we cannot longer check the exact amount of data xfs_io wrote in the generic/102 test.

The xfs/21{6,7} are testing the old behavior before the concurrency option was introduced. Forcing the old behavior on newer mkfs.xfs.

Lukas Herbolt (4):
common/rc: Add helper to calculate percentage of free space available common/xfs: helper function to check if -l/-d/-r concurrency flags. generic/{102,172,347}: Adapt test for XFS on systems with 128+CPUs +
SSDs
xfs/21{6,7} Use default -l concurrency=0 on mkfs.xfs that supports it

 common/rc             | 10 ++++++++++
 common/xfs            |  9 +++++++++
 tests/generic/102     |  5 +++--
 tests/generic/102.out | 20 ++++++++++----------
 tests/generic/172     |  8 ++++----
 tests/generic/347     |  9 ++++++++-
 tests/xfs/216         |  6 +++++-
 tests/xfs/217         |  7 ++++++-
 8 files changed, 55 insertions(+), 19 deletions(-)
Signature · 1 line
2.54.0