Skip to content

selftests/cgroup: Fix false positive failures in test_percpu_basic

Li Wang cgroups linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] selftests-cgroup-include-slab-in-test_percpu_basic-memory-check.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyApplied 2/2

Changes in v2 from the cover letter

* Replace my email with [email protected]
* Adding Waiman's Reviewed-by tag

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests/cgroup: Fix hardcoded page size in test_percpu_basictools/testing/selftests/cgroup/test_kmem.c+1 -11 replyApplied
2/2selftests/cgroup: include slab in test_percpu_basic memory checktools/testing/selftests/cgroup/test_kmem.c+6 -50 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchWaiman LongSayali Patil
1/2A-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] selftests/cgroup: Fix false positive failures in test_percpu_basic

This patch series addresses two separate issues that cause false positive failures in the test_percpu_basic test within the cgroup kmem selftests.

The first issue stems from a hardcoded assumption about the system page size, which breaks the test on architectures with larger page sizes.

The second issue is an overly strict memory check that fails to account for the slab metadata allocated during cgroup creation.

v2:
* Replace my email with [email protected]
* Adding Waiman's Reviewed-by tag

Li Wang (2):
selftests/cgroup: Fix hardcoded page size in test_percpu_basic selftests/cgroup: include slab in test_percpu_basic memory check

 tools/testing/selftests/cgroup/test_kmem.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Signature · 1 line
2.54.0