Skip to content

liveupdate: validate restored LUO metadata

Cris Jacob Maamor kexec linux-mm lkml 2 versions NAK

Status from this message: NAK

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesNAK
  2. v1 RFC5 patches 1 replySuperseded

Changes in v2 from the cover letter

- Dropped RFC marking.
- Added changelog text to each patch.
- No code changes.

Patches in v2

#Subject and filesSizeRepliesApplied
1/5kexec: handover: add helper to check preserved page rangesinclude/linux/kexec_handover.h kernel/liveupdate/kexec_handover.c+41 -00 replies
2/5liveupdate: validate LUO FDT physical address before mappingkernel/liveupdate/luo_core.c+9 -10 replies
3/5liveupdate: validate restored LUO session metadatakernel/liveupdate/luo_session.c+20 -20 replies
4/5liveupdate: validate restored LUO file set metadatakernel/liveupdate/luo_file.c+12 -20 replies
5/5liveupdate: validate restored LUO FLB metadatakernel/liveupdate/luo_flb.c+22 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] liveupdate: validate restored LUO metadata

LUO restores metadata from KHO/FDT during liveupdate. The restored metadata contains physical addresses and count fields used to access and walk preserved session, file set, and FLB arrays.

This series adds a non-consuming KHO preserved-range check and uses it before phys_to_virt() on restored metadata addresses. It also rejects restored counts above LUO_SESSION_MAX, LUO_FILE_MAX, and LUO_FLB_MAX before traversal.

As far as I can tell, this is root/admin-only; I do not have evidence that a normal unprivileged user can trigger it directly.

Changes since v1:
- Dropped RFC marking.
- Added changelog text to each patch.
- No code changes.

Cris Jacob Maamor (5):
kexec: handover: add helper to check preserved page ranges
liveupdate: validate LUO FDT physical address before mapping
liveupdate: validate restored LUO session metadata
liveupdate: validate restored LUO file set metadata
liveupdate: validate restored LUO FLB metadata

 include/linux/kexec_handover.h     |  6 +++++
 kernel/liveupdate/kexec_handover.c | 35 ++++++++++++++++++++++++++++++
 kernel/liveupdate/luo_core.c       | 10 ++++++++-
 kernel/liveupdate/luo_file.c       | 14 ++++++++++--
 kernel/liveupdate/luo_flb.c        | 23 +++++++++++++++++++-
 kernel/liveupdate/luo_session.c    | 22 +++++++++++++++++--
 6 files changed, 104 insertions(+), 6 deletions(-)
Signature · 1 line
2.53.0