kvm/arm: Introduce a customizable aarch64 KVM host model
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest26 patches 9 repliesIn review
- v926 patches 55 repliesSuperseded
- v8 RFC20 patches 3 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 RFC | 18 patches | 36 replies | Superseded | |
| v6 RFC | 17 patches | 12 replies | Superseded | |
| v5 | 18 patches | 57 replies | Superseded | |
| v4 | 17 patches | 25 replies | Superseded |
Changes in v10 from the cover letter
addressed all Khushit's comments/suggestions. Here is the list of main changes.
- MIDR, REVIDIR, MPIDR storage move (this may be sent as a separate prerequisite series)
- rebase on demux register handler that has just landed
- update the json extractor accordingly
- Generate conditional enum values
- reorganize script patches to have the generated header in the same patch which is much easier to maintain
- New macro to encode arch enum value and ValueRanges which gives a much more compact header. Also enabled to remove check-patch error
- Put a maximum of code in cpu64.c instead of kvm.c to pave the way for other acceleration support. Also changed the consistency check handling by skipping potential new props that are known to collide with legacy composite options
- add writable_only param to pave the way for exposing all fields as props
- fixes in the qmp expansion code
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | target/arm: Move REVIDR into isar.idregs[] storagehw/ target/ target/ +6 more | +19 | 1 reply | |
| 2/26 | target/arm: Move MIDR into isar.idregs[] storagehw/ target/ target/ +9 more | +51 | 1 reply | |
| 3/26 | target/arm: Enforce MPIDR into isar.idregs[] storagetarget/ target/ target/ +4 more | +29 | 1 reply | |
| 4/26 | target/arm/cpu-sysregs.h.inc: Update with automatic generationscripts/ scripts/ target/ | +187 | 0 replies | |
| 5/26 | arm/cpu: Add infra to handle generated ID register definitionstarget/ | +41 | 0 replies | |
| 6/26 | target/arm/cpu-idregs.h.inc: Generate with scriptscripts/ target/ | +782 | 0 replies | |
| 7/26 | target/arm/cpu-idregs.h.inc: Generate enum valuesscripts/ target/ | +1395 | 0 replies | |
| 8/26 | target/arm/cpu-idregs.h.inc: Generate reserved fieldsscripts/ target/ | +134 | 0 replies | |
| 9/26 | target/arm/cpu_idregs: Generate tables for Arm64 ID registers and fieldstarget/ target/ | +94 | 0 replies | |
| 10/26 | target/arm/kvm: Retrieve writable ID reg maptarget/ | +55 | 0 replies | |
| 11/26 | hw/arm/virt: Make sure virt_get_caches() keeps on reading CLIDR_EL1 as 0hw/ | +11 | 0 replies | |
| 12/26 | arm/kvm: Initialize isar.idregs[] with all writable host ID regstarget/ target/ | +44 | 1 reply | |
| 13/26 | target/arm/cpu64: Add properties for writable IDReg fieldstarget/ target/ | +119 | 1 reply | |
| 14/26 | target/arm/kvm: Implement SYSREG property setter and gettertarget/ target/ target/ | +68 | 0 replies | |
| 15/26 | target/arm/kvm: Let kvm_arm_init_cpreg_list propagate an error handletarget/ | +11 | 0 replies | |
| 16/26 | target/arm/kvm: Pass an Error handle to kvm_arch_init_vcpuaccel/ include/ target/ +5 more | +44 | 0 replies | |
| 17/26 | target/arm/kvm: Introduce kvm_arm_override_idreg_field helpertarget/ target/ | +48 | 0 replies | |
| 18/26 | target/arm/cpu64: Introduce arm_cpu_apply_sysreg_propstarget/ target/ | +75 | 0 replies | |
| 19/26 | target/arm/kvm: Apply SYSREG propstarget/ target/ | +24 | 0 replies | |
| 20/26 | target/arm/kvm: Add consistency checking for SYSREG propstarget/ target/ | +111 | 0 replies | |
| 21/26 | target/arm/cpu64: Add helper to test SYSREG props against a scratch vcputarget/ target/ target/ +1 more | +33 | 0 replies | |
| 22/26 | target/arm/kvm: Add an error handle to kvm_arm_create_scratch_host_vcputarget/ target/ | +14 | 0 replies | |
| 23/26 | target/arm/kvm: Introduce kvm_arm_vcpu_prepare_init_features helpertarget/ | +22 | 0 replies | |
| 24/26 | target/arm/kvm: Introduce kvm_arm_create_init_scratch_vcpu()target/ target/ target/ | +41 | 0 replies | |
| 25/26 | arm-qmp-cmds: introspection for ID register propstarget/ | +118 | 0 replies | |
| 26/26 | arm/cpu-features: Document ID reg propertiesdocs/ | +102 | 0 replies |
Reviews trailers per patch
5 of 26 patches have a Reviewed-by or Acked-by.
| Patch | Khushit Shah | Peter Maydell |
|---|---|---|
| 1/26 | R-b | |
| 2/26 | R-b | |
| 3/26 | R-b | |
| 4/26 | ||
| 5/26 | Co-authored-by | |
| 6/26 | ||
| 7/26 | ||
| 8/26 | ||
| 9/26 | Co-authored-by | |
| 10/26 | ||
| 11/26 | R-b | |
| 12/26 | ||
| 13/26 | ||
| 14/26 | R-b | |
| 15/26 | ||
| 16/26 | ||
| 17/26 | ||
| 18/26 | ||
| 19/26 | ||
| 20/26 | ||
| 21/26 | ||
| 22/26 | ||
| 23/26 | ||
| 24/26 | ||
| 25/26 | ||
| 26/26 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 00/26] kvm/arm: Introduce a customizable aarch64 KVM host model
This series enhances the current host KVM model with capability to set writable ID reg fields.
Since v6.7 kernel, KVM/arm allows the userspace to overwrite the values of a subset of ID regs. The list of writable fields continues to grow. The feature ID range is defined as the AArch64 System register space with op0==3, op1=={0, 1, 3}, CRn==0, CRm=={0-7}, op2=={0-7}.
The end goal is to get more flexibility when migrating guests between different host hardware. This series is a prerequisite for aarch64 named vcpu models.
QEMU retrieves the writable ID fields from KVM UAPI and match them against a generated description of ID regs and their named fields that stem from AARCHMRS Registers.json file. Current description is based on latest 2026-03 edition. The content of the generated files was compared against kernel linux/arch/arm64/tools/sysreg file. It is not straightforward to have unit tests for python scripts as there are many cases for field extraction.
For each writable named field a uint64 property is created following the "SYSREG_<REG>_<FIELD>" naming convention. REG and FIELD names are those described in ARM ARM Reference manual.
SYSREG properties are applied at the end of the initialization chain, after legacy composite options (sve, pauth, ...). They do not substitute to them because legacy options do more than just changing the value of ID registers. They may also interact with KVM to init the vcpu with specific features or set some VM capabilities. SYSREG properties just affect the corresponding ID register field. Some checks are performed to make sure their value is not inconsistent with legacy composite options.
The list of SYSREG properties can be retrieved through the qmp monitor using query-cpu-model-expansion. They return the current value for the corresponding field. The qmp command also allows to test setting new values. In static mode, they are tested at qemu level only, against field length, arch enum values if any and consistency with legacy composite options. With full expansion, the values are tested against KVM using a scratch vcpu initialized with the right legacy composite property values.
Connie & Eric
This series can be found at:
https://github.com/eauger/qemu/tree/arm-cpu-model-v10
History:
--------
v9 -> v10:
addressed all Khushit's comments/suggestions. Here is the list of main changes.
- MIDR, REVIDIR, MPIDR storage move (this may be sent as a separate prerequisite series)
- rebase on demux register handler that has just landed
- update the json extractor accordingly
- Generate conditional enum values
- reorganize script patches to have the generated header in the same patch which is much easier to maintain
- New macro to encode arch enum value and ValueRanges which gives a much more compact header. Also enabled to remove check-patch error
- Put a maximum of code in cpu64.c instead of kvm.c to pave the way for other acceleration support. Also changed the consistency check handling by skipping potential new props that are known to collide with legacy composite options
- add writable_only param to pave the way for exposing all fields as props
- fixes in the qmp expansion code
Cornelia Huck (3):
target/arm/kvm: Retrieve writable ID reg map
arm-qmp-cmds: introspection for ID register props arm/cpu-features: Document ID reg properties
Eric Auger (22):
target/arm: Move REVIDR into isar.idregs[] storage target/arm: Move MIDR into isar.idregs[] storage target/arm: Enforce MPIDR into isar.idregs[] storage target/arm/cpu-sysregs.h.inc: Update with automatic generation arm/cpu: Add infra to handle generated ID register definitions target/arm/cpu-idregs.h.inc: Generate with script target/arm/cpu-idregs.h.inc: Generate enum values target/arm/cpu-idregs.h.inc: Generate reserved fields hw/arm/virt: Make sure virt_get_caches() keeps on reading CLIDR_EL1 as
0
arm/kvm: Initialize isar.idregs[] with all writable host ID regs target/arm/cpu64: Add properties for writable IDReg fields target/arm/kvm: Implement SYSREG property setter and getter target/arm/kvm: Let kvm_arm_init_cpreg_list propagate an error handle target/arm/kvm: Pass an Error handle to kvm_arch_init_vcpu target/arm/kvm: Introduce kvm_arm_override_idreg_field helper target/arm/cpu64: Introduce arm_cpu_apply_sysreg_props target/arm/kvm: Apply SYSREG props
target/arm/kvm: Add consistency checking for SYSREG props target/arm/cpu64: Add helper to test SYSREG props against a scratch
vcpu
target/arm/kvm: Add an error handle to
kvm_arm_create_scratch_host_vcpu
target/arm/kvm: Introduce kvm_arm_vcpu_prepare_init_features helper target/arm/kvm: Introduce kvm_arm_create_init_scratch_vcpu()
Shaju Abraham (1):
target/arm/cpu_idregs: Generate tables for Arm64 ID registers and
fields
docs/system/arm/cpu-features.rst | 111 +- include/system/kvm.h | 2 +- target/arm/cpu-idregs.h | 76 + target/arm/cpu.h | 12 +- target/arm/kvm_arm.h | 26 +- target/arm/cpu-idregs.h.inc | 1549 +++++++++++++++++ target/arm/cpu-sysregs.h.inc | 13 + accel/kvm/kvm-all.c | 15 +- hw/arm/virt.c | 11 + hw/intc/armv7m_nvic.c | 4 +- target/arm/arm-qmp-cmds.c | 130 +- target/arm/cpu-idregs.c | 93 + target/arm/cpu-max.c | 4 +- target/arm/cpu.c | 24 +- target/arm/cpu64.c | 330 +++- target/arm/helper.c | 29 +- target/arm/hvf/hvf.c | 6 +- target/arm/kvm-stub.c | 17 + target/arm/kvm.c | 277 ++- target/arm/tcg/cpu-v7m.c | 18 +- target/arm/tcg/cpu32.c | 37 +- target/arm/tcg/cpu64.c | 42 +- target/arm/whpx/whpx-all.c | 6 +- target/i386/kvm/kvm.c | 22 +- target/loongarch/kvm/kvm.c | 27 +- target/ppc/kvm.c | 6 +- target/riscv/kvm/kvm-cpu.c | 3 +- target/s390x/kvm/kvm.c | 2 +- scripts/aarch64_sysreg_helpers.py | 118 ++ .../update-aarch64-cpu-sysreg-properties.py | 331 ++++ scripts/update-aarch64-cpu-sysregs-header.py | 59 + target/arm/meson.build | 1 + target/arm/trace-events | 9 + 33 files changed, 3232 insertions(+), 178 deletions(-) create mode 100644 target/arm/cpu-idregs.h create mode 100644 target/arm/cpu-idregs.h.inc create mode 100644 target/arm/cpu-idregs.c create mode 100644 scripts/aarch64_sysreg_helpers.py create mode 100644 scripts/update-aarch64-cpu-sysreg-properties.py create mode 100755 scripts/update-aarch64-cpu-sysregs-header.py
Signature · 1 line
2.53.0