Skip to content

io_uring related epoll cleanups

Jens Axboe io-uring linux-fsdevel 2 versions – Applied

Status from this message: Applied to the vfs-7.2.eventpoll branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesApplied
  2. v15 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Add patch renaming struct epoll_filefd to struct epoll_key

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6eventpoll: pass struct epoll_filefd through ep_find() and ep_insert()fs/eventpoll.c+14 -200 replies
2/6eventpoll: export is_file_epoll()fs/eventpoll.c include/linux/eventpoll.h+2 -10 replies
3/6eventpoll: add file based control interfacefs/eventpoll.c include/linux/eventpoll.h+39 -300 replies
4/6eventpoll: rename struct epoll_filefd to epoll_keyfs/eventpoll.c include/linux/eventpoll.h+8 -90 replies
5/6io_uring/epoll: switch to using do_epoll_ctl_file() interfaceio_uring/epoll.c+13 -20 replies
6/6io_uring/epoll: disallow adding an epoll file to an epoll contextio_uring/epoll.c+3 -06 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHSET v2 0/6] io_uring related epoll cleanups

Hi,

One of the nastier things about epoll is how it allows nesting contexts inside each other, leading to the necessity of loop detection and the issues that have come with that.

I don't believe there's any reason to support nesting on the io_uring side, in fact IORING_OP_EPOLL_CTL is a historical mistake, imho. But let's at least try and contain the damage and disallow nested contexts from our side.

Changes since v1:
- Add patch renaming struct epoll_filefd to struct epoll_key

 fs/eventpoll.c            | 91 ++++++++++++++++++---------------------
 include/linux/eventpoll.h |  8 ++++
 io_uring/epoll.c          | 18 +++++++-
 3 files changed, 67 insertions(+), 50 deletions(-)
Signature · 1 line
Jens Axboe