Skip to content

iommu: Standardize ATS robustness and state tracking

Pranjal Shrivastava linux-iommu linux-pci lkml 9 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 2 repliesApplied
  2. v84 patches 8 repliesSuperseded
  3. v75 patches 13 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v66 patches10 repliesSuperseded
v57 patches8 repliesSuperseded
v45 patches8 repliesSuperseded
v33 patches16 repliesSuperseded
v21 patch30 repliesSuperseded
v11 patch1 replySuperseded

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/4PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFsdrivers/pci/ats.c+5 -20 replies
2/4PCI/ATS: Validate STU for VFs in pci_prepare_ats()drivers/pci/ats.c+5 -10 replies
3/4iommu/arm-smmu-v3: Standardize ATS enablement failure reportingdrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c+7 -20 replies
4/4iommu/vt-d: Fail probe on ATS configuration failuredrivers/iommu/intel/iommu.c+12 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJason GunthorpeSamiullah KhawajaNicolin ChenLu BaoluKevin TianBjorn Helgaas
1/4R-b R-b R-b R-b R-b A-b
2/4R-b R-b R-b R-b R-b A-b
3/4R-b R-b R-b R-b
4/4R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/4] iommu: Standardize ATS robustness and state tracking

The primary motivation for this series is an ATS state mismatch observed under heavy load (via iova_stress). A failure in pci_enable_ats() leaves IOMMU drivers like arm-smmu-v3 with inconsistent state leading to PCI core warnings during device detach.

While David's recent work [1] addressed a discovery race for specific quirked devices by moving them to the HEADER phase, gaps remained regarding how Virtual Functions (VFs) inherit state from their Physical Functions (PFs). Specifically, pci_ats_supported() did not account for PF-level quirked status, and pci_prepare_ats() lacked STU validation for VFs.

Based on discussion with Jason and Baolu in v3/v5, it was decided that the IOMMU drivers should explicitly check pci_ats_supported() before calling pci_prepare_ats(). To enforce this, pci_prepare_ats() now noisily checks for support via WARN_ON(). Furthermore, the device probe should fail if pci_prepare_ats() fails. Since these early gates preclude software configuration errors, any remaining failure during pci_enable_ats() is treated as a kernel bug.

Following the discussion with the community, the driver-specific series have been posted separately:

- Intel IOMMU fixes reported by Sashiko [2]
- Refactors for AMD IOMMU [3]

[1] https://lore.kernel.org/linux-pci/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/

[v9]
- Collected R-b tags from Bjorn, Jason, Nicolin & Sami
- Folded in the dev_err into the WARN for arm-smmu-v3

[v8]
- https://lore.kernel.org/all/[email protected]/
- Collected R-b tags from Kevin & Lu
- Dropped the SMMU dev_iommu_priv_set(dev, NULL) patch.

[v7]
- https://lore.kernel.org/all/[email protected]/
- Moved patch PCI/ATS: Mandate checking pci_ats_supported() before pci_prepare_ats() to the AMD series [3] to maintain bisectibility
- Added a UAF fix for arm-smmu-v3 to set iommu->priv = NULL

[v6]
- Reverted the decoupling of pci_ats_supported() from pci_prepare_ats().
- Added a WARN_ON() to the internal support check in pci_prepare_ats().
- Dropped the standalone Intel bugfixes (RB-tree and UAF) to be sent as a separate standalone series per maintainer request.
- Kept the folded UAF fix in the AMD IOMMU patch to ensure the new error path is immediately safe.
- Collected Reviewed-by tags from Lu Baolu for PCI core patches.

[v5]
- https://lore.kernel.org/all/[email protected]/
- Decoupled pci_ats_supported() from pci_prepare_ats() in the PCI core.
- Rebased SMMUv3 support on top of Nicolin Chen's "Always-On ATS" series.
- Fixed pre-existing RB-tree corruption in VT-d probe (Baolu/Sashiko).
- Addressed the pre-existing UAF in AMD IOMMU probe suggested by Sashiko.

[v4]
- https://lore.kernel.org/all/[email protected]/
- Standardized the pattern across Intel VT-d and AMD IOMMU drivers.
- Replaced the SMMUv3 ats_prepared gate with a fatal probe-fail logic.
- Utilized WARN() macros for runtime enablement failures in all drivers.
- Collected R-b tags from Jason and Sami.

Pranjal Shrivastava (4):
PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs PCI/ATS: Validate STU for VFs in pci_prepare_ats() iommu/arm-smmu-v3: Standardize ATS enablement failure reporting iommu/vt-d: Fail probe on ATS configuration failure

 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  9 +++++++--
 drivers/iommu/intel/iommu.c                 | 15 ++++++++++++---
 drivers/pci/ats.c                           | 13 ++++++++++---
 3 files changed, 29 insertions(+), 8 deletions(-)

base-commit: 6666bde33b83cb4fc9b1f7ba6a3471479f76ce72

Signature · 1 line
2.54.0.1136.gdb2ca164c4-goog