Skip to content

s390x: Add support for virtio-scsi-pci boot device

[email protected] qemu-devel 3 versions – Applied

Status from this message: Thanks! Applied for 11.2

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 15 repliesApplied
  2. v28 patches 14 repliesSuperseded
  3. v15 of 6 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Rebase on recently added Secure IPL features added to BIOS
- Define PCI IPLB length using offset and sizeof rather than magic
- Check for virtio setup failures during scsi setup
- Fix commit messages
- Update the title of patch 3 to indicate multiple lengths change

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8pc-bios/s390-ccw: Check if a PCI function is already enabled before trying to enable itpc-bios/s390-ccw/clp.c pc-bios/s390-ccw/virtio-pci.c+4 -11 reply
2/8hw/s390x/ipl: Fix incorrect PCI IPL block lengthshw/s390x/ipl.c include/hw/s390x/ipl/qipl.h+3 -13 replies
3/8pc-bios/s390-ccw: Use bus specific IPL_TYPE directly for scsi IPLpc-bios/s390-ccw/main.c pc-bios/s390-ccw/virtio-blkdev.c pc-bios/s390-ccw/virtio.c+10 -91 reply
4/8s390x/ipl: Add PCI and bus fields to IplBlockQemuScsihw/s390x/ipl.c hw/s390x/ipl.h include/hw/s390x/ipl/qipl.h+12 -41 reply
5/8pc-bios/s390-ccw: Abstract virtio_run() for generic usepc-bios/s390-ccw/virtio-ccw.c pc-bios/s390-ccw/virtio-ccw.h pc-bios/s390-ccw/virtio.c+11 -231 reply
6/8pc-bios/s390-ccw: Add support for virtio-scsi-pci IPLpc-bios/s390-ccw/main.c pc-bios/s390-ccw/virtio-pci.c pc-bios/s390-ccw/virtio-scsi.c+49 -22 replies
7/8s390x: Find scsi-pci boot device and build IPLBhw/s390x/ipl.c pc-bios/s390-ccw/main.c+40 -03 replies
8/8tests/qtest: Add s390x PCI SCSI fallback test to cdrom-test.ctests/qtest/cdrom-test.c+8 -02 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchEric FarmanZhuoying CaiJoshua DaleyJason J. HerneMatthew Rosato
1/8R-b R-b R-b
2/8R-b R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8T-b R-b R-b
8/8T-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] s390x: Add support for virtio-scsi-pci boot device

From: Jared Rossi <[email protected]>

Add support for booting from SCSI devices with a virtio-scsi-pci controller.

Some minor clean-up is done with naming in order to clarify if the function or value used with CCW, PCI, or generic IPL and to check if a PCI function is already enabled.

Changes v2 -> v3:
- Rebase on recently added Secure IPL features added to BIOS
- Define PCI IPLB length using offset and sizeof rather than magic
- Check for virtio setup failures during scsi setup
- Fix commit messages
- Update the title of patch 3 to indicate multiple lengths change

Jared Rossi (8):
pc-bios/s390-ccw: Check if a PCI function is already enabled before
trying to enable it
hw/s390x/ipl: Fix incorrect PCI IPL block lengths pc-bios/s390-ccw: Use bus specific IPL_TYPE directly for scsi IPL s390x/ipl: Add PCI and bus fields to IplBlockQemuScsi pc-bios/s390-ccw: Abstract virtio_run() for generic use pc-bios/s390-ccw: Add support for virtio-scsi-pci IPL
s390x: Find scsi-pci boot device and build IPLB tests/qtest: Add s390x PCI SCSI fallback test to cdrom-test.c

 hw/s390x/ipl.c                   | 40 ++++++++++++++++++++++++++++++++
 hw/s390x/ipl.h                   |  2 ++
 include/hw/s390x/ipl/qipl.h      | 15 ++++++++----
 pc-bios/s390-ccw/clp.c           |  4 ++++
 pc-bios/s390-ccw/main.c          | 19 +++++++++++----
 pc-bios/s390-ccw/virtio-blkdev.c |  1 -
 pc-bios/s390-ccw/virtio-ccw.c    | 17 --------------
 pc-bios/s390-ccw/virtio-ccw.h    |  1 -
 pc-bios/s390-ccw/virtio-pci.c    | 31 ++++++++++++++++++++++++-
 pc-bios/s390-ccw/virtio-scsi.c   | 18 +++++++++++++-
 pc-bios/s390-ccw/virtio.c        | 21 +++++++++--------
 tests/qtest/cdrom-test.c         |  8 +++++++
 12 files changed, 137 insertions(+), 40 deletions(-)
Signature · 1 line
2.54.0