Skip to content

net: shaper: fix various minor bugs

Jakub Kicinski linux-kselftest netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 0 repliesApplied 10/10
  2. v112 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- drop the first 2 patches - the corresponding changes will be sent later to net-next.
v1: https://lore.kernel.org/[email protected]

Patches in v2 All 10 applied

#Subject and filesSizeRepliesApplied
1/10net: shaper: flip the polarity of the valid flagnet/shaper/shaper.c+17 -170 repliesApplied
2/10net: shaper: fix trivial ordering issue in net_shaper_commit()net/shaper/shaper.c+10 -10 repliesApplied
3/10net: shaper: reject duplicate leaves in GROUP requestnet/shaper/shaper.c+45 -150 repliesApplied
4/10selftests: drv-net: add shaper test for duplicate leavestools/testing/selftests/drivers/net/shaper.py+22 -20 repliesApplied
5/10net: shaper: set ret to -ENOMEM when genlmsg_new() fails in group_doitnet/shaper/shaper.c+3 -10 repliesApplied
6/10net: shaper: fix undersized reply skb allocation in GROUP commandnet/shaper/shaper.c+8 -20 repliesApplied
7/10tools: ynl: add scope qualifier for definitionsDocumentation/netlink/genetlink-c.yaml Documentation/netlink/genetlink-legacy.yaml Documentation/netlink/genetlink.yaml +2 more+65 -20 repliesApplied
8/10net: shaper: reject handle IDs exceeding internal bit-widthDocumentation/netlink/specs/net_shaper.yaml net/shaper/shaper.c net/shaper/shaper_nl_gen.c +1 more+18 -20 repliesApplied
9/10net: shaper: enforce singleton NETDEV scope with id 0net/shaper/shaper.c+6 -00 repliesApplied
10/10net: shaper: reject QUEUE scope handle with missing idnet/shaper/shaper.c+7 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net v2 00/10] net: shaper: fix various minor bugs

Fix various minor bugs in the net shaper API.

First 2 patches deal with ordering issues around inserting and publishing new shapers. Shapers are inserted "tentatively" and marked valid only after HW op succeeded, this used to be slightly racy.

Only other patch of note is patch 8. We want to add a Netlink policy check on the handle ID. This necessitates patch 7.

The rest are simple and self-explanatory.

v2:
- drop the first 2 patches - the corresponding changes will be sent later to net-next.
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (10):
net: shaper: flip the polarity of the valid flag
net: shaper: fix trivial ordering issue in net_shaper_commit()
net: shaper: reject duplicate leaves in GROUP request
selftests: drv-net: add shaper test for duplicate leaves
net: shaper: set ret to -ENOMEM when genlmsg_new() fails in group_doit
net: shaper: fix undersized reply skb allocation in GROUP command
tools: ynl: add scope qualifier for definitions
net: shaper: reject handle IDs exceeding internal bit-width
net: shaper: enforce singleton NETDEV scope with id 0
net: shaper: reject QUEUE scope handle with missing id

 Documentation/netlink/genetlink-c.yaml        |   9 ++
 Documentation/netlink/genetlink-legacy.yaml   |   9 ++
 Documentation/netlink/genetlink.yaml          |   9 ++
 Documentation/netlink/netlink-raw.yaml        |   9 ++
 Documentation/netlink/specs/net_shaper.yaml   |   7 +
 net/shaper/shaper_nl_gen.h                    |   2 +
 net/shaper/shaper.c                           | 136 +++++++++++++-----
 net/shaper/shaper_nl_gen.c                    |   7 +-
 tools/net/ynl/pyynl/ynl_gen_c.py              |  31 +++-
 tools/testing/selftests/drivers/net/shaper.py |  24 +++-
 10 files changed, 200 insertions(+), 43 deletions(-)
Signature · 1 line
2.54.0