Skip to content

i2c: tegra: fix error handling in tegra_i2c_xfer()

Saurav Sachidanand linux-i2c linux-tegra lkml 2 versions – Applied

Status from this message: merged to i2c/i2c-host-fixes.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesApplied
  2. v11 patch 1 replySuperseded

Changes in v2 from the cover letter

- Split into two patches (Jon)
- Make tegra_i2c_mutex_unlock() return void with WARN instead of propagating the error value (Jon)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2i2c: tegra: fix pm_runtime leak on mutex_lock failuredrivers/i2c/busses/i2c-tegra.c+3 -12 replies
2/2i2c: tegra: make tegra_i2c_mutex_unlock() return voiddrivers/i2c/busses/i2c-tegra.c+6 -92 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchThierry RedingJon Hunter
1/2A-b R-b
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] i2c: tegra: fix error handling in tegra_i2c_xfer()

Fix two bugs in the SW mutex path introduced by commit 6077cfd716fb ("i2c: tegra: Add support for SW mutex register"):

1/2: Fix pm_runtime reference leak when tegra_i2c_mutex_lock() fails. 2/2: Make tegra_i2c_mutex_unlock() return void with WARN to avoid
silently losing transfer errors.

Changes since v1:
- Split into two patches (Jon)
- Make tegra_i2c_mutex_unlock() return void with WARN instead of propagating the error value (Jon)

v1: https://lore.kernel.org/all/[email protected]/

Saurav Sachidanand (2):
i2c: tegra: fix pm_runtime leak on mutex_lock failure
i2c: tegra: make tegra_i2c_mutex_unlock() return void

 drivers/i2c/busses/i2c-tegra.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
Signature · 1 line
2.47.3