Skip to content

net: stmmac: eic7700: fix delay calculation and initialization ordering

[email protected] linux-arm-kernel linux-devicetree lkml netdev sashiko-reviews 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesApplied 5/5
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Update eswin,eic7700-eth.yaml:
- Limit the binding changes to adding optional TXD and RXD delay register offsets in eswin,hsp-sp-csr.
- Restore the original enum-based definitions for rx-internal-delay-ps and tx-internal-delay-ps.
- Keep rx-internal-delay-ps and tx-internal-delay-ps as required properties.
- Restore the original example content, with only the additional optional TXD and RXD delay register offsets.
- Restore Acked-by from Conor Dooley for the binding change, which was temporarily omitted in v1 during series restructuring and has been reinstated now that the change is stable and properly isolated.

- Update dwmac-eic7700.c:
- Split driver changes into smaller patches based on review feedback to improve reviewability and bisectability.
- Keep the existing requirement that rx-internal-delay-ps and tx-internal-delay-ps must be present in the device tree.
- Treat TXD/RXD delay register offsets as optional and only program them when provided by device tree.
- Remove the previously proposed fix_mac_speed logic.

- Link to v1:

Patches in v2 All 5 applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsetsDocumentation/devicetree/bindings/net/eswin,eic7700-eth.yaml+12 -15 repliesApplied
2/5net: stmmac: eswin: fix HSP CSR init ordering after clock enabledrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c+41 -322 repliesApplied
3/5net: stmmac: eswin: clear TXD and RXD delay registers during initializationdrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c+22 -00 repliesApplied
4/5net: stmmac: eswin: correct RGMII delay granularity to 20 psdrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c+4 -40 repliesApplied
5/5net: stmmac: eswin: validate RGMII delay valuesdrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c+25 -40 repliesApplied

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchConor Dooley
1/5A-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/5] net: stmmac: eic7700: fix delay calculation and initialization ordering

From: Zhi Li <[email protected]>

v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Limit the binding changes to adding optional TXD and RXD delay register offsets in eswin,hsp-sp-csr.
- Restore the original enum-based definitions for rx-internal-delay-ps and tx-internal-delay-ps.
- Keep rx-internal-delay-ps and tx-internal-delay-ps as required properties.
- Restore the original example content, with only the additional optional TXD and RXD delay register offsets.
- Restore Acked-by from Conor Dooley for the binding change, which was temporarily omitted in v1 during series restructuring and has been reinstated now that the change is stable and properly isolated.

- Update dwmac-eic7700.c:
- Split driver changes into smaller patches based on review feedback to improve reviewability and bisectability.
- Keep the existing requirement that rx-internal-delay-ps and tx-internal-delay-ps must be present in the device tree.
- Treat TXD/RXD delay register offsets as optional and only program them when provided by device tree.
- Remove the previously proposed fix_mac_speed logic.

- Link to v1:

    https://lore.kernel.org/lkml/[email protected]/

Zhi Li (5):
dt-bindings: ethernet: eswin: add optional TXD and RXD delay register
offsets
net: stmmac: eswin: fix HSP CSR init ordering after clock enable
net: stmmac: eswin: clear TXD and RXD delay registers during
initialization
net: stmmac: eswin: correct RGMII delay granularity to 20 ps
net: stmmac: eswin: validate RGMII delay values

 .../bindings/net/eswin,eic7700-eth.yaml       |  13 +-
 .../ethernet/stmicro/stmmac/dwmac-eic7700.c   | 126 +++++++++++++-----
 2 files changed, 101 insertions(+), 38 deletions(-)
Signature · 1 line
2.25.1