Skip to content

net/sched: prepare lockless qdisc dumps

Eric Dumazet netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyApplied 8/8
  2. v18 patches 3 repliesSuperseded

Patches in v2 All 8 applied

#Subject and filesSizeRepliesApplied
1/8net/sched: add READ_ONCE() in gnet_stats_add_queue[_cpu]net/core/gen_stats.c+10 -100 repliesApplied
2/8net/sched: add qdisc_qlen_inc() and qdisc_qlen_dec()include/net/sch_generic.h net/sched/sch_api.c net/sched/sch_cake.c +26 more+107 -910 repliesApplied
3/8net/sched: annotate data-races around sch->qstats.backloginclude/net/sch_generic.h net/sched/sch_api.c net/sched/sch_cake.c +18 more+41 -310 repliesApplied
4/8net/sched: add qdisc_qlen_lockless() helperinclude/net/sch_generic.h net/sched/sch_mq.c net/sched/sch_mqprio.c+9 -40 repliesApplied
5/8net/sched: add const qualifiers to gnet_stats helpersinclude/net/gen_stats.h include/net/sch_generic.h net/core/gen_stats.c+24 -250 repliesApplied
6/8net/sched: mq: no longer acquire qdisc spinlocks in dump operationsinclude/net/sch_generic.h net/sched/sch_mq.c+31 -100 repliesApplied
7/8net/sched: mq_prio: no longer acquire qdisc spinlocks in mqprio_dump()net/sched/sch_mqprio.c+24 -130 repliesApplied
8/8net/sched: mq_prio: no longer acquire qdisc spinlocks in mqprio_dump_class_stats()net/sched/sch_mqprio.c+15 -250 repliesApplied

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchToke Høiland-Jørgensen
SeriesA-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/8] net/sched: prepare lockless qdisc dumps

Goal is to no longer acquire RTNL in qdisc dumps.

This series annotate data-races, and change mq and mq_prio to no longer acquire children qdisc spinlocks.

v2: addressed sashiko (and Victor Nogueira) feedback.

Eric Dumazet (8):
net/sched: add READ_ONCE() in gnet_stats_add_queue[_cpu] net/sched: add qdisc_qlen_inc() and qdisc_qlen_dec() net/sched: annotate data-races around sch->qstats.backlog net/sched: add qdisc_qlen_lockless() helper
net/sched: add const qualifiers to gnet_stats helpers net/sched: mq: no longer acquire qdisc spinlocks in dump operations net/sched: mq_prio: no longer acquire qdisc spinlocks in mqprio_dump() net/sched: mq_prio: no longer acquire qdisc spinlocks in
mqprio_dump_class_stats()

 include/net/gen_stats.h   | 16 +++----
 include/net/sch_generic.h | 64 ++++++++++++++++++++-------
 net/core/gen_stats.c      | 51 +++++++++++----------
 net/sched/sch_api.c       |  4 +-
 net/sched/sch_cake.c      | 18 ++++----
 net/sched/sch_cbs.c       |  6 +--
 net/sched/sch_choke.c     |  8 ++--
 net/sched/sch_codel.c     |  2 +-
 net/sched/sch_drr.c       |  6 +--
 net/sched/sch_dualpi2.c   |  6 +--
 net/sched/sch_etf.c       |  8 ++--
 net/sched/sch_ets.c       |  6 +--
 net/sched/sch_fq.c        |  8 ++--
 net/sched/sch_fq_codel.c  | 11 ++---
 net/sched/sch_fq_pie.c    |  8 ++--
 net/sched/sch_generic.c   | 12 ++---
 net/sched/sch_gred.c      |  2 +-
 net/sched/sch_hfsc.c      |  6 +--
 net/sched/sch_hhf.c       |  7 +--
 net/sched/sch_htb.c       |  6 +--
 net/sched/sch_mq.c        | 37 +++++++++++-----
 net/sched/sch_mqprio.c    | 93 ++++++++++++++++++++-------------------
 net/sched/sch_multiq.c    |  4 +-
 net/sched/sch_netem.c     | 12 ++---
 net/sched/sch_prio.c      |  6 +--
 net/sched/sch_qfq.c       |  8 ++--
 net/sched/sch_red.c       |  6 +--
 net/sched/sch_sfb.c       |  8 ++--
 net/sched/sch_sfq.c       | 11 ++---
 net/sched/sch_skbprio.c   |  4 +-
 net/sched/sch_taprio.c    |  4 +-
 net/sched/sch_tbf.c       | 10 ++---
 net/sched/sch_teql.c      |  2 +-
 33 files changed, 256 insertions(+), 204 deletions(-)
Signature · 1 line
2.54.0.563.g4f69b47b94-goog