Skip to content

Refcounted interrupt disable and SpinLockIrq for Rust

Boqun Feng lkml rust-for-linux 5 versions – Applied

Status from this message: The following commit has been merged into the locking/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest18 patches 9 repliesApplied
  2. v417 patches 28 repliesApplied
  3. v313 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches13 repliesSuperseded
v111 patches10 repliesSuperseded

Changes in v5 from the cover letter

* Addressed SoB issues spotted by Peter.
* Added underflow/overflow checking for interrupt disabling counter as suggested by Shrikanth.
* Added a max nesting level per suggestion from Shrikanth.
* Document/comment updates.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/18preempt: Track NMI nesting to separate per-CPU counterinclude/linux/hardirq.h include/linux/preempt.h kernel/softirq.c +1 more+23 -70 replies
2/18preempt: Introduce HARDIRQ_DISABLE_BITSinclude/linux/preempt.h tools/testing/selftests/bpf/bpf_experimental.h+15 -60 replies
3/18preempt: Introduce __preempt_count_{sub,add}_return()arch/arm64/include/asm/preempt.h arch/s390/include/asm/preempt.h arch/x86/include/asm/preempt.h +1 more+54 -00 replies
4/18openrisc: Include <linux/cpumask.h> in smp.harch/openrisc/include/asm/smp.h+2 -00 replies
5/18irq & spin_lock: Add counted interrupt disabling/enablinginclude/linux/interrupt_rc.h include/linux/preempt.h include/linux/spinlock.h +5 more+253 -20 replies
6/18irq: Add KUnit test for refcounted interrupt enable/disablekernel/irq/Makefile kernel/irq/refcount_interrupt_test.c+110 -00 replies
7/18irq: Add max local_interrupt_disable() nesting level kunit test casekernel/irq/refcount_interrupt_test.c+22 -00 replies
8/18locking: Switch to _irq_{disable,enable}() variants in cleanup guardsinclude/linux/spinlock.h kernel/sched/fair.c+18 -200 replies
9/18sched: Remove the unused preempt_offset parameter of __cant_sleep()include/linux/kernel.h kernel/sched/core.c+4 -40 replies
10/18sched: Avoid signed comparison of preempt_count() in __cant_migrate()kernel/sched/core.c+1 -10 replies
11/18preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITSarch/x86/Kconfig arch/x86/include/asm/preempt.h arch/x86/kernel/cpu/common.c +6 more+115 -370 replies
12/18arm64: sched/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITSarch/arm64/Kconfig+1 -00 replies
13/18s390/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITSarch/s390/Kconfig arch/s390/include/asm/lowcore.h arch/s390/include/asm/preempt.h+30 -270 replies
14/18rust: Introduce interrupt modulerust/helpers/helpers.c rust/helpers/interrupt.c rust/helpers/sync.c +2 more+114 -02 replies
15/18rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpersrust/helpers/spinlock.c+15 -00 replies
16/18rust: sync: Use super::* in spinlock.rsrust/kernel/sync/lock/spinlock.rs+4 -50 replies
17/18rust: sync: Add SpinLockIrqrust/kernel/sync.rs rust/kernel/sync/lock/global.rs rust/kernel/sync/lock/spinlock.rs+241 -12 replies
18/18rust: sync: Introduce SpinLockIrq::lock_with() and friendsrust/kernel/sync/lock/spinlock.rs+91 -10 replies

Reviews trailers per patch

6 of 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHeiko CarstensStafford HornePeter ZijlstraBenno LossinAndreas HindborgGary GuoShrikanth Hegde
SeriesR-b
1/18
2/18
3/18A-b
4/18A-b
5/18
6/18
7/18
8/18
9/18
10/18
11/18Originally-by
12/18
13/18
14/18R-b R-b R-b
15/18R-b R-b
16/18
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/18] Refcounted interrupt disable and SpinLockIrq for Rust

Hi Peter & Ingo,

Please take a look at this updated series for SpinLockIrq.

Changes since v4:

* Addressed SoB issues spotted by Peter.
* Added underflow/overflow checking for interrupt disabling counter as suggested by Shrikanth.
* Added a max nesting level per suggestion from Shrikanth.
* Document/comment updates.

v4: https://lore.kernel.org/lkml/[email protected]/

Regards,
Boqun

Boqun Feng (10):
preempt: Introduce HARDIRQ_DISABLE_BITS
preempt: Introduce __preempt_count_{sub,add}_return()
irq & spin_lock: Add counted interrupt disabling/enabling
irq: Add max local_interrupt_disable() nesting level kunit test case
locking: Switch to _irq_{disable,enable}() variants in cleanup guards
sched: Remove the unused preempt_offset parameter of __cant_sleep()
sched: Avoid signed comparison of preempt_count() in __cant_migrate()
preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITS
arm64: sched/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITS
rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers

Heiko Carstens (1):
s390/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITS

Joel Fernandes (1):
preempt: Track NMI nesting to separate per-CPU counter

Lyude Paul (6):
openrisc: Include <linux/cpumask.h> in smp.h
irq: Add KUnit test for refcounted interrupt enable/disable
rust: Introduce interrupt module
rust: sync: Use super::* in spinlock.rs
rust: sync: Add SpinLockIrq
rust: sync: Introduce SpinLockIrq::lock_with() and friends

 arch/arm64/Kconfig                            |   1 +
 arch/arm64/include/asm/preempt.h              |  20 ++
 arch/openrisc/include/asm/smp.h               |   2 +
 arch/s390/Kconfig                             |   1 +
 arch/s390/include/asm/lowcore.h               |  13 +-
 arch/s390/include/asm/preempt.h               |  51 +--
 arch/x86/Kconfig                              |   1 +
 arch/x86/include/asm/preempt.h                |  61 +++-
 arch/x86/kernel/cpu/common.c                  |   2 +-
 include/asm-generic/preempt.h                 |  14 +
 include/linux/hardirq.h                       |  40 ++-
 include/linux/interrupt_rc.h                  |  95 +++++
 include/linux/kernel.h                        |   4 +-
 include/linux/preempt.h                       |  44 ++-
 include/linux/spinlock.h                      |  49 ++-
 include/linux/spinlock_api_smp.h              |  41 +++
 include/linux/spinlock_api_up.h               |  15 +
 include/linux/spinlock_rt.h                   |  18 +
 kernel/Kconfig.preempt                        |   4 +
 kernel/irq/Makefile                           |   1 +
 kernel/irq/refcount_interrupt_test.c          | 131 +++++++
 kernel/locking/spinlock.c                     |  31 ++
 kernel/sched/core.c                           |  18 +-
 kernel/sched/fair.c                           |  12 +-
 kernel/softirq.c                              |  36 +-
 rust/helpers/helpers.c                        |   1 +
 rust/helpers/interrupt.c                      |  18 +
 rust/helpers/spinlock.c                       |  15 +
 rust/helpers/sync.c                           |   5 +
 rust/kernel/interrupt.rs                      |  89 +++++
 rust/kernel/lib.rs                            |   1 +
 rust/kernel/sync.rs                           |   9 +-
 rust/kernel/sync/lock/global.rs               |   3 +
 rust/kernel/sync/lock/spinlock.rs             | 329 +++++++++++++++++-
 .../testing/selftests/bpf/bpf_experimental.h  |   7 +-
 35 files changed, 1092 insertions(+), 90 deletions(-)
 create mode 100644 include/linux/interrupt_rc.h
 create mode 100644 kernel/irq/refcount_interrupt_test.c
 create mode 100644 rust/helpers/interrupt.c
 create mode 100644 rust/kernel/interrupt.rs
Signature · 1 line
2.50.1 (Apple Git-155)