Skip to content

tests/amdgpu/amd_replay: Add Replay Rate Control test

Ray Wu igt-dev 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/amdgpu/amd_replay: fix operator precedence and typostests/amdgpu/amd_replay.c+17 -110 replies
2/2tests/amdgpu/amd_replay: add Replay Rate Control IGT testlib/igt_amd.c lib/igt_amd.h tests/amdgpu/amd_replay.c+185 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH i-g-t, v2 0/2] tests/amdgpu/amd_replay: Add Replay Rate Control test

This series adds an IGT subtest for Panel Replay's rate control feature on AMD eDP panels, and fixes a few pre-existing logic bugs in amd_replay that were uncovered while reviewing the new test.

Panel Replay rate control extends the panel's coasting vtotal while the screen is static (lowering refresh rate for power savings) and restores it once live updates resume. The behaviour is observable through the per-connector replay_coasting_vtotal debugfs node, but is currently not exercised by IGT, so silent regressions in either the driver state machine or the panel firmware are possible.

Patch 1 is a pure bug fix for existing replay subtests:
- The test_mode == (A || B) and test_mode == A || B conditionals in page_flip_test() / run_check_replay() always evaluated truthy, so the guarded state checks ran regardless of test_mode.
- Three igt_fail_on_f() range checks combined state < N with state >= N+1 using &&, which can never be true; those assertions effectively never fired.
- Two "mdoe" -> "mode" typos in igt_describe() strings.

Patch 2 adds the new test on top:
- Two helpers in lib/igt_amd:
* igt_amd_replay_support_rate_control() returns true when the connector's replay_capability advertises
"Rate control support: yes".
* igt_amd_read_replay_coasting_vtotal() reads replay_coasting_vtotal; returns 0 on success or -errno on failure.
- A new "replay_rate_control" subtest:
1. Drive page flips so Panel Replay engages.
2. Wait for the screen to settle, sample static coasting vtotal.
3. Drive page flips to put replay back into live mode, sample live coasting vtotal.
4. Assert static > live (lower refresh rate while static).

Ray Wu (2):
tests/amdgpu/amd_replay: fix operator precedence and typos tests/amdgpu/amd_replay: add Replay Rate Control IGT test

 lib/igt_amd.c             |  94 ++++++++++++++++++++++++++++++
 lib/igt_amd.h             |   3 +
 tests/amdgpu/amd_replay.c | 116 ++++++++++++++++++++++++++++++++++----
 3 files changed, 202 insertions(+), 11 deletions(-)
Signature · 1 line
2.43.0