Skip to content

Fixes on Deterministic and Hybrid Automata

Gabriele Monaco linux-trace-kernel lkml stable 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest13 patches 4 repliesIn review
  2. v313 patches 15 repliesSuperseded
  3. v212 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches17 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Fix __user specifier usage in extract_params()kernel/trace/rv/monitors/deadline/deadline.h+2 -10 replies
2/13Reset per-task DA monitors before releasing the slotinclude/rv/da_monitor.h+3 -20 replies
3/13Prevent in-flight per-task handlers from using invalid slotsinclude/rv/da_monitor.h include/rv/ltl_monitor.h+5 -00 replies
4/13Ensure all pending probes terminate on per-obj monitor destroyinclude/rv/da_monitor.h+3 -20 replies
5/13Fix monitor start ordering and memory ordering for monitoring flaginclude/rv/da_monitor.h+5 -30 replies
6/13Do not rely on clean monitor when initialising HAinclude/rv/da_monitor.h include/rv/ha_monitor.h+76 -171 reply
7/13Add automatic cleanup handlers for per-task HA monitorsinclude/rv/ha_monitor.h kernel/trace/rv/monitors/nomiss/nomiss.c kernel/trace/rv/monitors/opid/opid.c +2 more+68 -80 replies
8/13Ensure synchronous cleanup for HA monitorsinclude/rv/da_monitor.h include/rv/ha_monitor.h+42 -61 reply
9/13Prevent task migration while handling per-CPU eventsinclude/rv/da_monitor.h+11 -00 replies
10/13Use 0 to check preemption enabled in opidkernel/trace/rv/monitors/opid/opid.c+1 -70 replies
11/13verification/rvgen: Fix suffix strip in dot2ktools/verification/rvgen/rvgen/dot2k.py+2 -20 replies
12/13Fix read_lock scope in per-task DA cleanupinclude/rv/da_monitor.h+4 -42 replies
13/13verification/rvgen: Generate cleanup hook for per-obj monitortools/verification/rvgen/rvgen/dot2k.py+15 -00 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchWen YangNam CaoGabriele Monaco
1/13R-b R-b
2/13R-b R-b
3/13R-b
4/13R-b R-b
5/13R-b R-b
6/13R-b R-b
7/13R-b
8/13R-b
9/13R-b R-b
10/13R-b
11/13R-b
12/13R-b R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/13] rv: Fixes on Deterministic and Hybrid Automata

Fix issues that were reported by bots or visible only after integration:
* Make sure timers are always terminated and waited for when disabling the monitor or when the target terminates
* Run per-cpu monitors with migration disabled since preemption is now enabled from tracepoints
* Fix a wrong __user specifier in a helper function
* Other cleanup and concurrency issues

Differences since V3 [1]:
* Use separate reset functions for HA init/reset to avoid globals
* Reset monitor before sync stopping the timer on HA per-task exit hook

Differences since V2 [2]:
* Applied from reviews changes to commit messages
* Rearranged order to put non-fixes and not-reviewed patches in the end
* Synchronise monitors before resetting them to avoid rearming
* Protect against racing timer callbacks during destruction

Differences since V1 [3]:
* Fix memory consistency with timer callbacks racing with resets
* Add per-obj deallocation hook in rvgen generated code
* Do not rely on clean monitor when initialising HA
* Add tracepoint synchronisation before returning per-task slots
* Fix suffix strip in dot2k
* Generate stub deallocation hooks instead of failing build when per-obj miss those

[1] - https://lore.kernel.org/lkml/[email protected]
[2] - https://lore.kernel.org/lkml/[email protected]
[3] - https://lore.kernel.org/lkml/[email protected]

Cc Steven Rostedt <[email protected]>
Cc Nam Cao <[email protected]>
Cc Wen Yang <[email protected]>

Gabriele Monaco (12):
rv: Fix __user specifier usage in extract_params()
rv: Reset per-task DA monitors before releasing the slot
rv: Prevent in-flight per-task handlers from using invalid slots
rv: Ensure all pending probes terminate on per-obj monitor destroy
rv: Do not rely on clean monitor when initialising HA
rv: Add automatic cleanup handlers for per-task HA monitors
rv: Ensure synchronous cleanup for HA monitors
rv: Prevent task migration while handling per-CPU events
rv: Use 0 to check preemption enabled in opid verification/rvgen: Fix suffix strip in dot2k
rv: Fix read_lock scope in per-task DA cleanup verification/rvgen: Generate cleanup hook for per-obj monitor

Wen Yang (1):
rv: Fix monitor start ordering and memory ordering for monitoring flag

 include/rv/da_monitor.h                       | 145 ++++++++++++++----
 include/rv/ha_monitor.h                       |  91 ++++++++++-
 include/rv/ltl_monitor.h                      |   1 +
 kernel/trace/rv/monitors/deadline/deadline.h  |   3 +-
 kernel/trace/rv/monitors/nomiss/nomiss.c      |   4 +-
 kernel/trace/rv/monitors/opid/opid.c          |  12 +-
 kernel/trace/rv/monitors/stall/stall.c        |   4 +-
 tools/verification/rvgen/rvgen/dot2k.py       |  19 ++-
 .../rvgen/rvgen/templates/dot2k/main.c        |   4 +-
 9 files changed, 234 insertions(+), 49 deletions(-)

base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8

Signature · 1 line
2.54.0