Skip to content

arm64: dts: qcom: Fix PCIe wake GPIO polarity

Krishna Chaitanya Chundru linux-arm-msm linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20260514-wake-1dfbdedcd173

Versions newest first

  1. v2 Latest37 patches 2 repliesIn review
  2. v118 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Move phy, perst & wake properties to the root port node.
- Rebased the code
- Link to v1: https://patch.msgid.link/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/37ARM: dts: qcom: sdx55: Fix PCIe wake GPIO polarityarch/arm/boot/dts/qcom/qcom-sdx55-t55.dts+1 -10 replies
2/37arm64: dts: qcom: msm8996: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi+2 -20 replies
3/37arm64: dts: qcom: sdm845: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sdm845-db845c.dts+1 -10 replies
4/37arm64: dts: qcom: sc8180x: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts arch/arm64/boot/dts/qcom/sc8180x-primus.dts+2 -20 replies
5/37arm64: dts: qcom: sm8150: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8150.dtsi+1 -10 replies
6/37arm64: dts: qcom: sm8250: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8250.dtsi+3 -30 replies
7/37arm64: dts: qcom: sm8350: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8350-hdk.dts+2 -20 replies
8/37arm64: dts: qcom: sm8450: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8450.dtsi+2 -20 replies
9/37arm64: dts: qcom: sm8550: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi arch/arm64/boot/dts/qcom/sm8550-hdk.dts arch/arm64/boot/dts/qcom/sm8550-mtp.dts +3 more+9 -90 replies
10/37arm64: dts: qcom: sm8650: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts arch/arm64/boot/dts/qcom/sm8650-hdk.dts arch/arm64/boot/dts/qcom/sm8650-mtp.dts +1 more+7 -70 replies
11/37arm64: dts: qcom: sm8750: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sm8750-mtp.dts+1 -10 replies
12/37arm64: dts: qcom: kaanapali: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/kaanapali-mtp.dts+1 -10 replies
13/37arm64: dts: qcom: sar2130p: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts+1 -10 replies
14/37arm64: dts: qcom: monaco: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/monaco-evk.dts arch/arm64/boot/dts/qcom/qcs8300-ride.dts+4 -40 replies
15/37arm64: dts: qcom: lemans: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/lemans-evk.dts arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi+4 -40 replies
16/37arm64: dts: qcom: sa8540p-ride: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/sa8540p-ride.dts+2 -20 replies
17/37arm64: dts: qcom: kodiak: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts +1 more+6 -60 replies
18/37arm64: dts: qcom: talos: Fix PCIe wake GPIO polarityarch/arm64/boot/dts/qcom/qcs615-ride.dts arch/arm64/boot/dts/qcom/talos-evk-som.dtsi+2 -20 replies
19/37arm64: dts: qcom: lemans: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/lemans-evk.dts arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi arch/arm64/boot/dts/qcom/lemans.dtsi+25 -190 replies
20/37arm64: dts: qcom: msm8998: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/msm8998.dtsi+4 -40 replies
21/37arm64: dts: qcom: qcs404: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/qcs404-evb.dtsi arch/arm64/boot/dts/qcom/qcs404.dtsi+7 -60 replies
22/37arm64: dts: qcom: qcs8550: Move PCIe GPIOs to root port nodearch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi+10 -60 replies
23/37arm64: dts: qcom: sa8295p: Move PCIe GPIOs to root port nodearch/arm64/boot/dts/qcom/sa8295p-adp.dts+20 -121 reply
24/37arm64: dts: qcom: sa8540p: Move PCIe GPIOs to root port nodearch/arm64/boot/dts/qcom/sa8540p-ride.dts+10 -60 replies
25/37arm64: dts: qcom: sar2130p: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts arch/arm64/boot/dts/qcom/sar2130p.dtsi+8 -100 replies
26/37arm64: dts: qcom: sc8180x: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts arch/arm64/boot/dts/qcom/sc8180x-primus.dts arch/arm64/boot/dts/qcom/sc8180x.dtsi+22 -161 reply
27/37arm64: dts: qcom: sc8280xp: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sc8280xp-crd.dts arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +3 more+67 -540 replies
28/37arm64: dts: qcom: sdm845: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sdm845-db845c.dts arch/arm64/boot/dts/qcom/sdm845-mtp.dts arch/arm64/boot/dts/qcom/sdm845.dtsi+23 -160 replies
29/37arm64: dts: qcom: sm8150: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8150.dtsi+9 -120 replies
30/37arm64: dts: qcom: sm8250: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8250.dtsi+14 -200 replies
31/37arm64: dts: qcom: sm8350: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8350-hdk.dts arch/arm64/boot/dts/qcom/sm8350.dtsi+16 -140 replies
32/37arm64: dts: qcom: sm8450: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8450.dtsi+9 -130 replies
33/37arm64: dts: qcom: sm8550: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8550-hdk.dts arch/arm64/boot/dts/qcom/sm8550-mtp.dts arch/arm64/boot/dts/qcom/sm8550-qrd.dts +3 more+36 -270 replies
34/37arm64: dts: qcom: talos: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/qcs615-ride.dts arch/arm64/boot/dts/qcom/talos-evk-som.dtsi arch/arm64/boot/dts/qcom/talos.dtsi+12 -90 replies
35/37arm64: dts: qcom: sm8650: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts arch/arm64/boot/dts/qcom/sm8650-hdk.dts arch/arm64/boot/dts/qcom/sm8650-mtp.dts +2 more+33 -270 replies
36/37arm64: dts: qcom: kodiak: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/kodiak.dtsi arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts +6 more+54 -350 replies
37/37arm64: dts: qcom: msm8996: Move PCIe phy and GPIOs to root port nodearch/arm64/boot/dts/qcom/apq8096-db820c.dtsi arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi +2 more+33 -190 replies

Reviews trailers per patch

18 of 37 patches have a Reviewed-by or Acked-by.

PatchKonrad DybcioManivannan Sadhasivam
1/37R-b R-b
2/37R-b R-b
3/37R-b R-b
4/37R-b R-b
5/37R-b R-b
6/37R-b R-b
7/37R-b R-b
8/37R-b R-b
9/37R-b R-b
10/37R-b R-b
11/37R-b R-b
12/37R-b R-b
13/37R-b R-b
14/37R-b R-b
15/37R-b R-b
16/37R-b R-b
17/37R-b R-b
18/37R-b R-b
19/37
20/37
21/37
22/37
23/37
24/37
25/37
26/37
27/37
28/37
29/37
30/37
31/37
32/37
33/37
34/37
35/37
36/37
37/37

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/37] arm64: dts: qcom: Fix PCIe wake GPIO polarity

PCIe wake is active low signal as per the PCIe base spec, Several Qualcomm platform devicetrees incorrectly describe wake-gpios as GPIO_ACTIVE_HIGH.

The PCIe PHY references and PERST/WAKE GPIO properties are defined on a per-root-port basis and do not belong to the PCIe controller (RC) node. Keeping these properties at the controller level makes the description less accurate and prevents clean per-port customization.

This series moves the PHY references (phys, phy-names) from the PCIe controller node to the corresponding root port nodes (pcie@0), namely pcie0_port0, pcie1_port0, and pcie2_port0. Labels are added to these port nodes to enable board-level overrides where required.

Additionally, the PERST and WAKE GPIO properties are relocated from controller-level board overrides to their respective root port nodes in the board DTS files. As part of this change, 'perst-gpios' is renamed to 'reset-gpios' to align with the binding used in the PCIe root port context.

This restructuring improves DT correctness by properly associating resources with their respective hardware blocks and aligns with the expectations defined in the PCIe binding.

Tested on Talos Ride & lemans evk platform.

No Fixes tag is added as no functional issue has been observed.

---
Changes in v2:
- Move phy, perst & wake properties to the root port node.
- Rebased the code
- Link to v1: https://patch.msgid.link/[email protected]

---
Krishna Chaitanya Chundru (37):
ARM: dts: qcom: sdx55: Fix PCIe wake GPIO polarity
arm64: dts: qcom: msm8996: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sdm845: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sc8180x: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8150: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8250: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8350: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8450: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8550: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8650: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sm8750: Fix PCIe wake GPIO polarity
arm64: dts: qcom: kaanapali: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sar2130p: Fix PCIe wake GPIO polarity
arm64: dts: qcom: monaco: Fix PCIe wake GPIO polarity
arm64: dts: qcom: lemans: Fix PCIe wake GPIO polarity
arm64: dts: qcom: sa8540p-ride: Fix PCIe wake GPIO polarity
arm64: dts: qcom: kodiak: Fix PCIe wake GPIO polarity
arm64: dts: qcom: talos: Fix PCIe wake GPIO polarity
arm64: dts: qcom: lemans: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: msm8998: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: qcs404: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: qcs8550: Move PCIe GPIOs to root port node
arm64: dts: qcom: sa8295p: Move PCIe GPIOs to root port node
arm64: dts: qcom: sa8540p: Move PCIe GPIOs to root port node
arm64: dts: qcom: sar2130p: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sc8180x: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sc8280xp: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sdm845: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8150: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8250: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8350: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8450: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8550: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: talos: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: sm8650: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: kodiak: Move PCIe phy and GPIOs to root port node
arm64: dts: qcom: msm8996: Move PCIe phy and GPIOs to root port node

 arch/arm/boot/dts/qcom/qcom-sdx55-t55.dts          |  2 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi       | 15 ++++++++--
 arch/arm64/boot/dts/qcom/kaanapali-mtp.dts         |  2 +-
 arch/arm64/boot/dts/qcom/kodiak.dtsi               | 10 +++----
 arch/arm64/boot/dts/qcom/lemans-evk.dts            | 16 ++++++----
 arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi   | 16 ++++++----
 arch/arm64/boot/dts/qcom/lemans.dtsi               | 12 ++++----
 arch/arm64/boot/dts/qcom/monaco-evk.dts            |  4 +--
 .../boot/dts/qcom/msm8996-oneplus-common.dtsi      |  5 +++-
 .../boot/dts/qcom/msm8996-sony-xperia-tone.dtsi    |  7 +++--
 .../arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi |  6 ++--
 arch/arm64/boot/dts/qcom/msm8996.dtsi              | 21 ++++++-------
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  8 ++---
 .../boot/dts/qcom/qcm6490-particle-tachyon.dts     | 15 ++++++----
 arch/arm64/boot/dts/qcom/qcs404-evb.dtsi           |  6 ++--
 arch/arm64/boot/dts/qcom/qcs404.dtsi               |  7 ++---
 arch/arm64/boot/dts/qcom/qcs615-ride.dts           |  8 +++--
 .../boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts     | 16 ++++++----
 .../qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso |  4 +--
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |  4 +--
 .../dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts  | 14 +++++----
 .../boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts | 16 ++++++----
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts          |  4 +--
 arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi       | 16 ++++++----
 arch/arm64/boot/dts/qcom/sa8295p-adp.dts           | 32 ++++++++++++--------
 arch/arm64/boot/dts/qcom/sa8540p-ride.dts          | 16 ++++++----
 arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts     |  6 ++--
 arch/arm64/boot/dts/qcom/sar2130p.dtsi             | 12 ++++----
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi     |  5 +++-
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |  5 +++-
 .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts |  7 +++--
 arch/arm64/boot/dts/qcom/sc8180x-primus.dts        |  7 +++--
 arch/arm64/boot/dts/qcom/sc8180x.dtsi              | 24 +++++++--------
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts          | 24 +++++++++------
 .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts      | 14 +++++----
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 22 ++++++++------
 .../boot/dts/qcom/sc8280xp-microsoft-arcata.dts    | 22 ++++++++------
 .../boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 14 +++++----
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi             | 25 +++++++---------
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts         | 13 ++++++---
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            | 12 +++++---
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 14 ++++-----
 arch/arm64/boot/dts/qcom/sm8150.dtsi               | 21 ++++++-------
 arch/arm64/boot/dts/qcom/sm8250.dtsi               | 34 +++++++++-------------
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts            | 16 ++++++----
 arch/arm64/boot/dts/qcom/sm8350.dtsi               | 14 ++++-----
 arch/arm64/boot/dts/qcom/sm8450.dtsi               | 22 ++++++--------
 arch/arm64/boot/dts/qcom/sm8550-hdk.dts            | 14 +++++----
 arch/arm64/boot/dts/qcom/sm8550-mtp.dts            | 16 ++++++----
 arch/arm64/boot/dts/qcom/sm8550-qrd.dts            |  6 ++--
 arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts    |  7 +++--
 .../dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts    |  8 +++--
 arch/arm64/boot/dts/qcom/sm8550.dtsi               | 12 ++++----
 .../boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts      | 14 +++++----
 arch/arm64/boot/dts/qcom/sm8650-hdk.dts            | 14 +++++----
 arch/arm64/boot/dts/qcom/sm8650-mtp.dts            | 16 ++++++----
 arch/arm64/boot/dts/qcom/sm8650-qrd.dts            |  6 ++--
 arch/arm64/boot/dts/qcom/sm8650.dtsi               | 10 +++----
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts            |  2 +-
 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi        |  8 +++--
 arch/arm64/boot/dts/qcom/talos.dtsi                |  5 ++--
 61 files changed, 420 insertions(+), 333 deletions(-)

---
base-commit: 9716c086c8e8b141d35aa61f2e96a2e83de212a7
change-id: 20260514-wake-1dfbdedcd173

Best regards,

Signature · 1 line
Krishna Chaitanya Chundru <[email protected]>