Skip to content

cgroup/cpuset: Support multiple source/destination cpusets for cpuset_*attach()

Waiman Long cgroups linux-kselftest lkml sashiko-reviews 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest11 patches 7 repliesIn review
  2. v911 patches 13 repliesSuperseded
  3. v811 patches 4 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v79 patches8 repliesSuperseded
v66 patches5 repliesSuperseded
v56 patches10 repliesSuperseded
v46 patches5 repliesSuperseded
v35 patches8 repliesSuperseded
v25 patches7 repliesSuperseded
v14 patches2 repliesSuperseded

Changes in v10 from the cover letter

- Update the commit log of patch 1 to highlight the fact that it can only partially fix the race problem.
- Fix some typos, remove some redundant code and add review tags.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11cgroup/cpuset: Make nr_deadline_tasks an atomic_tkernel/cgroup/cpuset-internal.h kernel/cgroup/cpuset.c+6 -60 replies
2/11cgroup/cpuset: Fix node inconsistencies between cpuset_update_tasks_nodemask() and cpuset_attach()kernel/cgroup/cpuset.c+18 -120 replies
3/11cgroup/cpuset: Prevent race between task attach and cpuset state changekernel/cgroup/cpuset-internal.h kernel/cgroup/cpuset.c+53 -480 replies
4/11cgroup/cpuset: Put all task attach related variables into attach_ctxkernel/cgroup/cpuset.c+10 -110 replies
5/11cgroup/cpuset: Add a cpuset_reserve_dl_bw() helperkernel/cgroup/cpuset.c+24 -180 replies
6/11cgroup/cpuset: Expand the scope of cpuset_can_attach_check()kernel/cgroup/cpuset.c+30 -220 replies
7/11cgroup/cpuset: Make attach_ctx.old_cs track task group leaderkernel/cgroup/cpuset.c+21 -00 replies
8/11cgroup/cpuset: Move mpol_rebind_mm/cpuset_migrate_mm() calls inside cpuset_attach_task()kernel/cgroup/cpuset.c+59 -440 replies
9/11cgroup/cpuset: Support multiple source cpusets for cpuset_*attach()kernel/cgroup/cpuset-internal.h kernel/cgroup/cpuset.c+64 -141 reply
10/11cgroup/cpuset: Support multiple destination cpusets for cpuset_*attach()kernel/cgroup/cpuset-internal.h kernel/cgroup/cpuset.c+72 -445 replies
11/11selftests/cgroup: Add test for cpuset affinity on controller disabletools/testing/selftests/cgroup/test_cpuset.c+243 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchRidong ChenGregory PriceWaiman Long
1/11R-b
2/11R-b R-b
3/11R-b
4/11R-b
5/11R-b R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v10 thread

Cover letter [PATCH-next v10 00/11] cgroup/cpuset: Support multiple source/destination cpusets for cpuset_*attach()

v10:
- Update the commit log of patch 1 to highlight the fact that it can only partially fix the race problem.
- Fix some typos, remove some redundant code and add review tags.

v9: https://lore.kernel.org/lkml/[email protected]
- Drop Farhad's mm mempolicy rebind fix patch as it has been merged to linux-next via the mm tree.
- Add a new patch to make nr_deadline_tasks an atomic_t to prevent data corruption due to concurrent update & adjust some later patches accordingly.
- Add a new wait_attach_done_lock() helper for waiting ongoing task operation as suggested by Ridong.

v8: https://lore.kernel.org/lkml/[email protected]/
- Update patch 3 to make attach_in_progress a global flag which block all cpuset write operations until the attach is done.
- Add a new patch 4 to collect most of the attach related variables into a attach_ctx structure as suggested by Ridong.
- Add a test_cpuset selftest patch contributed by Michal Koutný.
- Keep the existing Reviewed-by tags as there is no functional change to the other patches other than rename of some variables. Also add some new tags.

Sashiko AI review of another cpuset patch had found that cpuset_attach() and cpuset_can_attach() can be passed a cgroup_taskset with tasks migrating from one source cpuset to multiple destination cpusets and vice versa. Further testing of the cpuset code indicates that this is indeed the case when the v2 cpuset controller is enabled or disabled.

Unfortunately, cpuset_attach() and cpuset_can_attach() still assume that there will be one source and one destinaton cpuset which may result in inocrrect behavior.

This patch series is created to fix this issue.

Patch 1 is to fix another nr_deadline_tasks data corruption problem reported by sashiko by making it an atomic_t data type.

Patch 2 is to fix an inconsistency in the way node mask update is being handled in cpuset_update_tasks_nodemask() and cpuset_attach() so that they match each other.

Patch 3 makes any cpuset state change to wait for the completion of the pending cpuset attach operation, if any.

Patch 4 collects task attach related data into a common attach_ctx structure.

Patches 5 and 6 are just preparatory patches to make the remaining patches easier to review.

Patch 7 makes attach_ctx.old_cs track group leader for use by cpuset_migrate_mm().

Patch 8 moves mpol_rebind_mm() and cpuset_migrate_mm() inside cpuset_attach_task() to make CLONE_INTO_CGROUP flag of clone(2) works more like moving task from one cpuset to another one, while also make supporting multiple source and destination cpusets easier.

Patch 9 makes the necessary changes to enable the support of multiple source cpusets by keeping all the source cpusets found during task iterations in a singly linked lists.

Patch 10 enables the support of multiple destination cpusets during the the enabling of cpuset v2 controller.

Patch 11 adds a new test case to test_cpuset to test disabling of cpuset controller.

*** BLURB HERE ***

Michal Koutný (1):
selftests/cgroup: Add test for cpuset affinity on controller disable

Waiman Long (10):
cgroup/cpuset: Make nr_deadline_tasks an atomic_t cgroup/cpuset: Fix node inconsistencies between
cpuset_update_tasks_nodemask() and cpuset_attach()
cgroup/cpuset: Prevent race between task attach and cpuset state
change
cgroup/cpuset: Put all task attach related variables into attach_ctx cgroup/cpuset: Add a cpuset_reserve_dl_bw() helper cgroup/cpuset: Expand the scope of cpuset_can_attach_check() cgroup/cpuset: Make attach_ctx.old_cs track task group leader cgroup/cpuset: Move mpol_rebind_mm/cpuset_migrate_mm() calls inside
cpuset_attach_task()
cgroup/cpuset: Support multiple source cpusets for cpuset_*attach() cgroup/cpuset: Support multiple destination cpusets for
cpuset_*attach()

 kernel/cgroup/cpuset-internal.h              |  13 +-
 kernel/cgroup/cpuset.c                       | 467 ++++++++++++-------
 tools/testing/selftests/cgroup/test_cpuset.c | 243 ++++++++++
 3 files changed, 552 insertions(+), 171 deletions(-)
Signature · 1 line
2.54.0