Clean up bloblist initialization
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 6 repliesIn review
- v13 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- Pick up Raymond's tags on patches 1 and 2
- Correct the logic in the final patch to not break TPL passes SPL a bloblist (at a fixed location), as noticed by Raymond
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | bloblist / handoff: Make this depend on BLOBLIST_FIXEDcommon/ | +1 | 0 replies | |
| 2/3 | bloblist: Demote not finding a bloblist to a debugcommon/ | +2 | 0 replies | |
| 3/3 | bloblist: Rework bloblist_init and bloblist_maybe_initcommon/ common/ include/ +1 more | +96 | 4 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Raymond Mao | Alexander Stein |
|---|---|---|
| Series | T-b | |
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] Clean up bloblist initialization
hEY ALL,
I've been sitting on this series for a bit (as the patch dates imply), and I'm ready to move forward now with it.
This series does a few small but important cleanups to how we check for, and initialize a bloblist. The first thing is that the way things are done today, our HANDOFF code can only work with a fixed bloblist location, so express that requirement in Kconfig. Next, we demote the scary message about "Bloblist at ... not found" to a debug because we most often see that because the bloblist doesn't (and can't) exist yet. Finally, we remove bloblist_maybe_init and split this in to an exists and a real init. This results in practically no growth (between 8 bytes growth to 12 bytes saved, with some outliers saving much more thanks to knowing it's impossible to have been passed a bloblist yet). This also cleans up some of the code around checking for / knowing about a bloblist existing.
Changes in v2:
- Pick up Raymond's tags on patches 1 and 2
- Correct the logic in the final patch to not break TPL passes SPL a bloblist (at a fixed location), as noticed by Raymond
Signature · 1 line
Tom