bpf: Follow-up fixes for stack argument support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 7 repliesIn review
- v22 patches 3 repliesApplied 2/2
- v12 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- v2: https://lore.kernel.org/bpf/[email protected]/
- Add additional fix (fix arg_track_join log, fix exception with outgoing stack arguments, some cleanup, etc.).
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | bpf: Validate outgoing stack args when btf_prepare_func_args failskernel/ | +8 | 0 replies | |
| 2/7 | selftests/bpf: Add test for stack arg read without caller writetools/ tools/ tools/ | +68 | 0 replies | |
| 3/7 | selftests/bpf: Log arg_track_join for stack arg slots in liveness analysistools/ | +3 | 0 replies | |
| 4/7 | bpf: Fix arg_track_join log to use sa prefix for stack arg slotskernel/ tools/ | +4 | 0 replies | |
| 5/7 | bpf: Clean up redundant stack arg checks for non-JITed programskernel/ kernel/ | +2 | 0 replies | |
| 6/7 | bpf,x86: Fix exception unwinding with outgoing stack argumentsarch/ include/ kernel/ +1 more | +12 | 6 replies | |
| 7/7 | selftests/bpf: Add exception tests with stack argumentstools/ tools/ | +120 | 1 reply |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Kumar Kartikeya Dwivedi |
|---|---|
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | A-b |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf-next v3 0/7] bpf: Follow-up fixes for stack argument support
Commit cd59fa185a03 ("bpf: Support stack arguments for BPF functions and kfuncs") added stack argument support for bpf functions and kfuncs. This patch set is to fix various issues related to stack arguments, mainly include:
- Validate outgoing stack args when btf_prepare_func_args fails
- Fix arg_track_join log to use sa prefix for stack arg slots
- Clean up redundant stack arg checks for non-JITed programs
- Fix exception unwinding with outgoing stack arguments
Changelog:
v2 -> v3:
- v2: https://lore.kernel.org/bpf/[email protected]/
- Add additional fix (fix arg_track_join log, fix exception with outgoing stack arguments, some cleanup, etc.).
v1 -> v2:
- v1: https://lore.kernel.org/bpf/[email protected]/
- Remove 'Reported-by: Sashiko <[email protected]>'.
- Add proper fix tag.
Yonghong Song (7):
bpf: Validate outgoing stack args when btf_prepare_func_args fails selftests/bpf: Add test for stack arg read without caller write selftests/bpf: Log arg_track_join for stack arg slots in liveness
analysis
bpf: Fix arg_track_join log to use sa prefix for stack arg slots
bpf: Clean up redundant stack arg checks for non-JITed programs bpf,x86: Fix exception unwinding with outgoing stack arguments selftests/bpf: Add exception tests with stack arguments
arch/x86/net/bpf_jit_comp.c | 9 +- include/linux/bpf.h | 3 +- kernel/bpf/core.c | 2 +- kernel/bpf/fixups.c | 3 +- kernel/bpf/helpers.c | 2 +- kernel/bpf/liveness.c | 4 +- kernel/bpf/verifier.c | 10 +- .../selftests/bpf/prog_tests/exceptions.c | 7 ++ .../bpf/progs/btf__verifier_stack_arg_order.c | 8 ++ .../testing/selftests/bpf/progs/exceptions.c | 113 ++++++++++++++++++ .../selftests/bpf/progs/verifier_stack_arg.c | 8 +- .../bpf/progs/verifier_stack_arg_order.c | 58 +++++++++ 12 files changed, 216 insertions(+), 11 deletions(-)
Signature · 1 line
2.53.0-Meta