perf/x86/intel: Fix inaccurate hard-coded event configurations
Status from this message: The following commit has been merged into the perf/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for ICXarch/ | +43 | 2 replies | |
| 2/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for SPRarch/ | +14 | 2 replies | |
| 3/11 | perf/x86/intel: Update event constraints for DMRarch/ | +8 | 1 reply | |
| 4/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for ADLarch/ arch/ | +131 | 2 replies | |
| 5/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for MTLarch/ arch/ arch/ | +34 | 0 replies | |
| 6/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for LNLarch/ arch/ | +59 | 0 replies | |
| 7/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for ARLarch/ | +48 | 1 reply | |
| 8/11 | perf/x86/intel: Update event constraints for PTLarch/ arch/ arch/ | +25 | 0 replies | |
| 9/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for NVLarch/ arch/ arch/ | +36 | 0 replies | |
| 10/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for SRFarch/ | +1 | 2 replies | |
| 11/11 | perf/x86/intel: Update event constraints and cache_extra_regs[] for CWFarch/ | +29 | 0 replies |
Reviews trailers per patch
3 of 11 patches have a Reviewed-by or Acked-by.
| Patch | [email protected] |
|---|---|
| 1/11 | R-b |
| 2/11 | |
| 3/11 | R-b |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | R-b |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] perf/x86/intel: Fix inaccurate hard-coded event configurations
Currently, the Intel perf code defines several hard-coded event configurations for each platform. These configurations include event constraints, extra MSR settings, and predefined extra MSR values for certain cache events.
For example, the following five hard-coded event configurations are defined for Sapphire Rapids:
- intel_glc_event_constraints[]: Non-PEBS event constraints.
- intel_glc_pebs_event_constraints[]: PEBS event constraints.
- intel_glc_extra_regs[]: Event-to-extra MSR mapping for events requiring extra MSR access.
- glc_hw_cache_event_ids[]: Cache event IDs.
- glc_hw_cache_extra_regs[]: Extra MSR values for L3 and node events, mainly for OCR/OMR events.
However, these hard-coded configurations can become outdated or incorrect as perfmon events are continuously updated
(see: https://github.com/intel/perfmon). This can result in events being scheduled on incorrect hardware counters, leading to inaccurate counts, especially for legacy cache events such as llc-load-misses and llc-store-misses. While these legacy events are less commonly used since the introduction of JSON-based cache events, it is still important to keep them accurate.
This patchset addresses all identified mismatches on mainstream platforms, including server platforms (ICX, SPR, EMR, GNR, DMR, SRF, and CWF) and client platforms (ADL, MTL, LNL, ARL, PTL, and NVL).
Note: Due to issues in the 7.1-rc2 release that cause boot-up hangs on Intel hybrid platforms, this patchset was developed and tested against the 7.0 release.
Testing:
All tests below were run on the platforms mentioned above, with no issues found:
1. Perf counting test:
$perf test 114
2. Perf sampling test:
$perf test 148
3. Legacy LLC cache events counting test:
$perf stat -e llc-loads,llc-load-misses,llc-stores,llc-store-misses -a
Dapeng Mi (11):
perf/x86/intel: Update event constraints and cache_extra_regs[] for
ICX
perf/x86/intel: Update event constraints and cache_extra_regs[] for
SPR
perf/x86/intel: Update event constraints for DMR perf/x86/intel: Update event constraints and cache_extra_regs[] for
ADL
perf/x86/intel: Update event constraints and cache_extra_regs[] for
MTL
perf/x86/intel: Update event constraints and cache_extra_regs[] for
LNL
perf/x86/intel: Update event constraints and cache_extra_regs[] for
ARL
perf/x86/intel: Update event constraints for PTL perf/x86/intel: Update event constraints and cache_extra_regs[] for
NVL
perf/x86/intel: Update event constraints and cache_extra_regs[] for
SRF
perf/x86/intel: Update event constraints and cache_extra_regs[] for
CWF
arch/x86/events/intel/core.c | 476 +++++++++++++++++++++++++++++------ arch/x86/events/intel/ds.c | 23 +- arch/x86/events/perf_event.h | 4 +- 3 files changed, 421 insertions(+), 82 deletions(-)
base-commit: 028ef9c96e96197026887c0f092424679298aae8
Signature · 1 line
2.34.1