Skip to content

ASoC: cs35l56: Replace open-coded SoundWire regmap with generic regmap-sdw

Richard Fitzgerald linux-sound lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v33 patches 1 replySuperseded
  3. v22 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches1 replySuperseded

Changes in v4 from the cover letter

- In patch #1 moved dereference of regmap_config after it has been checked for not-NULL.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: cs35l56-shared-test: Subtract reg_base offset in dummy regmapsound/soc/codecs/cs35l56-shared-test.c+6 -00 replies
2/3ASoC: cs35l56: Use reg_base to offset addresses on SoundWiresound/soc/codecs/cs35l56-sdw.c sound/soc/codecs/cs35l56-shared.c+3 -60 replies
3/3ASoC: cs35l56: Use standard SoundWire regmap implementationsound/soc/codecs/Kconfig sound/soc/codecs/cs35l56-sdw.c sound/soc/codecs/cs35l56.h+51 -840 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] ASoC: cs35l56: Replace open-coded SoundWire regmap with generic regmap-sdw

This series replaces the entirely custom SoundWire regmap with the generic regmap-sdw. The reasons for doing this are:

- Avoid code duplication
- Avoid effort of keeping custom implementation up-to-date
- Prepare for supporting BRA

Changes in V4:
- In patch #1 moved dereference of regmap_config after it has been checked for not-NULL.

Changes in V3:
- Change cs35l56-shared-test KUnit test to handle the offset addresses passed into its mock regmap bus.

Changes in V2:
- Select REGMAP_SOUNDWIRE

Richard Fitzgerald (3):
ASoC: cs35l56-shared-test: Subtract reg_base offset in dummy regmap
ASoC: cs35l56: Use reg_base to offset addresses on SoundWire
ASoC: cs35l56: Use standard SoundWire regmap implementation

 sound/soc/codecs/Kconfig               |   2 +-
 sound/soc/codecs/cs35l56-sdw.c         | 137 +++++++++----------------
 sound/soc/codecs/cs35l56-shared-test.c |   6 ++
 sound/soc/codecs/cs35l56-shared.c      |   2 +
 sound/soc/codecs/cs35l56.h             |   1 +
 5 files changed, 59 insertions(+), 89 deletions(-)
Signature · 1 line
2.47.3