Don't whitelist OA registers unconditionally
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 4 repliesIn review
- v29 patches 9 repliesSuperseded
- v19 patches 22 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelistsdrivers/ | +5 | 0 replies | |
| 2/9 | drm/xe/rtp: Maintain OA whitelists separatelydrivers/ drivers/ drivers/ +1 more | +18 | 0 replies | |
| 3/9 | drm/xe/rtp: Keep track of non-OA nonpriv slotsdrivers/ | +5 | 0 replies | |
| 4/9 | drm/xe/rtp: Generalize whitelist_apply_to_hwedrivers/ | +6 | 0 replies | |
| 5/9 | drm/xe/rtp: Save OA nonpriv registers to register save/restore listsdrivers/ | +12 | 0 replies | |
| 6/9 | drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regsdrivers/ | +15 | 0 replies | |
| 7/9 | drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gtdrivers/ drivers/ | +35 | 0 replies | |
| 8/9 | drm/xe/oa: (De-)whitelist OA registers on OA stream open/releasedrivers/ | +7 | 0 replies | |
| 9/9 | drm/xe/rtp: Ensure locking/ref counting for OA whitelistsdrivers/ drivers/ | +12 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Umesh Nerlige Ramappa |
|---|---|
| 1/9 | R-b |
| 2/9 | R-b |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | R-b |
| 6/9 | R-b |
| 7/9 | R-b |
| 8/9 | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] Don't whitelist OA registers unconditionally
Whitelisting OA registers unconditionally is a security violation. In this series we resolve this issue as follows:
* Set the 'deny' bit (bit 30) for all OA registers, ensuring OA registers are not whitelisted by default after probe/reset/restart
* Reset the 'deny' bit when an OA stream is opened and certain conditions are met, whitelisting OA registers only for the duration when OA streams are open for a gt
* Set the 'deny' bit again, when OA streams are closed
* To manage this scheme, separate out OA whitelists from non-OA whitelists (into separate save-restore lists)
v2: Address code review from Umesh. Patches changed in v2 have changelog
appended to commit message
v3: Minor change to Patch 3
Ashutosh Dixit (9):
drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelists drm/xe/rtp: Maintain OA whitelists separately
drm/xe/rtp: Keep track of non-OA nonpriv slots drm/xe/rtp: Generalize whitelist_apply_to_hwe
drm/xe/rtp: Save OA nonpriv registers to register save/restore lists drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regs drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gt drm/xe/oa: (De-)whitelist OA registers on OA stream open/release drm/xe/rtp: Ensure locking/ref counting for OA whitelists
drivers/gpu/drm/xe/xe_gt_debugfs.c | 4 +- drivers/gpu/drm/xe/xe_hw_engine.c | 2 + drivers/gpu/drm/xe/xe_hw_engine_types.h | 8 +++ drivers/gpu/drm/xe/xe_oa.c | 7 ++ drivers/gpu/drm/xe/xe_oa_types.h | 3 + drivers/gpu/drm/xe/xe_reg_whitelist.c | 93 ++++++++++++++++++++++--- drivers/gpu/drm/xe/xe_reg_whitelist.h | 4 ++ 7 files changed, 112 insertions(+), 9 deletions(-)
Signature · 1 line
2.54.0