Skip to content

Enable CMRR in fixed-RR VRR path

Mitul Golani intel-gfx intel-xe 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest posting 2/210 patches 3 repliesIn review
  2. v8 posting 1/21 of 10 patches 1 replySuperseded
  3. v710 patches 5 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v69 patches13 repliesSuperseded
v59 patches0 repliesSuperseded
v49 patches0 repliesSuperseded
v38 patches18 repliesSuperseded
v211 patches15 repliesSuperseded
v18 patches3 repliesSuperseded

Patches in v8 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915/psr: Do not enable PSR2 when CMRR is enableddrivers/gpu/drm/i915/display/intel_psr.c+6 -00 replies
2/10drm/i915/vrr: Restrict CMRR enable condition to VRR-TG-default platformsdrivers/gpu/drm/i915/display/intel_vrr.c+9 -30 replies
3/10drm/i915/vrr: Add per-CRTC vrr/cmrr debugfs controldrivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_vrr.c +1 more+121 -00 replies
4/10drm/i915/vrr: Update AS_SDP target_rr_divider based on CMRR config requestdrivers/gpu/drm/i915/display/intel_dp.c+6 -10 replies
5/10drm/i915/display: Move CMRR crtc_state members under VRRdrivers/gpu/drm/i915/display/intel_cmtg.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h +3 more+29 -290 replies
6/10drm/i915/vrr: Compute CMRR fractional timings genericallydrivers/gpu/drm/i915/display/intel_vrr.c+70 -650 replies
7/10drm/i915/vrr: Latch CMRR ratio via atomic commit on debugfs writedrivers/gpu/drm/i915/display/intel_vrr.c+77 -01 reply
8/10drm/i915/vrr: Program CMRR enable/disable from transcoder timingsdrivers/gpu/drm/i915/display/intel_vrr.c+40 -190 replies
9/10drm/i915/vrr: Dump CMRR state in the crtc state dumpdrivers/gpu/drm/i915/display/intel_crtc_state_dump.c+3 -00 replies
10/10drm/i915/vrr: Enable cmrrdrivers/gpu/drm/i915/display/intel_vrr.c+2 -01 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchChaitanya Kumar Borah
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 00/10] Enable CMRR in fixed-RR VRR path

The existing CMRR fractional-timing code was permanently disabled (if (!HAS_CMRR || true)), eDP-only, and relied on a heuristic to guess when the fractional path was needed. This series reworks it into a generic, debugfs-driven feature, which later will be controlled via userspace when respective uapi will be in-palce.

Mitul Golani (10):
drm/i915/psr: Do not enable PSR2 when CMRR is enabled drm/i915/vrr: Restrict CMRR enable condition to VRR-TG-default
platforms
drm/i915/vrr: Add per-CRTC vrr/cmrr debugfs control drm/i915/vrr: Update AS_SDP target_rr_divider based on CMRR config
request
drm/i915/display: Move CMRR crtc_state members under VRR drm/i915/vrr: Compute CMRR fractional timings generically drm/i915/vrr: Latch CMRR ratio via atomic commit on debugfs write drm/i915/vrr: Program CMRR enable/disable from transcoder timings drm/i915/vrr: Dump CMRR state in the crtc state dump drm/i915/vrr: Enable cmrr

 drivers/gpu/drm/i915/display/intel_cmtg.c     |   2 +-
 .../drm/i915/display/intel_crtc_state_dump.c  |   3 +
 drivers/gpu/drm/i915/display/intel_display.c  |  10 +-
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |  17 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |   9 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   6 +
 drivers/gpu/drm/i915/display/intel_vrr.c      | 393 ++++++++++++++----
 drivers/gpu/drm/i915/display/intel_vrr.h      |   2 +
 9 files changed, 345 insertions(+), 99 deletions(-)
Signature · 1 line
2.48.1