Skip to content

mfd: Use named initializers for arrays of *_device_data

Uwe Kleine-König (The Capable Hub) asahi chrome-platform imx linux-amlogic linux-arm-kernel linux-arm-msm linux-crypto linux-mediatek linux-omap linux-renesas-soc linux-samsung-soc linux-sound linux-sunxi lkml mfd 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 posting 2/22 patches 0 repliesNew
  2. v4 Latest20 patches 9 repliesIn review
  3. v3 posting 1/22 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/23 patches3 repliesApplied
v2 posting 1/21 patch2 repliesApplied
v11 patch1 replyApplied 1/1

Changes in v4 from the cover letter

(https://lore.kernel.org/[email protected]):

- Rebase to v7.4-rc1
- add various R-b tags
- Fix a bug in patch 3 found by sashiko where I accidentally deleted a
* in sizeof(*pdata).
- Drop patches about spi_device_id that were sent separately initially and applied in the meantime

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locallydrivers/mfd/bcm2835-pm.c include/linux/mfd/bcm2835-pm.h+9 -91 reply
2/20mfd: bcm2835-pm: Drop unused headerinclude/linux/mfd/bcm2835-pm.h+0 -20 replies
3/20mfd: kempld: Simplify device abstractiondrivers/mfd/kempld-core.c include/linux/mfd/kempld.h+16 -600 replies
4/20mfd: lp87565: Explicitly set driver data for the generic dt compatibledrivers/mfd/lp87565.c+4 -10 replies
5/20mfd: mt6360: Drop irrelevant __maybe_unuseddrivers/mfd/mt6360-core.c+1 -10 replies
6/20mfd: rt4831: Drop irrelevant __maybe_unuseddrivers/mfd/rt4831.c+1 -10 replies
7/20mfd: loongson-se: Drop unused assignment of acpi_device_id driver datadrivers/mfd/loongson-se.c+1 -10 replies
8/20mfd: Drop unused assignment of i2c_device_id driver datadrivers/mfd/as3711.c drivers/mfd/rc5t583.c+2 -20 replies
9/20mfd: Drop unused assignment of platform_device_id driver datadrivers/mfd/cros_ec_dev.c drivers/mfd/mt6397-core.c+2 -21 reply
10/20mfd: Use named initializers for acpi_device_id arraysdrivers/mfd/cs42l43-i2c.c drivers/mfd/intel-lpss-acpi.c drivers/mfd/intel_pmc_bxt.c +8 more+43 -433 replies
11/20mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id arraydrivers/mfd/intel-m10-bmc-pmci.c+1 -10 replies
12/20mfd: Use named initializers for arrays of i2c_device_iddrivers/mfd/88pm800.c drivers/mfd/88pm805.c drivers/mfd/88pm860x-core.c +62 more+162 -1620 replies
13/20mfd: twl6030: Use named initializers for of_device_iddrivers/mfd/twl6030-irq.c+2 -20 replies
14/20mfd: Use PCI_DEVICE* macros to initialize pci_device_id arraysdrivers/mfd/ioc3.c drivers/mfd/janz-cmodio.c+7 -70 replies
15/20mfd: Use named initializers for platform_device_id arraydrivers/mfd/ab8500-core.c drivers/mfd/cros_ec_dev.c drivers/mfd/mt6397-core.c+7 -71 reply
16/20mfd: Unify style of acpi_device_id arraysdrivers/mfd/axp20x-i2c.c drivers/mfd/cs42l43-i2c.c drivers/mfd/intel_soc_pmic_chtdc_ti.c +4 more+7 -70 replies
17/20mfd: Unify style of dmi_system_id arraysdrivers/mfd/cgbc-core.c drivers/mfd/intel_quark_i2c_gpio.c drivers/mfd/kempld-core.c +1 more+4 -40 replies
18/20mfd: Unify style of i2c_device_id arraysdrivers/mfd/88pm800.c drivers/mfd/88pm805.c drivers/mfd/88pm860x-core.c +16 more+22 -220 replies
19/20mfd: Unify style of of_device_id arraysdrivers/mfd/88pm860x-core.c drivers/mfd/ab8500-sysctrl.c drivers/mfd/ac100.c +97 more+185 -1843 replies
20/20mfd: Unify style of pci_device_id arraysdrivers/mfd/cs5535-mfd.c drivers/mfd/intel_quark_i2c_gpio.c drivers/mfd/ioc3.c +6 more+10 -100 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijCharles KeepaxAndré DraszikAndy ShevchenkoGeert UytterhoevenMathieu Dubois-BriandBenson LeungChen-Yu TsaiLuca CeresoliMatti Vaittinen
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b R-b
10/20R-b R-b
11/20R-b
12/20R-b R-b R-b
13/20R-b
14/20R-b
15/20R-b R-b
16/20R-b R-b R-b
17/20R-b
18/20R-b R-b
19/20R-b R-b R-b R-b R-b A-b R-b R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data

Hello,

the objective for this series is to prepare mfd for changing of_device_id and the others to make driver_data a union, see
https://lore.kernel.org/all/[email protected]/
for the idea behind it.

Changes since v3
(https://lore.kernel.org/[email protected]):

- Rebase to v7.4-rc1
- add various R-b tags
- Fix a bug in patch 3 found by sashiko where I accidentally deleted a
* in sizeof(*pdata).
- Drop patches about spi_device_id that were sent separately initially and applied in the meantime

These patches are a pain to track and forward port and they are mostly orthogonal, so I'm happy about a partial application of this series if only some patches are considered ready.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (20):
mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used
locally
mfd: bcm2835-pm: Drop unused header
mfd: kempld: Simplify device abstraction
mfd: lp87565: Explicitly set driver data for the generic dt compatible
mfd: mt6360: Drop irrelevant __maybe_unused
mfd: rt4831: Drop irrelevant __maybe_unused
mfd: loongson-se: Drop unused assignment of acpi_device_id driver data
mfd: Drop unused assignment of i2c_device_id driver data
mfd: Drop unused assignment of platform_device_id driver data
mfd: Use named initializers for acpi_device_id arrays
mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id
array
mfd: Use named initializers for arrays of i2c_device_id
mfd: twl6030: Use named initializers for of_device_id
mfd: Use PCI_DEVICE* macros to initialize pci_device_id arrays
mfd: Use named initializers for platform_device_id array
mfd: Unify style of acpi_device_id arrays
mfd: Unify style of dmi_system_id arrays
mfd: Unify style of i2c_device_id arrays
mfd: Unify style of of_device_id arrays
mfd: Unify style of pci_device_id arrays

 drivers/mfd/88pm800.c                 |  4 +-
 drivers/mfd/88pm805.c                 |  4 +-
 drivers/mfd/88pm860x-core.c           |  8 ++--
 drivers/mfd/aat2870-core.c            |  2 +-
 drivers/mfd/ab8500-core.c             |  8 ++--
 drivers/mfd/ab8500-sysctrl.c          |  4 +-
 drivers/mfd/ac100.c                   |  2 +-
 drivers/mfd/act8945a.c                |  8 ++--
 drivers/mfd/adp5520.c                 |  4 +-
 drivers/mfd/altera-a10sr.c            |  2 +-
 drivers/mfd/altera-sysmgr.c           |  2 +-
 drivers/mfd/arizona-i2c.c             | 14 +++---
 drivers/mfd/arizona-spi.c             |  2 +-
 drivers/mfd/as3711.c                  |  8 ++--
 drivers/mfd/as3722.c                  |  8 ++--
 drivers/mfd/atmel-hlcdc.c             |  2 +-
 drivers/mfd/atmel-smc.c               |  2 +-
 drivers/mfd/axp20x-i2c.c              | 26 +++++-----
 drivers/mfd/axp20x-rsb.c              |  2 +-
 drivers/mfd/bcm2835-pm.c              | 15 ++++--
 drivers/mfd/bcm590xx.c                |  4 +-
 drivers/mfd/bd9571mwv.c               |  6 +--
 drivers/mfd/bq257xx.c                 |  8 ++--
 drivers/mfd/cgbc-core.c               |  2 +-
 drivers/mfd/cros_ec_dev.c             |  2 +-
 drivers/mfd/cs40l50-i2c.c             |  6 +--
 drivers/mfd/cs40l50-spi.c             |  2 +-
 drivers/mfd/cs42l43-i2c.c             | 10 ++--
 drivers/mfd/cs5535-mfd.c              |  2 +-
 drivers/mfd/da903x.c                  |  6 +--
 drivers/mfd/da9052-i2c.c              | 12 ++---
 drivers/mfd/da9055-i2c.c              |  4 +-
 drivers/mfd/da9062-core.c             |  4 +-
 drivers/mfd/da9063-i2c.c              | 11 +++--
 drivers/mfd/da9150-core.c             |  4 +-
 drivers/mfd/db8500-prcmu.c            |  4 +-
 drivers/mfd/exynos-lpass.c            |  2 +-
 drivers/mfd/gateworks-gsc.c           |  2 +-
 drivers/mfd/hi6421-pmic-core.c        |  6 +--
 drivers/mfd/hi655x-pmic.c             |  4 +-
 drivers/mfd/intel-lpss-acpi.c         | 58 +++++++++++------------
 drivers/mfd/intel-m10-bmc-pmci.c      |  2 +-
 drivers/mfd/intel_pmc_bxt.c           |  2 +-
 drivers/mfd/intel_quark_i2c_gpio.c    |  6 +--
 drivers/mfd/intel_soc_pmic_bxtwc.c    |  2 +-
 drivers/mfd/intel_soc_pmic_chtdc_ti.c |  4 +-
 drivers/mfd/intel_soc_pmic_chtwc.c    |  2 +-
 drivers/mfd/intel_soc_pmic_crc.c      |  6 +--
 drivers/mfd/intel_soc_pmic_mrfld.c    |  4 +-
 drivers/mfd/ioc3.c                    |  4 +-
 drivers/mfd/janz-cmodio.c             | 14 +++---
 drivers/mfd/kempld-core.c             | 68 +++++++--------------------
 drivers/mfd/khadas-mcu.c              |  2 +-
 drivers/mfd/lm3533-core.c             |  2 +-
 drivers/mfd/lochnagar-i2c.c           |  2 +-
 drivers/mfd/loongson-se.c             |  2 +-
 drivers/mfd/lp3943.c                  |  4 +-
 drivers/mfd/lp873x.c                  |  8 ++--
 drivers/mfd/lp87565.c                 |  9 ++--
 drivers/mfd/lp8788.c                  |  2 +-
 drivers/mfd/lpc_ich.c                 |  2 +-
 drivers/mfd/macsmc.c                  |  2 +-
 drivers/mfd/madera-core.c             |  2 +-
 drivers/mfd/madera-i2c.c              | 18 +++----
 drivers/mfd/max14577.c                |  6 +--
 drivers/mfd/max7360.c                 |  2 +-
 drivers/mfd/max77541.c                |  4 +-
 drivers/mfd/max77620.c                |  8 ++--
 drivers/mfd/max77686.c                |  2 +-
 drivers/mfd/max77693.c                |  4 +-
 drivers/mfd/max77714.c                |  2 +-
 drivers/mfd/max77759.c                |  4 +-
 drivers/mfd/max77843.c                |  8 ++--
 drivers/mfd/max8907.c                 |  6 +--
 drivers/mfd/max8925-i2c.c             |  6 +--
 drivers/mfd/max8997.c                 |  6 +--
 drivers/mfd/max8998.c                 |  6 +--
 drivers/mfd/mc13xxx-spi.c             |  6 +--
 drivers/mfd/menelaus.c                |  2 +-
 drivers/mfd/menf21bmc.c               |  2 +-
 drivers/mfd/mp2629.c                  |  2 +-
 drivers/mfd/mt6360-core.c             |  6 +--
 drivers/mfd/mt6370.c                  |  2 +-
 drivers/mfd/mt6397-core.c             |  4 +-
 drivers/mfd/mxs-lradc.c               |  4 +-
 drivers/mfd/ntxec.c                   |  4 +-
 drivers/mfd/omap-usb-host.c           |  4 +-
 drivers/mfd/palmas.c                  |  8 ++--
 drivers/mfd/pf1550.c                  |  2 +-
 drivers/mfd/qcom-pm8008.c             |  4 +-
 drivers/mfd/qcom-pm8xxx.c             |  6 +--
 drivers/mfd/rave-sp.c                 |  4 +-
 drivers/mfd/rc5t583.c                 |  4 +-
 drivers/mfd/rdc321x-southbridge.c     |  2 +-
 drivers/mfd/retu-mfd.c                |  4 +-
 drivers/mfd/rk8xx-i2c.c               |  2 +-
 drivers/mfd/rk8xx-spi.c               |  2 +-
 drivers/mfd/rohm-bd71828.c            |  4 +-
 drivers/mfd/rohm-bd9576.c             |  6 +--
 drivers/mfd/rsmu_i2c.c                | 18 +++----
 drivers/mfd/rsmu_spi.c                |  2 +-
 drivers/mfd/rt4831.c                  |  6 +--
 drivers/mfd/rt5033.c                  |  4 +-
 drivers/mfd/rt5120.c                  |  2 +-
 drivers/mfd/rz-mtu3.c                 |  2 +-
 drivers/mfd/sec-acpm.c                |  6 +--
 drivers/mfd/sec-i2c.c                 | 22 ++++-----
 drivers/mfd/si476x-i2c.c              |  8 ++--
 drivers/mfd/simple-mfd-i2c.c          |  2 +-
 drivers/mfd/sky81452.c                |  4 +-
 drivers/mfd/sm501.c                   |  4 +-
 drivers/mfd/smpro-core.c              |  2 +-
 drivers/mfd/sprd-sc27xx-spi.c         |  2 +-
 drivers/mfd/ssbi.c                    |  2 +-
 drivers/mfd/stm32-lptimer.c           |  4 +-
 drivers/mfd/stm32-timers.c            |  4 +-
 drivers/mfd/stmfx.c                   |  4 +-
 drivers/mfd/stmpe-i2c.c               | 34 +++++++-------
 drivers/mfd/stmpe-spi.c               | 14 +++---
 drivers/mfd/stpmic1.c                 |  4 +-
 drivers/mfd/stw481x.c                 |  8 ++--
 drivers/mfd/sun6i-prcm.c              |  2 +-
 drivers/mfd/tc3589x.c                 | 14 +++---
 drivers/mfd/ti-lmu.c                  | 10 ++--
 drivers/mfd/timberdale.c              |  2 +-
 drivers/mfd/tps6105x.c                |  6 +--
 drivers/mfd/tps65010.c                | 10 ++--
 drivers/mfd/tps6507x.c                |  6 +--
 drivers/mfd/tps65086.c                |  4 +-
 drivers/mfd/tps65090.c                |  6 +--
 drivers/mfd/tps65217.c                |  6 +--
 drivers/mfd/tps65218.c                |  8 ++--
 drivers/mfd/tps65219.c                |  8 ++--
 drivers/mfd/tps6586x.c                |  6 +--
 drivers/mfd/tps65910.c                | 12 ++---
 drivers/mfd/tps65912-i2c.c            |  4 +-
 drivers/mfd/tps65912-spi.c            |  2 +-
 drivers/mfd/tps6594-i2c.c             | 12 ++---
 drivers/mfd/tps6594-spi.c             | 12 ++---
 drivers/mfd/tqmx86.c                  |  2 +-
 drivers/mfd/twl-core.c                | 22 ++++-----
 drivers/mfd/twl4030-audio.c           |  4 +-
 drivers/mfd/twl4030-power.c           |  2 +-
 drivers/mfd/twl6030-irq.c             |  6 +--
 drivers/mfd/twl6040.c                 |  4 +-
 drivers/mfd/upboard-fpga.c            |  6 +--
 drivers/mfd/vexpress-sysreg.c         |  4 +-
 drivers/mfd/vx855.c                   |  2 +-
 drivers/mfd/wm831x-core.c             |  2 +-
 drivers/mfd/wm831x-i2c.c              | 14 +++---
 drivers/mfd/wm8350-i2c.c              |  6 +--
 drivers/mfd/wm8400-core.c             |  4 +-
 drivers/mfd/wm8994-core.c             |  8 ++--
 include/linux/mfd/bcm2835-pm.h        |  9 ----
 include/linux/mfd/kempld.h            | 12 -----
 155 files changed, 478 insertions(+), 520 deletions(-)

base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4

Signature · 1 line
2.56.0.rc1