Skip to content

selftests/bpf: XDP LB benchmark fixes

Puranjay Mohan bpf 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesApplied 3/3
  2. v14 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Drop patch 3 as it was fixing a situation that can never happen in practice.
- Replace | 1 logic in patch 1 with replacing ^ operator with +

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3selftests/bpf: Fix cold_lru producing zero batch_hash in XDP LB benchmarktools/testing/selftests/bpf/progs/xdp_lb_bench.c+1 -10 repliesApplied
2/3selftests/bpf: Fix expired UDP LRU entries in XDP LB benchmarktools/testing/selftests/bpf/benchs/bench_xdp_lb.c+11 -00 repliesApplied
3/3selftests/bpf: Filter timing outliers with IQR in batch-timing librarytools/testing/selftests/bpf/benchs/bench_bpf_timing.c+26 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/3] selftests/bpf: XDP LB benchmark fixes

Changelog:
v1: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Drop patch 3 as it was fixing a situation that can never happen in practice.
- Replace | 1 logic in patch 1 with replacing ^ operator with +

Three bug fixes and one improvement for the XDP LB and batch-timing benchmarks.

The cold_lru validation was failing a lot because batch_hash could compute to zero when batch_gen matched the CPU id. Similarly, pre-populated UDP LRU entries had atime=0 so they'd expire immediately on any CPU that calibration didn't warm. Both are fixed in patches 1-2.

Patch 3 adds IQR outlier filtering to the timing stats to stabilize scenarios with high stddev.

Puranjay Mohan (3):
selftests/bpf: Fix cold_lru producing zero batch_hash in XDP LB
benchmark
selftests/bpf: Fix expired UDP LRU entries in XDP LB benchmark selftests/bpf: Filter timing outliers with IQR in batch-timing library

 .../selftests/bpf/benchs/bench_bpf_timing.c   | 26 +++++++++++++++++++
 .../selftests/bpf/benchs/bench_xdp_lb.c       | 11 ++++++++
 .../selftests/bpf/progs/xdp_lb_bench.c        |  2 +-
 3 files changed, 38 insertions(+), 1 deletion(-)
Signature · 1 line
2.53.0-Meta