Skip to content

RFC target/ppc: Moving instructions to decodetree specification

Chinmay Rath qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest28 patches 37 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28target/ppc: Migrate extswsli to decodetreetarget/ppc/insn32.decode target/ppc/translate.c+23 -280 replies
2/28target/ppc: Migrate atomic loads to decodetreetarget/ppc/insn32.decode target/ppc/translate.c+87 -622 replies
3/28target/ppc: Convert cache instructions to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/mem_helper.c +1 more+288 -2378 replies
4/28target/ppc: Move vector merge instructions to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+40 -241 reply
5/28target/ppc: Move vector pack instructions to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+81 -531 reply
6/28target/ppc: Move st{b, h, w, d, q}cx instructions to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+92 -1031 reply
7/28target/ppc: convert slw, srw instruction via decode spectarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+54 -490 replies
8/28target/ppc: convert sraw[i] instruction via decode spectarget/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+47 -460 replies
9/28target/ppc : Convert mcrf to decode treetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/misc-impl.c.inc+12 -71 reply
10/28target/ppc: Move fixed-point Shift insns to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+81 -1020 replies
11/28target/ppc: Move fixed-point byte-reversal store insns to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+95 -444 replies
12/28target/ppc: Move GPR atomic load/store instructions to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+222 -2121 reply
13/28target/ppc: Move isync instruction to decodetree.target/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/storage-ctrl-impl.c.inc+18 -151 reply
14/28target/ppc: Convert b{a, l, la} to decode treetarget/ppc/insn32.decode target/ppc/internal.h target/ppc/translate.c +1 more+31 -311 reply
15/28target/ppc: move various conditional branch insns to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/branch-impl.c.inc+170 -1484 replies
16/28target/ppc: Fix TRANS* macro variadic arguments handlingtarget/ppc/translate.c+5 -50 replies
17/28target/ppc: Move wait instruction to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/storage-ctrl-impl.c.inc+115 -910 replies
18/28target/ppc: Move sleep & friends to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/processor-ctrl-impl.c.inc+109 -852 replies
19/28target/ppc: Refactor sleep and its variants to use a common helpertarget/ppc/helper.h target/ppc/tcg-excp_helper.c target/ppc/translate/processor-ctrl-impl.c.inc+16 -870 replies
20/28target/ppc: Move Condition Register access instructions to decodetree.target/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+87 -620 replies
21/28target/ppc: Move Condition Register logical instructions to decodetree.target/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+56 -590 replies
22/28target/ppc: Move Fixed-Point Load/Store String instructions to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/mem_helper.c +2 more+116 -1087 replies
23/28target/ppc: Move VMX integer arithmetic and BCD instructions to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+200 -2094 replies
24/28target/ppc: Move rlwimi, rlwinm instructions to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+104 -1060 replies
25/28target/ppc: Move lmw, stmw instructions to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/mem_helper.c +2 more+39 -430 replies
26/28target/ppc: Move mfmsr, mtmsr[d] instructions to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/misc-impl.c.inc+69 -970 replies
27/28target/ppc: Move byte-reverse instructions to decodetreetarget/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+45 -350 replies
28/28target/ppc: Move system call and rfi instructions to decodetreetarget/ppc/helper.h target/ppc/insn32.decode target/ppc/tcg-excp_helper.c +2 more+144 -1270 replies

Reviews trailers per patch

7 of 28 patches have a Reviewed-by or Acked-by.

PatchShivang UpadhyayNikhil Kumar SinghTasmiya Nalatwad
1/28
2/28
3/28R-b T-b
4/28R-b
5/28R-b
6/28R-b
7/28
8/28
9/28
10/28
11/28
12/28R-b
13/28R-b
14/28R-b
15/28
16/28
17/28
18/28
19/28
20/28
21/28
22/28
23/28
24/28
25/28
26/28
27/28
28/28

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC PATCH 00/28] target/ppc: Moving instructions to decodetree specification

We recently had a QEMU decodetree hackathon at our org focusing on moving instructions to decodetree specification. I have consolidated the patches generated out of this effort in this series. Though I have done a round of review on all of them, might share some more review comments later.

The checkpatch.pl script emits false error for a couple of patches which are of the following nature :

TRANS(STWAT, do_st_atomic, DEF_MEMOP(MO_UL))

static bool trans_LDAT(DisasContext *ctx, arg_LDAT *a)

                                                    ^

I see this happening in the last pointer argument in function definitions after macros (like TRANS(..) in this case).

Richard, Peter, Stefan,
Could you please advise if it would be okay to have the above false positive in the patches ?

Gitlab CI: https://gitlab.com/rathc/qemu/-/pipelines/2540725424
Please note that check-python-tox and migration-compat-aarch64 from CI fails in the upstream master branch as seen in the following:
https://gitlab.com/rathc/qemu/-/pipelines/2537246569

Thanks,
Chinmay

Aboorva Devarajan (3):
target/ppc: Move vector merge instructions to decodetree target/ppc: Move vector pack instructions to decodetree target/ppc: Move GPR atomic load/store instructions to decodetree

Amit Machhiwal (2):
target/ppc: Move fixed-point Shift insns to decodetree target/ppc: Move fixed-point byte-reversal store insns to decodetree

Mukesh Kumar Chaurasiya (IBM) (2):
target/ppc: convert slw,srw instruction via decode spec target/ppc: convert sraw[i] instruction via decode spec

Nikhil Kumar Singh (3):
target/ppc: Migrate extswsli to decodetree target/ppc: Migrate atomic loads to decodetree target/ppc: Convert cache instructions to decodetree

Ojaswin Mujoo (7):
target/ppc: Move isync instruction to decodetree. target/ppc: Convert b{a, l, la} to decode tree target/ppc: move various conditional branch insns to decodetree target/ppc: Fix TRANS* macro variadic arguments handling target/ppc: Move wait instruction to decodetree target/ppc: Move sleep & friends to decodetree target/ppc: Refactor sleep and its variants to use a common helper

Shivang Upadhyay (4):
target/ppc: Move Condition Register access instructions to decodetree. target/ppc: Move Condition Register logical instructions to
decodetree.
target/ppc: Move Fixed-Point Load/Store String instructions to
decodetree.
target/ppc: Move VMX integer arithmetic and BCD instructions to
decodetree.

Shivani Nittor (1):
target/ppc : Convert mcrf to decode tree

Tanushree Shah (2):
target/ppc: Move rlwimi, rlwinm instructions to decodetree target/ppc: Move lmw, stmw instructions to decodetree

Utkarsh Verma (1):
target/ppc: Move st{b, h, w, d, q}cx instructions to decodetree

Vishal Chourasia (3):
target/ppc: Move mfmsr, mtmsr[d] instructions to decodetree target/ppc: Move byte-reverse instructions to decodetree target/ppc: Move system call and rfi instructions to decodetree

 target/ppc/helper.h                           |  100 +-
 target/ppc/insn32.decode                      |  244 ++
 target/ppc/int_helper.c                       |   76 +-
 target/ppc/internal.h                         |    7 -
 target/ppc/mem_helper.c                       |   18 +-
 target/ppc/tcg-excp_helper.c                  |   10 +-
 target/ppc/translate.c                        | 2592 ++++-------------
 target/ppc/translate/branch-impl.c.inc        |  181 ++
 target/ppc/translate/fixedpoint-impl.c.inc    |  936 ++++++
 target/ppc/translate/misc-impl.c.inc          |  175 ++
 .../ppc/translate/processor-ctrl-impl.c.inc   |   30 +
 target/ppc/translate/storage-ctrl-impl.c.inc  |  117 +
 target/ppc/translate/vmx-impl.c.inc           |  360 +--
 target/ppc/translate/vmx-ops.c.inc            |   41 -
 14 files changed, 2529 insertions(+), 2358 deletions(-)
Signature · 1 line
2.53.0