Skip to content

GuC paging engine support

Matthew Auld intel-xe 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest10 patches 2 repliesIn review
  2. v610 patches 10 repliesSuperseded
  3. v510 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v410 patches3 repliesSuperseded
v310 patches5 repliesSuperseded
v210 patches4 repliesSuperseded
v110 patches0 repliesSuperseded

Changes in v7 from the cover letter

- Some improvements to: drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES, as suggested by Michal.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/xe/guc: refactor ads to use guc_classdrivers/gpu/drm/xe/xe_guc_ads.c+41 -280 replies
2/10drm/xe/guc: refactor to_guc_class() to accept hwedrivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c drivers/gpu/drm/xe/xe_guc.h +5 more+38 -360 replies
3/10drm/xe/guc: add the plumbing for GUC_PAGING_CLASSdrivers/gpu/drm/xe/abi/guc_capture_abi.h drivers/gpu/drm/xe/abi/guc_scheduler_abi.h drivers/gpu/drm/xe/xe_guc.c +4 more+43 -20 replies
4/10drm/xe/hw_engine: don't open code is_usm_hwe()drivers/gpu/drm/xe/xe_hw_engine.c+1 -20 replies
5/10drm/xe: refactor the paging engine setupdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_gt.h drivers/gpu/drm/xe/xe_gt_types.h +2 more+46 -491 reply
6/10drm/xe/guc: handle guc logical instance for paging enginedrivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c drivers/gpu/drm/xe/xe_guc.c +4 more+50 -60 replies
7/10drm/xe/guc: handle submit mask with paging enginedrivers/gpu/drm/xe/xe_guc_submit.c+23 -10 replies
8/10drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCESdrivers/gpu/drm/xe/abi/guc_klvs_abi.h drivers/gpu/drm/xe/xe_gt_sriov_vf.c drivers/gpu/drm/xe/xe_gt_sriov_vf.h +4 more+99 -20 replies
9/10drm/xe/hw_engine: document top-down paging requirementdrivers/gpu/drm/xe/xe_hw_engine.c+12 -10 replies
10/10drm/xe/guc: toggle paging engine support for NVL-S+drivers/gpu/drm/xe/xe_guc.c+2 -21 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo SpurioMichal WajdeczkoFrancois Dugast
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/10] GuC paging engine support

On NVL-S+, the GuC will be moving towards a dedicated GuC engine class for the driver reserved copy engine(s), which we need for USM flows. With this the GuC will now be able to internally differentiate KMD paging operations, like clearing/migrating/binding, from other copy engine submissions. Note that this is purely a software view within the GuC. There is no new physical engine, or anything like that. With that in mind the design here keeps this contained on the GuC side, with upper layers not needing to know about this distinction.

v2 (Sashiko):
- In VF query patch, we shouldn't call guc_has_paging_engine(), since this is too early in the VF sequence, and GUC_SUBMIT_VER() is still unset.
v3:
- Revamp the paging engine setup in patch 5 (Sashiko)
- Some more improvements from Daniele
v4:
- Some more improvements from Daniele, plus some other tweaks
v5:
- Some improvements from Michal
- Update with the official GuC version: 70.68.0 (1.36.0)
v6:
- Tweak the VF vs PF versioning as per GuC team
- Also for now treat zero paging engines as hint to use fallback
v7:
- Some improvements to: drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES, as suggested by Michal.

Signature · 1 line
2.54.0