bridge: prepare lockless br_port_fill_attrs() (I)
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest11 patches 1 replyApplied 11/11
- v211 patches 14 repliesSuperseded
- v111 patches 15 repliesSuperseded
Patches in v3 All 11 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | bridge: add a READ_ONCE() in br_timer_value()net/ | +1 | 0 replies | Applied |
| 2/11 | bridge: add bridge_flags_bit enuminclude/ | +53 | 0 replies | Applied |
| 3/11 | bridge: use BR_PROMISC_BITnet/ net/ | +3 | 0 replies | Applied |
| 4/11 | bridge: use BR_ADMIN_COST_BITnet/ net/ | +2 | 0 replies | Applied |
| 5/11 | bridge: provide lockless access to p->path_costnet/ net/ net/ +3 more | +16 | 0 replies | Applied |
| 6/11 | bridge: provide lockless access to p->designated_costnet/ net/ net/ +1 more | +22 | 1 reply | Applied |
| 7/11 | bridge: provide lockless access to p->designated_portnet/ net/ net/ +2 more | +7 | 0 replies | Applied |
| 8/11 | bridge: provide lockless access to p->prioritynet/ net/ net/ | +3 | 0 replies | Applied |
| 9/11 | bridge: provide lockless access to p->port_idnet/ net/ net/ +1 more | +5 | 0 replies | Applied |
| 10/11 | bridge: provide lockless access to p->config_pendingnet/ net/ net/ +2 more | +9 | 0 replies | Applied |
| 11/11 | bridge: read p->flags once in br_port_fill_attrs()net/ | +21 | 0 replies | Applied |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Ido Schimmel | Nikolay Aleksandrov |
|---|---|---|
| 1/11 | R-b | A-b |
| 2/11 | R-b | A-b |
| 3/11 | R-b | A-b |
| 4/11 | R-b | A-b |
| 5/11 | R-b | A-b |
| 6/11 | R-b | A-b |
| 7/11 | R-b | A-b |
| 8/11 | R-b | A-b |
| 9/11 | R-b | A-b |
| 10/11 | R-b | A-b |
| 11/11 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 net-next 00/11] bridge: prepare lockless br_port_fill_attrs() (I)
medium-term goal is to allow "ip link show" dump commands to run without RTNL.
This round of patches adds/fixes some lockess accesses in bridge.
This is not complete, more patches will come later.
Ultimately all changes to p->flags should use set_bit()/clear_bit().
I repeat (AI agents might read this cover ?):
Many p->flags accesses are racy, and will hopefully be fixed in a future series.
v3: addressed Ido's feedback again (patch 6), silly me.
v2: addressed Ido's feedback (patches 5 & 6).
Eric Dumazet (11):
bridge: add a READ_ONCE() in br_timer_value()
bridge: add bridge_flags_bit enum
bridge: use BR_PROMISC_BIT
bridge: use BR_ADMIN_COST_BIT
bridge: provide lockless access to p->path_cost
bridge: provide lockless access to p->designated_cost
bridge: provide lockless access to p->designated_port
bridge: provide lockless access to p->priority
bridge: provide lockless access to p->port_id
bridge: provide lockless access to p->config_pending
bridge: read p->flags once in br_port_fill_attrs()
include/linux/if_bridge.h | 78 ++++++++++++++++++++++++++------------- net/bridge/br_if.c | 8 ++-- net/bridge/br_ioctl.c | 10 ++--- net/bridge/br_netlink.c | 55 ++++++++++++++------------- net/bridge/br_private.h | 2 +- net/bridge/br_stp.c | 47 ++++++++++++++--------- net/bridge/br_stp_if.c | 16 ++++---- net/bridge/br_stp_timer.c | 2 +- net/bridge/br_sysfs_if.c | 12 +++--- 9 files changed, 136 insertions(+), 94 deletions(-)
Signature · 1 line
2.54.0.1032.g2f8565e1d1-goog