Skip to content

extend interactive telemetry script

Bruce Richardson dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 4 repliesApplied
  2. v23 patches 3 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3usertools/telemetry: add a FOREACH commanddoc/guides/howto/telemetry.rst usertools/dpdk-telemetry.py+167 -30 replies
2/3usertools/telemetry: support using aliases for long commandsdoc/guides/howto/telemetry.rst usertools/dpdk-telemetry.py+116 -41 reply
3/3usertools/telemetry: add help supportdoc/guides/howto/telemetry.rst usertools/dpdk-telemetry.py+93 -71 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchChengwen Feng
SeriesSeries-acked-by
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] extend interactive telemetry script

To simplify interactive telemetry script for general use, i.e. not from other scripts, we can add two new features to it:

1. Support for FOREACH to allow gathering a set of output values across a list of ports or devices, e.g. ethdevs or rawdevs.
2. Support having predefined aliases in a file in the user's home directory to simplify the use of more complicated FOREACH commands.

Putting these together, we can create new commands such as "eth_names".

  bruce@host:$ cat ~/.dpdk_telemetry_aliases
  eth_names=FOREACH index /ethdev/list /ethdev/info,$index .name
  bruce@host:$ echo eth_names | ./usertools/dpdk-telemetry.py | jq
  [
    {
      "index": 0,
      "name": "0000:16:00.0"
    },
    {
      "index": 1,
      "name": "0000:16:00.1"
    }
  ]

---
v3: updated based on review feedback from Chengwen:
- added arg to override alias file
- printed one-line summary of alias count loaded
- improved doc for "help" command
- added "help alias" to list aliases.
v2: added third patch with "help" command giving more details on
how to use the various commands.

Bruce Richardson (3):
usertools/telemetry: add a FOREACH command usertools/telemetry: support using aliases for long commands usertools/telemetry: add help support

 doc/guides/howto/telemetry.rst | 106 ++++++++++++-
 usertools/dpdk-telemetry.py    | 278 ++++++++++++++++++++++++++++++++-
 2 files changed, 373 insertions(+), 11 deletions(-)

--
2.53.0