Skip to content

arm64: dts: rockchip: Add support for Axelera Embedded 111c

Patrick Barsanti linux-devicetree linux-rockchip lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Address Heiko's comment about the incorrect Signed-off-by chain.
- Address Heiko's comment about the dts name being too generic.
- Address Heiko's comment about the deprecated "regulator-suspend-microvolt" property.
- Add Copyright header on dts.
- Add Krzysztof's Acked-by.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: vendor-prefixes: Add Axelera AIDocumentation/devicetree/bindings/vendor-prefixes.yaml+2 -00 replies
2/3dt-bindings: arm: rockchip: Add Axelera Embedded 111cDocumentation/devicetree/bindings/arm/rockchip.yaml+5 -00 replies
3/3arm64: dts: rockchip: Add Axelera Embedded 111carch/arm64/boot/dts/rockchip/Makefile arch/arm64/boot/dts/rockchip/rk3588-axelera-embedded-111c.dts+811 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchConor DooleyKrzysztof Kozlowski
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] arm64: dts: rockchip: Add support for Axelera Embedded 111c

The Axelera Embedded 111c is an SBC based on the Rockchip RK3588 SoC. It offers efficient AI compute for multi-stream computer vision and generative AI applications in a compact design.

Product page [1].

This series aims to introduce basic support for the board, which includes the console, the eMMC, the two Gigabit Ethernet ports, the four USB ports and the HDMI connector.

Changes in v3:
- Address Heiko's comment about the incorrect Signed-off-by chain.
- Address Heiko's comment about the dts name being too generic.
- Address Heiko's comment about the deprecated "regulator-suspend-microvolt" property.
- Add Copyright header on dts.
- Add Krzysztof's Acked-by.

Changes in v2:
- The board was renamed by Axelera between v1 and v2, from "Metis Compute Board" to "Embedded 111c". Address the name change. Drop Conor's Acked-by on the bindings, since the compatible changed. Keep it on the vendor-prefix.
- Address Heiko's comment about regulator node names starting with "regulator-".
- Address Heiko's comment about non-existent "mem-supply" binding.
- Address Heiko's comment about dropping the unneeded "Use rgmii-rxid mode to disable rx delay inside Soc" comment; checkpatch complains about uncommented rgmii-rxid, so take the one from rk3588-youyeetoo-yy3588.
- Address Heiko's comment about reset lines of the phy nodes being incorrectly described in the gmac node; note that these are still not described in the phy node because GPIO3_B7 defaults to pull-down, which causes the rgmii_phy1 node to never come up; rgmii_phy0's reset GPIO, GPIO4_B3, defaults to pull-up, so that node does not encounter the same issue. Moving the reset to the parent mdio node instead did the trick.
- Address Sashiko's high severity comment about hdmi0 node mixing M0 and M1 pinmux groups; use the existing hdmim1_tx0_hpd pinctrl group instead of redefining it. HPD is wired to M1 while CEC and DDC use the M0 pins. Verified hot-plug detection on external display.
- Address Sashiko's medium comment about "full-pwr-cycle-in-suspend" and missing "vmmc-supply" and "vqmmc-supply" on the eMMC node; drop the former, add the latter two.
- Address Sashiko's medium comment about the pmic node lacking a pinctrl assignment for the interrupt pin; add it.
- Address Sashiko's medium comment about the "vcc3v3_hubreset" regulator hack; describe the two GL3523 hubs linked with peer-hub.
- Address Sashiko's low comment about defined-but-never-referenced regulators without regulator-always-on property; drop them, alongside their pinctrls.
- Mux PCIEX4_PERST_N as GPIO, to match it being used via reset-gpios.
- Drop the unused input.h include.
- Drop the unused rtc label.
- Drop the local PCIe x1 pinctrl groups, which duplicated the pcie30x1m1_1_* groups in rk3588-base-pinctrl.dtsi.

Link to v1: [2].
Link to v2: [3].

[1]: https://axelera.ai/axelera-products/embedded/111c
[2]: https://lore.kernel.org/all/[email protected]
[3]: https://lore.kernel.org/all/[email protected]

Patrick Barsanti (3):
dt-bindings: vendor-prefixes: Add Axelera AI
dt-bindings: arm: rockchip: Add Axelera Embedded 111c
arm64: dts: rockchip: Add Axelera Embedded 111c

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../rockchip/rk3588-axelera-embedded-111c.dts | 810 ++++++++++++++++++
 4 files changed, 818 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-axelera-embedded-111c.dts
Signature · 1 line
2.53.0