Skip to content

selftests: rds: ROCE support follow ups

Allison Henderson linux-kselftest linux-rdma netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesApplied 4/4
  2. v24 patches 3 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

Changes in v3 from the cover letter

[PATCH net-next v2 1/4] selftests: rds: Rename run.sh to rds_run.sh
- Wrapped USAGE line to fix checkpatch 84-column warning

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests: rds: Rename run.sh to rds_run.shtools/testing/selftests/net/rds/Makefile tools/testing/selftests/net/rds/README.txt tools/testing/selftests/net/rds/rds_run.sh+9 -80 repliesApplied
2/4selftests: rds: pin RDS sockets to their intended transporttools/testing/selftests/net/rds/test.py+18 -00 repliesApplied
3/4selftests: rds: support RDS built as loadable modulestools/testing/selftests/net/rds/config tools/testing/selftests/net/rds/config.sh tools/testing/selftests/net/rds/rds_run.sh+40 -240 repliesApplied
4/4selftests: rds: report missing RDMA prereqs as XFAILtools/testing/selftests/net/rds/rds_run.sh+6 -60 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/4] selftests: rds: ROCE support follow ups

Hi all,

This is a follow up series to the "Add ROCE support to rds selftests" series. The first patch renames run.sh to rds_run.sh, which provides a self-describing name that appears on the netdev CI dashboard.

The second patch addresses a sashiko complaint that I thought was worth circling back for. In the patch "pin RDS sockets to their intended transport," sockets are pinned to the specific transport they are meant to test. By default, socket transports are implicitly selected based on the network topology, but it is possible that they can fail back to other transports if the underlying connection could not be established. So the patch pins them to the intended transport to avoid false positives.

The third patch "support RDS built as loadable modules," lifts the CONFIG_MODULES=n requirement, and updates the check_*conf_enabled() to allow modules set to "=m" and further load the backing modules for any component set as such. config.sh is updated to match.

The fourth patch converts the rdma-prerequisite checks to return XFAIL rather than SKIP, since the RDMA datapath is not run in netdev CI.

Questions, comments and feedback appreciated!

Thanks everyone!
Allison

Change log:
v3:
[PATCH net-next v2 1/4] selftests: rds: Rename run.sh to rds_run.sh
- Wrapped USAGE line to fix checkpatch 84-column warning

[PATCH net-next v2 3/4] selftests: rds: support RDS built as loadable modules
- Drop --disable CONFIG_MODULES from config.sh

[PATCH net-next v2 4/4] selftests: rds: report missing RDMA prereqs as XFAIL
- Corrected XFAIL rc from 5 to 2

v2:
[PATCH net-next v1 1/3] selftests: rds: add per-transport run wrappers
- Renamed to "selftests: rds: Rename run.sh to rds_run.sh"
- Removed rds_*_run.sh wrappers
- Dropped dangling wrapper paragraph from README

[PATCH net-next v1 3/3] selftests: rds: support RDS built as loadable modules
- Fixed long line length warning

[PATCH net-next v2 4/4] selftests: rds: report missing RDMA prereqs as XFAIL
- NEW

Allison Henderson (4):
selftests: rds: Rename run.sh to rds_run.sh
selftests: rds: pin RDS sockets to their intended transport
selftests: rds: support RDS built as loadable modules
selftests: rds: report missing RDMA prereqs as XFAIL

 tools/testing/selftests/net/rds/Makefile      |  2 +-
 tools/testing/selftests/net/rds/README.txt    |  8 +-
 tools/testing/selftests/net/rds/config        |  1 -
 tools/testing/selftests/net/rds/config.sh     |  3 -
 .../selftests/net/rds/{run.sh => rds_run.sh}  | 75 ++++++++++++-------
 tools/testing/selftests/net/rds/test.py       | 18 +++++
 6 files changed, 71 insertions(+), 36 deletions(-)
 rename tools/testing/selftests/net/rds/{run.sh => rds_run.sh} (78%)

base-commit: 1a1f055318d82e64485a6ff8420e5f70b4267998

Signature · 1 line
2.25.1