ethtool: module: fix a handful of small bugs
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 9 applied
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Maxime Chevallier | Danielle Ratson |
|---|---|---|
| 1/9 | R-b | R-b |
| 2/9 | R-b | R-b |
| 3/9 | R-b | R-b |
| 4/9 | R-b | R-b |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | R-b | R-b |
| 8/9 | R-b | R-b |
| 9/9 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/9] ethtool: module: fix a handful of small bugs
I've been poking at the locking in ethtool and it appears that the FW flashing is not currently taking the ops lock. Existing drivers which implement module FW flashing seem to have their own locking, so this series doesn't actually add the ops lock (I'll add it in net-next). But a number of other errors have been surfaced in the process.
Jakub Kicinski (9):
ethtool: module: call ethnl_ops_complete() on module flash errors
ethtool: module: avoid leaking a netdev ref on module flash errors
ethtool: module: avoid racy updates to dev->ethtool bitfield
ethtool: module: check fw_flash_in_progress under rtnl_lock
ethtool: module: fix cleanup if socket used for flashing multiple
devices
ethtool: cmis: require exact CDB reply length
ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl
ethtool: cmis: validate start_cmd_payload_size from module
ethtool: cmis: validate fw->size against start_cmd_payload_size
net/ethtool/cmis.h | 4 ++-- net/ethtool/netlink.h | 4 ++-- net/ethtool/cmis_cdb.c | 9 ++++++-- net/ethtool/cmis_fw_update.c | 44 ++++++++++++++++++++++++------------ net/ethtool/module.c | 41 ++++++++++++++++++++------------- net/ethtool/netlink.c | 4 ++-- 6 files changed, 68 insertions(+), 38 deletions(-)
Signature · 1 line
2.54.0