Skip to content

hw/smbios: Add dedicated handle range for Type 8 tables

Alexander Gryanko qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Resent with Igor Mammedov on Cc as the ACPI/SMBIOS supporter.
- No code changes.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/i386/pc: Introduce 11.2 machine type for SMBIOS type 8 base migrationhw/core/machine.c hw/i386/pc.c hw/i386/pc_piix.c +3 more+41 -41 reply
2/3hw/smbios: Add dedicated handle range for Type 8 tableshw/i386/fw_cfg.c hw/smbios/smbios.c include/hw/firmware/smbios.h+11 -10 replies
3/3tests/qtest: Add SMBIOS Type 8 handle base teststests/qtest/bios-tables-test.c+69 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] hw/smbios: Add dedicated handle range for Type 8 tables

This is a continuation of the work originally proposed by Felix Wu [1], which changed the SMBIOS Type 8 handle base unconditionally. As Igor Mammedov pointed out in review, an unconditional change would break live migration between hosts running different QEMU versions. This series addresses the review feedback by:
- Using machine-type versioning (pc-*-11.2) to opt in to the new behavior, preserving T0_BASE for older machine types
- Adding a PCMachineClass field to control the setting per machine type
- Adding tests for both new and compat machine versions
[1] https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg03208.html

Changes since v1:
- Resent with Igor Mammedov on Cc as the ACPI/SMBIOS supporter.
- No code changes.

Alexander Gryanko (3):
hw/i386/pc: Introduce 11.2 machine type for SMBIOS type 8 base
migration
hw/smbios: Add dedicated handle range for Type 8 tables tests/qtest: Add SMBIOS Type 8 handle base tests

 hw/core/machine.c              |  3 ++
 hw/i386/fw_cfg.c               |  1 +
 hw/i386/pc.c                   |  3 ++
 hw/i386/pc_piix.c              | 16 +++++++-
 hw/i386/pc_q35.c               | 16 +++++++-
 hw/smbios/smbios.c             | 10 ++++-
 include/hw/core/boards.h       |  3 ++
 include/hw/firmware/smbios.h   |  1 +
 include/hw/i386/pc.h           |  4 ++
 tests/qtest/bios-tables-test.c | 70 +++++++++++++++++++++++++++++++++-
 10 files changed, 121 insertions(+), 6 deletions(-)
Signature · 1 line
2.39.5 (Apple Git-154)