Skip to content

netfilter: ipset fixes, second batch

Jozsef Kadlecsik netfilter-devel syzbot 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 0 repliesNew
  2. v29 patches 2 repliesSuperseded
  3. v16 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7netfilter: ipset: Don't use test_bit() in lockless RCU readers in hash typesnet/netfilter/ipset/ip_set_hash_gen.h+5 -50 replies
2/7netfilter: ipset: Don't use test_bit() in lockless RCU readers in bitmap typesnet/netfilter/ipset/ip_set_bitmap_gen.h net/netfilter/ipset/ip_set_bitmap_ip.c net/netfilter/ipset/ip_set_bitmap_ipmac.c +1 more+6 -40 replies
3/7netfilter: ipset: fix order of kfree_rcu() and rcu_assign_pointer()net/netfilter/ipset/ip_set_core.c+2 -20 replies
4/7netfilter: ipset: exlude gc when resize is in progressnet/netfilter/ipset/ip_set_hash_gen.h+16 -40 replies
5/7netfilter: ipset: make sure gc is properly stoppednet/netfilter/ipset/ip_set_hash_gen.h+1 -10 replies
6/7netfilter: ipset: cleanup the add/del backlog when resize failednet/netfilter/ipset/ip_set_hash_gen.h+9 -00 replies
7/7netfilter: ipset: rework cidr bookkeepingnet/netfilter/ipset/ip_set_hash_gen.h net/netfilter/ipset/ip_set_hash_ipportnet.c net/netfilter/ipset/ip_set_hash_net.c +4 more+51 -360 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] netfilter: ipset fixes, second batch

Hi Pablo,

Here follows the updated patches for the second batch. I left out some potential issues (like torn read in reuse/forceadd cases), those will be handled later.

Best regards,
Jozsef

Jozsef Kadlecsik (7):
netfilter: ipset: Don't use test_bit() in lockless RCU readers in hash
types
netfilter: ipset: Don't use test_bit() in lockless RCU readers in
bitmap types
netfilter: ipset: fix order of kfree_rcu() and rcu_assign_pointer()
netfilter: ipset: exlude gc when resize is in progress
netfilter: ipset: make sure gc is properly stopped
netfilter: ipset: cleanup the add/del backlog when resize failed
netfilter: ipset: rework cidr bookkeeping

 net/netfilter/ipset/ip_set_bitmap_gen.h      |  4 +-
 net/netfilter/ipset/ip_set_bitmap_ip.c       |  2 +-
 net/netfilter/ipset/ip_set_bitmap_ipmac.c    |  2 +-
 net/netfilter/ipset/ip_set_bitmap_port.c     |  2 +-
 net/netfilter/ipset/ip_set_core.c            |  4 +-
 net/netfilter/ipset/ip_set_hash_gen.h        | 96 ++++++++++++++------
 net/netfilter/ipset/ip_set_hash_ipportnet.c  |  4 +-
 net/netfilter/ipset/ip_set_hash_net.c        |  4 +-
 net/netfilter/ipset/ip_set_hash_netiface.c   |  4 +-
 net/netfilter/ipset/ip_set_hash_netnet.c     |  8 +-
 net/netfilter/ipset/ip_set_hash_netport.c    |  4 +-
 net/netfilter/ipset/ip_set_hash_netportnet.c |  8 +-
 12 files changed, 90 insertions(+), 52 deletions(-)
Signature · 1 line
2.39.5