RFC Add option to use default config file.
Get series with b4
b4 am [email protected]Versions newest first
- v2 RFC Latest5 patches 11 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | xfsprogs: mkfs.xfs Add buildtime default cli_params as global variablemkfs/ | +50 | 2 replies | |
| 2/5 | xfsprogs: mkfs.xfs add default configuration file.include/ mkfs/ mkfs/ +1 more | +108 | 2 replies | |
| 3/5 | xfsprogs: mkfs.xfs add auto|autodetect value for -d/l/r concurrencymkfs/ | +10 | 2 replies | |
| 4/5 | xfs_admin: add -d option to manage default mkfs config file.gitignore db/ db/ | +40 | 1 reply | |
| 5/5 | xfsprogs: mkfs.xfs clean up unused dft option in various validatorsmkfs/ | +11 | 1 reply |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v2 0/5] Add option to use default config file.
Hi,
Sending a v2 version trying to implement the changes suggested by Carlos, Darrick, Eric and Dave. The default.conf is not installed automatically but there is simple example file.
The order is now build-time < default-file < command line settings. Some values like uuid,sunit,swidth sector size and block size are not allowed to be set in the default config file and if set user is warned about it and the value is reset to build-time default.
I moved setting of some values in cli_params and setting of mkfs_default_params into new bld_dft struct as If I get it correctly we were basically setting some of the default values on two places. It also resulted in cleanup of unused parameters from some validate_* functions.
Lukas Herbolt (5):
xfsprogs: mkfs.xfs Add buildtime default cli_params as global variable
xfsprogs: mkfs.xfs add default configuration file.
xfsprogs: mkfs.xfs add auto|autodetect value for -d/l/r concurrency
xfs_admin: add -d option to manage default mkfs config file
xfsprogs: mkfs.xfs clean up unused dft option in various validators
.gitignore | 3 +
db/Makefile | 11 +-
db/{xfs_admin.sh => xfs_admin.sh.in} | 30 +++-
include/builddefs.in | 1 +
mkfs/Makefile | 2 +
mkfs/default.conf.example | 10 ++
mkfs/xfs_mkfs.c | 240 +++++++++++++++++----------
7 files changed, 207 insertions(+), 90 deletions(-)
rename db/{xfs_admin.sh => xfs_admin.sh.in} (70%)
create mode 100644 mkfs/default.conf.exampleSignature · 1 line
2.54.0