drm/xe/mmio_gem: fix fault handler and destroy path
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 8 repliesIn review
- v25 patches 11 repliesSuperseded
- v14 patches 3 repliesSuperseded
v2 from the cover letter
- New patch 1/5: fix dummy page WB/UC aliasing (Sashiko)
- Patch 2/5: no longer modifies xe_mmio_gem_vm_fault_dummy_page() (handled by 1/5)
- Patch 3/5: unchanged
- Patch 4/5: compute pfn inside scoped_guard
- Patch 5/5: adapt to xe_mmio_gem_vm_fault_dummy_page() signature change, fix "objecthas" typo
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | drm/xe/mmio_gem: forbid VMA splitdrivers/ | +10 | 1 reply | |
| 2/7 | drm/xe/mmio_gem: use write-back mapping for dummy pagedrivers/ | +5 | 3 replies | |
| 3/7 | drm/xe/mmio_gem: simplify fault handler loopdrivers/ | +6 | 1 reply | |
| 4/7 | drm/xe/mmio_gem: Revoke drm_vma_node on xe_mmio_gem destroydrivers/ drivers/ | +4 | 0 replies | |
| 5/7 | drm/xe/mmio_gem: cache the dummy page per objectdrivers/ | +16 | 1 reply | |
| 6/7 | drm/xe/mmio_gem: fix destroy flowdrivers/ | +35 | 1 reply | |
| 7/7 | drm/xe: convert PCI barrier mmap to use xe_mmio_gemdrivers/ drivers/ drivers/ +1 more | +39 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Ilia Levi | Matthew Auld |
|---|---|---|
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/7] drm/xe/mmio_gem: fix fault handler and destroy path
This series fixes several issues in xe_mmio_gem, introduced by 1ffcf8b8ae8a ("drm/xe: Support for mmap-ing mmio regions"):
split VMA handling, WB/UC aliasing of the dummy page, a rb-tree leak on destroy, dummy page accumulation, and use-after-free / MMIO access after destroy. It also converts the existing PCI barrier mmap to build on xe_mmio_gem now that the infrastructure is in place.
v3: (Matt Auld)
- New patch using the xe_mmio_gem infra for PCI barrier mmap
- New patch for rejecting VMA split
- Using dma_resv lock for synchronization
- SIGBUS instead of dummy page on access after destroy
- Some changes in patch splitting (e.g. the vm_pgoff handling now lives in the destroy-flow patch alongside the zap that needs it)
v2:
- New patch 1/5: fix dummy page WB/UC aliasing (Sashiko)
- Patch 2/5: no longer modifies xe_mmio_gem_vm_fault_dummy_page() (handled by 1/5)
- Patch 3/5: unchanged
- Patch 4/5: compute pfn inside scoped_guard
- Patch 5/5: adapt to xe_mmio_gem_vm_fault_dummy_page() signature change, fix "objecthas" typo
Ilia Levi (5):
drm/xe/mmio_gem: forbid VMA split drm/xe/mmio_gem: use write-back mapping for dummy page drm/xe/mmio_gem: simplify fault handler loop drm/xe/mmio_gem: cache the dummy page per object drm/xe/mmio_gem: fix destroy flow
Matthew Auld (1):
drm/xe: convert PCI barrier mmap to use xe_mmio_gem
Shuicheng Lin (1):
drm/xe/mmio_gem: Revoke drm_vma_node on xe_mmio_gem destroy
drivers/gpu/drm/xe/xe_bo.c | 24 ++++-- drivers/gpu/drm/xe/xe_bo.h | 1 - drivers/gpu/drm/xe/xe_device.c | 102 ++----------------------- drivers/gpu/drm/xe/xe_device_types.h | 12 +++ drivers/gpu/drm/xe/xe_mmio_gem.c | 108 ++++++++++++++++++--------- drivers/gpu/drm/xe/xe_mmio_gem.h | 2 +- 6 files changed, 112 insertions(+), 137 deletions(-)
Signature · 1 line
2.49.1