ASoC: Intel: catpt: Error handling and debug improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 3 repliesIn review
- v13 patches 2 repliesSuperseded
Changes in v2 from the cover letter
- moved the COREDUMP_RELEASE operation from dsp.c to ipc.c, right after catpt_coredump() to ensure it's always executed, even if the dump itself is not written due to -ENOMEM, suggested by Mark
- spelling fixes in the patch 1/3 message, s/COREDYMP/COREDUMP/
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ASoC: Intel: catpt: Complete coredump handlingsound/ sound/ sound/ | +23 | 0 replies | |
| 2/3 | ASoC: Intel: catpt: Add pretty-trace for large IPC payloadssound/ sound/ sound/ +1 more | +44 | 0 replies | |
| 3/3 | ASoC: Intel: catpt: Print error code if board-registration failssound/ | +1 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] ASoC: Intel: catpt: Error handling and debug improvements
Outcome of a long debug to solve one, long-standing bug ocurring very rarely on Haswell/Broadwell machines during the boot procedure of the AudioDSP firmware. Clever/unfortunate user can increase the reproduction rare to 100%.
The bug: an exception occurring early during FW boot (firmware side, not the software one) leaves the firmware hanging and the existing software code is incappable of recognizing such problem. The only solution a user currently has is: rmmod and then modprobe the driver.
Recently, together with Krzysztof from the firmware team decided to take it up and clear the dashboard.
The exception handling takes just a few lines of code (all part of the first patch), everything else that this patchset is composed of improves the debugability and logging. If anything similar pops up, the developers can see what's going on.
Changes in v2:
- moved the COREDUMP_RELEASE operation from dsp.c to ipc.c, right after catpt_coredump() to ensure it's always executed, even if the dump itself is not written due to -ENOMEM, suggested by Mark
- spelling fixes in the patch 1/3 message, s/COREDYMP/COREDUMP/
Cezary Rojewski (3):
ASoC: Intel: catpt: Complete coredump handling
ASoC: Intel: catpt: Add pretty-trace for large IPC payloads
ASoC: Intel: catpt: Print error code if board-registration fails
sound/soc/intel/catpt/Makefile | 3 ++- sound/soc/intel/catpt/device.c | 5 +---- sound/soc/intel/catpt/ipc.c | 8 ++++++++ sound/soc/intel/catpt/loader.c | 3 +++ sound/soc/intel/catpt/registers.h | 12 ++++++++++++ sound/soc/intel/catpt/trace.c | 27 +++++++++++++++++++++++++++ sound/soc/intel/catpt/trace.h | 22 +++++++++++++++------- 7 files changed, 68 insertions(+), 12 deletions(-) create mode 100644 sound/soc/intel/catpt/trace.c
Signature · 1 line
2.34.1