Skip to content

netconsole: Fix reported problems

Breno Leitao lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected] change-id 20260528-netcons_fix_before_move-cd6cfec4e8f5

Versions newest first

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 1 replySuperseded

Changes in v3 from the cover letter

- Fix a regression in the first patch, where warning was called in
a potential NMI context.
- Fix additional issues reported by sashiko. They never end.
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5netconsole: do not schedule skb pool refill from NMIdrivers/net/netconsole.c+19 -40 repliesApplied
2/5netconsole: do not dequeue pooled skbs that cannot satisfy lendrivers/net/netconsole.c include/linux/netpoll.h net/core/netpoll.c+36 -90 repliesApplied
3/5netconsole: take target_cleanup_list_lock in drop_netconsole_target()drivers/net/netconsole.c+2 -00 repliesApplied
4/5netconsole: clean up deactivated targets dropped before the cleanup workerdrivers/net/netconsole.c+13 -10 repliesApplied
5/5netconsole: close netdevice unregister window during target resumedrivers/net/netconsole.c+19 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] netconsole: Fix reported problems

These are some of the issues that LLM reported to netconsole, and they are being addressed here before big refactors.

I was doing some big refactors, and got some "pre-existent-issues" during LLM review of the refactor, that make them hard to guarantee that refactor is not introducing any bug, so, let's clean these pre-existent bugs first, and then submit the refactor.

The issues fixed in this patchset were reported during the review of
https://lore.kernel.org/all/[email protected]/

Not all of them got fixed, but, those that were easy to reason about.

Why net-next and not 'net' tree.

Most of the functions that are being fixed here moved from netpoll to netconsole, thus, fixing this on net will cause merge conflicts from 'net' to 'net-next', thus I decided to fix it on 'net-next', given we are on 7.1-rc6 already. Sorry if that is not the right approach.

---
Changes in v3:
- Fix a regression in the first patch, where warning was called in
a potential NMI context.
- Fix additional issues reported by sashiko. They never end.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changed in v2:
* Change it from 'net' to 'net-next'.

---
Breno Leitao (5):
netconsole: do not schedule skb pool refill from NMI
netconsole: do not dequeue pooled skbs that cannot satisfy len
netconsole: take target_cleanup_list_lock in drop_netconsole_target()
netconsole: clean up deactivated targets dropped before the cleanup worker
netconsole: close netdevice unregister window during target resume

 drivers/net/netconsole.c | 76 ++++++++++++++++++++++++++++++++++++++++++++----
 include/linux/netpoll.h  | 16 ++++++++++
 net/core/netpoll.c       |  7 -----
 3 files changed, 87 insertions(+), 12 deletions(-)

---
base-commit: cd5077cccf13effebf7ff4cb1c7fa080c1738d0f
change-id: 20260528-netcons_fix_before_move-cd6cfec4e8f5

Best regards,

Signature · 1 line
Breno Leitao <[email protected]>