Skip to content

hw/arm/aspeed: Add AST1040 peripheral support

Jamin Lin qemu-arm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 1 replyIn review
  2. v210 patches 8 repliesSuperseded
  3. v110 patches 15 repliesSuperseded

v1 from the cover letter

1. Support ADC, GPIO, SGPIO, I2C and PECI

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10hw/i2c/aspeed_i2c: Introduce dma_addr_lo_mask to unify DMA address handlinghw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+15 -140 replies
2/10hw/i2c/aspeed_i2c: Increase AST2700 buffer mode size and adjust offsethw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+24 -240 replies
3/10hw/arm/aspeed_ast1040: Reuse AST2700 ADC modelhw/arm/aspeed_ast1040.c+11 -00 replies
4/10hw/arm/aspeed_ast1040: Introduce PECI supporthw/arm/aspeed_ast1040.c+12 -00 replies
5/10hw/arm/aspeed_ast1040: Reuse AST2700 GPIO controller modelhw/arm/aspeed_ast1040.c+10 -00 replies
6/10hw/arm/aspeed_ast1040: Add SGPIO controller supporthw/arm/aspeed_ast1040.c+17 -120 replies
7/10hw/i2c/aspeed_i2c: Introduce AST1040 I2C modelhw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+34 -00 replies
8/10hw/arm/aspeed_ast1040: Introduce I2C supporthw/arm/aspeed_ast1040.c+16 -00 replies
9/10hw/arm/aspeed_ast1040_evb: Introduce onboard I2C devicehw/arm/aspeed_ast1040_evb.c+15 -00 replies
10/10hw/arm/aspeed_ast1040: Reuse AST2700 watchdog modelshw/arm/aspeed_ast1040.c+19 -00 replies

Reviews trailers per patch

6 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCédric Le Goater
SeriesR-b
1/10
2/10
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] hw/arm/aspeed: Add AST1040 peripheral support

This series extends the AST1040 SoC model by adding support for several peripherals that are compatible with existing AST2700 controller models.

The AST1040 shares a number of peripheral IP blocks with the AST2700, allowing the existing QEMU models to be reused with minimal changes. This series adds support for ADC, PECI, GPIO, SGPIO, I2C, and watchdog controllers, and updates the AST1040 EVB machine to instantiate onboard I2C devices for validation.

For I2C support, a new AST1040 I2C type is introduced. The model inherits the AST2700 I2C architecture, including DMA support and 64-bit DMA address registers, while constraining DMA accesses to the 16 MiB HyperRAM address space available on AST1040.

Depends on:
https://github.com/legoater/qemu.git (branch: aspeed-next)

v1:
1. Support ADC, GPIO, SGPIO, I2C and PECI

v2:
1. Address review feedback.
2. Fix issues reported during review.
3. Update i2c bus number to 14.

Jamin Lin (10):
hw/i2c/aspeed_i2c: Introduce dma_addr_lo_mask to unify DMA address
handling
hw/i2c/aspeed_i2c: Increase AST2700 buffer mode size and adjust offset hw/arm/aspeed_ast1040: Reuse AST2700 ADC model hw/arm/aspeed_ast1040: Introduce PECI support hw/arm/aspeed_ast1040: Reuse AST2700 GPIO controller model hw/arm/aspeed_ast1040: Add SGPIO controller support hw/i2c/aspeed_i2c: Introduce AST1040 I2C model hw/arm/aspeed_ast1040: Introduce I2C support hw/arm/aspeed_ast1040_evb: Introduce onboard I2C device hw/arm/aspeed_ast1040: Reuse AST2700 watchdog models

 include/hw/i2c/aspeed_i2c.h |   8 ++-
 hw/arm/aspeed_ast1040.c     |  97 ++++++++++++++++++++++++++++-----
 hw/arm/aspeed_ast1040_evb.c |  15 ++++++
 hw/i2c/aspeed_i2c.c         | 103 ++++++++++++++++++++++++------------
 4 files changed, 173 insertions(+), 50 deletions(-)
Signature · 1 line
2.43.0