qcom-rng fixes and cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 2 repliesIn review
- v14 patches 9 repliesSuperseded
Changes in v2 from the cover letter
- Changed patch 3 to make the driver continue to be bound even when hwrng is unsupported.
- Added blank line in patch 2
- Added Reviewed-by
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | crypto: qcom-rng - Enable clock in hwrng casedrivers/ | +16 | 0 replies | |
| 2/4 | crypto: qcom-rng - Allow zero as a random numberdrivers/ | +0 | 0 replies | |
| 3/4 | crypto: qcom-rng - Remove crypto_rng interfacedrivers/ drivers/ | +19 | 1 reply | |
| 4/4 | hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/arch/ arch/ arch/ +6 more | +16 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Dmitry Baryshkov | Konrad Dybcio |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | R-b |
| 3/4 | R-b | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] qcom-rng fixes and cleanups
This series fixes several bugs in qcom-rng, including failure to enable the clock before accessing the hardware, generating biased random numbers, and generating duplicate or non-random numbers due to missing locking. To fix the latter bug, it drops the support for the duplicative crypto_rng interface, which isn't used in practice, leaving just hwrng which is the one that actually matters.
This series is targeting cryptodev/master
Changed in v2:
- Changed patch 3 to make the driver continue to be bound even when hwrng is unsupported.
- Added blank line in patch 2
- Added Reviewed-by
Eric Biggers (4):
crypto: qcom-rng - Enable clock in hwrng case
crypto: qcom-rng - Allow zero as a random number
crypto: qcom-rng - Remove crypto_rng interface
hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/
arch/arm/configs/multi_v7_defconfig | 2 +-
arch/arm/configs/qcom_defconfig | 2 +-
arch/arm64/configs/defconfig | 2 +-
drivers/char/hw_random/Kconfig | 11 ++
drivers/char/hw_random/Makefile | 1 +
drivers/{crypto => char/hw_random}/qcom-rng.c | 156 +++---------------
drivers/crypto/Kconfig | 12 --
drivers/crypto/Makefile | 1 -
drivers/gpu/drm/ci/arm64.config | 2 +-
9 files changed, 41 insertions(+), 148 deletions(-)
rename drivers/{crypto => char/hw_random}/qcom-rng.c (53%)base-commit: 79bbe453e5bfa6e1c6aa2e8329bfc8f152b81c9b
Signature · 1 line
2.54.0.1064.gd145956f57-goog