Skip to content

qcom-rng fixes and cleanups

Eric Biggers linux-arm-msm linux-crypto lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Changed patch 3 to make the driver continue to be bound even when hwrng is unsupported.
- Added blank line in patch 2
- Added Reviewed-by

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4crypto: qcom-rng - Enable clock in hwrng casedrivers/crypto/qcom-rng.c+16 -00 replies
2/4crypto: qcom-rng - Allow zero as a random numberdrivers/crypto/qcom-rng.c+0 -20 replies
3/4crypto: qcom-rng - Remove crypto_rng interfacedrivers/crypto/Kconfig drivers/crypto/qcom-rng.c+19 -1401 reply
4/4hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/arch/arm/configs/multi_v7_defconfig arch/arm/configs/qcom_defconfig arch/arm64/configs/defconfig +6 more+16 -160 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchDmitry BaryshkovKonrad Dybcio
1/4R-b R-b
2/4R-b R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] qcom-rng fixes and cleanups

This series fixes several bugs in qcom-rng, including failure to enable the clock before accessing the hardware, generating biased random numbers, and generating duplicate or non-random numbers due to missing locking. To fix the latter bug, it drops the support for the duplicative crypto_rng interface, which isn't used in practice, leaving just hwrng which is the one that actually matters.

This series is targeting cryptodev/master

Changed in v2:
- Changed patch 3 to make the driver continue to be bound even when hwrng is unsupported.
- Added blank line in patch 2
- Added Reviewed-by

Eric Biggers (4):
crypto: qcom-rng - Enable clock in hwrng case
crypto: qcom-rng - Allow zero as a random number
crypto: qcom-rng - Remove crypto_rng interface
hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/

 arch/arm/configs/multi_v7_defconfig           |   2 +-
 arch/arm/configs/qcom_defconfig               |   2 +-
 arch/arm64/configs/defconfig                  |   2 +-
 drivers/char/hw_random/Kconfig                |  11 ++
 drivers/char/hw_random/Makefile               |   1 +
 drivers/{crypto => char/hw_random}/qcom-rng.c | 156 +++---------------
 drivers/crypto/Kconfig                        |  12 --
 drivers/crypto/Makefile                       |   1 -
 drivers/gpu/drm/ci/arm64.config               |   2 +-
 9 files changed, 41 insertions(+), 148 deletions(-)
 rename drivers/{crypto => char/hw_random}/qcom-rng.c (53%)

base-commit: 79bbe453e5bfa6e1c6aa2e8329bfc8f152b81c9b

Signature · 1 line
2.54.0.1064.gd145956f57-goog