media: qcom: iris: miscellaneous code-quality fixes
Get series with b4
b4 am 20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com change-id 20260531-iris-code-improvement-48aafaec4b1dVersions newest first · linked by author and title
- v4 Latest7 patches 6 repliesIn review
- v37 patches 0 repliesSuperseded
Changes in v4 from the cover letter
- Updated commit description for "Remove duplicate HFI_PROP_OPB_ENABLE entry" patch (Sashiko AI)
- Link to v3: https://lore.kernel.org/all/20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | media: qcom: iris: Centralize internal buffer table selectiondrivers/ | +26 | 1 reply | |
| 2/7 | media: qcom: iris: fix state-change debug log printing stale valuedrivers/ | +1 | 1 reply | |
| 3/7 | media: qcom: iris: Fix bitmask test in iris_allow_cmd()drivers/ | +1 | 1 reply | |
| 4/7 | media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier()drivers/ | +2 | 1 reply | |
| 5/7 | media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entrydrivers/ | +0 | 1 reply | |
| 6/7 | media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec()drivers/ | +1 | 1 reply | |
| 7/7 | media: qcom: iris: Make iris_destroy_internal_buffer() return voiddrivers/ drivers/ drivers/ +1 more | +9 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Bryan O'Donoghue | Konrad Dybcio | Dmitry Baryshkov |
|---|---|---|---|
| 1/7 | R-b | R-b | |
| 2/7 | R-b | R-b | R-b |
| 3/7 | R-b | R-b | |
| 4/7 | R-b | R-b | |
| 5/7 | R-b | R-b | |
| 6/7 | R-b | R-b | R-b |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/7] media: qcom: iris: miscellaneous code-quality fixes
This series addresses a set of independent code-quality issues found during review of the Qualcomm iris video driver.
No functional changes are intended.
---
Changes in v4:
- Updated commit description for "Remove duplicate HFI_PROP_OPB_ENABLE entry" patch (Sashiko AI)
- Link to v3: https://lore.kernel.org/all/20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com
Changes in v3:
- Rebased and resolved merge conflicts (Bryan)
- Link to v2: https://lore.kernel.org/r/20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com
Changes in v2:
- Updated variables names for iris_get_int_buf_tbl helper (Bryan)
- Removed un-necessary fixes tags (Bryan, Konrad)
- Addressed other comments (Bryan, Konrad)
- Link to v1: https://lore.kernel.org/r/20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com
To: Vikash Garodia <[email protected]>
To: Dikshita Agarwal <[email protected]>
To: Abhinav Kumar <[email protected]>
To: Bryan O'Donoghue <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Hans Verkuil <[email protected]>
To: Stefan Schmidt <[email protected]>
To: Hans Verkuil <[email protected]>
To: Deepa Guthyappa Madivalara <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Bryan O'Donoghue <[email protected]>
---
Dikshita Agarwal (7):
media: qcom: iris: Centralize internal buffer table selection
media: qcom: iris: fix state-change debug log printing stale value
media: qcom: iris: Fix bitmask test in iris_allow_cmd()
media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier()
media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry
media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec()
media: qcom: iris: Make iris_destroy_internal_buffer() return void
drivers/media/platform/qcom/iris/iris_buffer.c | 123 +++++---------------- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- .../platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../platform/qcom/iris/iris_hfi_gen2_command.c | 7 +- .../platform/qcom/iris/iris_hfi_gen2_response.c | 4 +- drivers/media/platform/qcom/iris/iris_state.c | 4 +- 6 files changed, 40 insertions(+), 102 deletions(-)
---
base-commit: b72408a2fd20e8fb7ea462eeb4293f826585fe03
change-id: 20260721-iris-code-improvement-b412d103bd3c
Best regards,
Signature · 1 line
Vishnu Reddy <[email protected]>