Skip to content

RFC mtd: spi-nor: Rework flash parameter initialization

Michael Walle linux-mtd lkml 1 version Applied

Status from this message: Applied to mtd/fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 18 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flagdrivers/mtd/spi-nor/spansion.c+1 -14 replies
2/3mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failuredrivers/mtd/spi-nor/core.c+1 -33 replies
3/3mtd: spi-nor: rework flash parameter initializationdrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/core.h+22 -441 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMiquel RaynalTakahiro KuwanoTudor AmbarusCheng Ming Lin
SeriesT-b T-b
1/3R-b R-b
2/3R-b R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization

Try to simplify the flash initialization and get rid of the legacy handling. As default, all the flags of the in-kernel database are taken and amended with the SFDP data.

This might have the consequence that all the flashes now get a RDSFPD opcode which might be an unknown opcode. But that was already the case for any flashes which were unknown to the linux kernel. So far, there was not a single complaint.

See patch 3 for more information. If feedback is positive, this is intended to be applied to the spi-nor tree after the next merge window, so it will sit around in -next for quite some time and get some testing.

That being said, I've just did a quick test on my boards. Please give it a test on your boards.

Michael Walle (3):
mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
mtd: spi-nor: rework flash parameter initialization

 drivers/mtd/spi-nor/core.c     | 67 +++++++++++-----------------------
 drivers/mtd/spi-nor/core.h     |  1 -
 drivers/mtd/spi-nor/spansion.c |  2 +-
 3 files changed, 23 insertions(+), 47 deletions(-)
Signature · 1 line
2.47.3